diff --git a/src/__tests__/isValidCommitMessage.test.ts b/src/__tests__/isValidCommitMessage.test.ts index 343e425..1b6c436 100644 --- a/src/__tests__/isValidCommitMessage.test.ts +++ b/src/__tests__/isValidCommitMessage.test.ts @@ -2,6 +2,8 @@ import isValidCommitMessage from "../isValidCommitMesage"; test("should be able to correctly validate the commit message", () => { expect(isValidCommitMessage("chore(nice-one): doing this right")).toBe(true); + expect(isValidCommitMessage("feat!: change all the things")).toBe(true); + expect(isValidCommitMessage("fix(user)!: a fix with some breaking changes")).toBe(true); expect(isValidCommitMessage("fix: menu must open on shortcut press")).toBe(true); expect(isValidCommitMessage("something: should not work")).toBe(false); expect(isValidCommitMessage("fixes something")).toBe(false); diff --git a/src/isValidCommitMesage.ts b/src/isValidCommitMesage.ts index fb7ba18..6ae140f 100644 --- a/src/isValidCommitMesage.ts +++ b/src/isValidCommitMesage.ts @@ -31,6 +31,7 @@ const isValidCommitMessage = (message, availableTypes = DEFAULT_COMMIT_TYPES): b possiblyValidCommitType = possiblyValidCommitType .replace(/\s/g, "") // Remove all whitespace + .replace(/\!/g, "") // Remove bang for notify breaking change .replace(/()/g, "") // Remove all whitespace .replace(/[^a-z]/g, ""); // Only leave [a-z] characters.