cafkafk/lix
cafkafk/lix
1
0
Fork 0
Code Issues Pull requests 1 Projects Releases Packages Wiki Activity Actions

nix doctor: add warning if client/daemon protocol mismatches

Browse source 
A protocol mismatch can sometimes cause problems when using specific
features with an older daemon. For example:

Nix 2.0 changed the way files are compied to the store.  The daemon is
backwards compatible and can still handle older clients, however a 1.11
nix-daemon isn't forwards compatible.
This commit is contained in:
Daiderd Jordan 2018-08-30 23:42:28 +02:00
parent 070823baa4
commit 7314dc7f07
No known key found for this signature in database
GPG key ID: D02435D05B810C96
1 changed files with 26 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

27
src/nix/doctor.cc
View file

@ -1,9 +1,20 @@
#include "command.hh" #include "command.hh"
#include "shared.hh" #include "shared.hh"
#include "store-api.hh" #include "store-api.hh"
#include "worker-protocol.hh"
using namespace nix; using namespace nix;
std::string formatProtocol(unsigned int proto)
{
if (proto) {
auto major = GET_PROTOCOL_MAJOR(proto) >> 8;
auto minor = GET_PROTOCOL_MINOR(proto);
return (format("%1%.%2%") % major % minor).str();
}
return "unknown";
}
struct CmdDoctor : StoreCommand struct CmdDoctor : StoreCommand
{ {
std::string name() override std::string name() override
@ -19,8 +30,22 @@ struct CmdDoctor : StoreCommand
void run(ref<Store> store) override void run(ref<Store> store) override
{ {
std::cout << "Store uri: " << store->getUri() << std::endl; std::cout << "Store uri: " << store->getUri() << std::endl;
std::cout << std::endl;
checkStoreProtocol(store->getProtocol());
}
void checkStoreProtocol(unsigned int proto) {
if (PROTOCOL_VERSION != proto) {
std::cout << "Warning: protocol version of this client does not match the store." << std::endl;
std::cout << "While this is not necessarily a problem it's recommended to keep the client in" << std::endl;
std::cout << "sync with the daemon." << std::endl;
std::cout << std::endl;
std::cout << "Client protocol: " << formatProtocol(PROTOCOL_VERSION) << std::endl;
std::cout << "Store protocol: " << formatProtocol(proto) << std::endl;
std::cout << std::endl;
}
} }
}; };
static RegisterCommand r1(make_ref<CmdDoctor>()); static RegisterCommand r1(make_ref<CmdDoctor>());