f7f37035c8
Today, with the tests inside a `tests` intermingled with the
corresponding library's source code, we have a few problems:
- We have to be careful that wildcards don't end up with tests being
built as part of Nix proper, or test headers being installed as part
of Nix proper.
- Tests in libraries but not executables is not right:
- It means each executable runs the previous unit tests again, because
it needs the libraries.
- It doesn't work right on Windows, which doesn't want you to load a
DLL just for the side global variable . It could be made to work
with the dlopen equivalent, but that's gross!
This reorg solves these problems.
There is a remaining problem which is that sibbling headers (like
`hash.hh` the test header vs `hash.hh` the main `libnixutil` header) end
up shadowing each other. This PR doesn't solve that. That is left as
future work for a future PR.
Co-authored-by: Valentin Gagarin <valentin.gagarin@tweag.io>
(cherry picked from commit 91b6833686a6a6d9eac7f3f66393ec89ef1d3b57)
(cherry picked from commit a61e42adb528b3d40ce43e07c79368d779a8b624)
43 lines
1.4 KiB
C++
43 lines
1.4 KiB
C++
#include "suggestions.hh"
|
|
#include <gtest/gtest.h>
|
|
|
|
namespace nix {
|
|
|
|
struct LevenshteinDistanceParam {
|
|
std::string s1, s2;
|
|
int distance;
|
|
};
|
|
|
|
class LevenshteinDistanceTest :
|
|
public testing::TestWithParam<LevenshteinDistanceParam> {
|
|
};
|
|
|
|
TEST_P(LevenshteinDistanceTest, CorrectlyComputed) {
|
|
auto params = GetParam();
|
|
|
|
ASSERT_EQ(levenshteinDistance(params.s1, params.s2), params.distance);
|
|
ASSERT_EQ(levenshteinDistance(params.s2, params.s1), params.distance);
|
|
}
|
|
|
|
INSTANTIATE_TEST_SUITE_P(LevenshteinDistance, LevenshteinDistanceTest,
|
|
testing::Values(
|
|
LevenshteinDistanceParam{"foo", "foo", 0},
|
|
LevenshteinDistanceParam{"foo", "", 3},
|
|
LevenshteinDistanceParam{"", "", 0},
|
|
LevenshteinDistanceParam{"foo", "fo", 1},
|
|
LevenshteinDistanceParam{"foo", "oo", 1},
|
|
LevenshteinDistanceParam{"foo", "fao", 1},
|
|
LevenshteinDistanceParam{"foo", "abc", 3}
|
|
)
|
|
);
|
|
|
|
TEST(Suggestions, Trim) {
|
|
auto suggestions = Suggestions::bestMatches({"foooo", "bar", "fo", "gao"}, "foo");
|
|
auto onlyOne = suggestions.trim(1);
|
|
ASSERT_EQ(onlyOne.suggestions.size(), 1);
|
|
ASSERT_TRUE(onlyOne.suggestions.begin()->suggestion == "fo");
|
|
|
|
auto closest = suggestions.trim(999, 2);
|
|
ASSERT_EQ(closest.suggestions.size(), 3);
|
|
}
|
|
}
|