2022-12-20 17:29:59 +01:00
|
|
|
{ lib
|
|
|
|
, stdenv
|
2020-12-22 00:41:27 +01:00
|
|
|
, buildPackages
|
|
|
|
, fetchurl
|
|
|
|
, bison
|
|
|
|
, util-linux
|
|
|
|
|
|
|
|
# patch for cygwin requires readline support
|
|
|
|
, interactive ? stdenv.isCygwin
|
2022-12-25 21:06:50 +01:00
|
|
|
, readline
|
2020-12-22 00:41:27 +01:00
|
|
|
, withDocs ? false
|
2022-12-25 21:06:50 +01:00
|
|
|
, texinfo
|
2022-02-20 00:34:55 +01:00
|
|
|
, forFHSEnv ? false
|
2023-02-12 13:48:04 +01:00
|
|
|
|
|
|
|
, pkgsStatic
|
2019-01-08 06:54:31 +01:00
|
|
|
}:
|
|
|
|
|
|
|
|
let
|
2022-12-20 17:29:59 +01:00
|
|
|
upstreamPatches = import ./bash-5.2-patches.nix (nr: sha256: fetchurl {
|
|
|
|
url = "mirror://gnu/bash/bash-5.2-patches/bash52-${nr}";
|
2019-01-08 06:54:31 +01:00
|
|
|
inherit sha256;
|
|
|
|
});
|
|
|
|
in
|
|
|
|
stdenv.mkDerivation rec {
|
2024-01-17 12:08:09 +01:00
|
|
|
pname = "bash${lib.optionalString interactive "-interactive"}";
|
|
|
|
version = "5.2${patch_suffix}";
|
|
|
|
patch_suffix = "p${toString (builtins.length upstreamPatches)}";
|
2019-01-08 06:54:31 +01:00
|
|
|
|
|
|
|
src = fetchurl {
|
2024-01-17 12:08:09 +01:00
|
|
|
url = "mirror://gnu/bash/bash-${lib.removeSuffix patch_suffix version}.tar.gz";
|
2022-12-20 17:29:59 +01:00
|
|
|
sha256 = "sha256-oTnBZt9/9EccXgczBRZC7lVWwcyKSnjxRVg8XIGrMvs=";
|
2019-01-08 06:54:31 +01:00
|
|
|
};
|
|
|
|
|
2022-09-23 16:47:53 +02:00
|
|
|
hardeningDisable = [ "format" ]
|
2022-12-20 17:29:59 +01:00
|
|
|
# bionic libc is super weird and has issues with fortify outside of its own libc, check this comment:
|
|
|
|
# https://github.com/NixOS/nixpkgs/pull/192630#discussion_r978985593
|
|
|
|
# or you can check libc/include/sys/cdefs.h in bionic source code
|
|
|
|
++ lib.optional (stdenv.hostPlatform.libc == "bionic") "fortify";
|
2019-01-08 06:54:31 +01:00
|
|
|
|
|
|
|
outputs = [ "out" "dev" "man" "doc" "info" ];
|
|
|
|
|
2023-01-23 13:35:14 +01:00
|
|
|
separateDebugInfo = true;
|
|
|
|
|
2023-02-19 20:23:32 +01:00
|
|
|
env.NIX_CFLAGS_COMPILE = ''
|
2019-01-08 06:54:31 +01:00
|
|
|
-DSYS_BASHRC="/etc/bashrc"
|
|
|
|
-DSYS_BASH_LOGOUT="/etc/bash_logout"
|
2022-12-25 21:06:50 +01:00
|
|
|
'' + lib.optionalString (!forFHSEnv) ''
|
2019-01-08 06:54:31 +01:00
|
|
|
-DDEFAULT_PATH_VALUE="/no-such-path"
|
|
|
|
-DSTANDARD_UTILS_PATH="/no-such-path"
|
2022-02-20 00:34:55 +01:00
|
|
|
'' + ''
|
2019-01-08 06:54:31 +01:00
|
|
|
-DNON_INTERACTIVE_LOGIN_SHELLS
|
|
|
|
-DSSH_SOURCE_BASHRC
|
|
|
|
'';
|
|
|
|
|
2021-03-22 12:27:10 +01:00
|
|
|
patchFlags = [ "-p0" ];
|
2019-01-08 06:54:31 +01:00
|
|
|
|
2023-01-23 12:55:24 +01:00
|
|
|
patches = upstreamPatches ++ [
|
|
|
|
./pgrp-pipe-5.patch
|
|
|
|
(fetchurl {
|
2023-01-13 05:02:35 +01:00
|
|
|
name = "fix-static.patch";
|
|
|
|
url = "https://cgit.freebsd.org/ports/plain/shells/bash/files/patch-configure?id=3e147a1f594751a68fea00a28090d0792bee0b51";
|
|
|
|
sha256 = "XHFMQ6eXTReNoywdETyrfQEv1rKF8+XFbQZP4YoVKFk=";
|
2023-01-23 12:55:24 +01:00
|
|
|
})
|
2023-07-25 00:23:14 +02:00
|
|
|
# Apply parallel build fix pending upstream inclusion:
|
|
|
|
# https://savannah.gnu.org/patch/index.php?10373
|
|
|
|
# Had to fetch manually to workaround -p0 default.
|
|
|
|
./parallel.patch
|
2023-01-23 12:55:24 +01:00
|
|
|
];
|
2019-01-08 06:54:31 +01:00
|
|
|
|
|
|
|
configureFlags = [
|
bash: disable `bash-malloc` everywhere, not just on `musl`
TIme to time I bump into pathological behaviour of `bash` memory
allocator. Today's example:
$ time { ls /nix/store/ > /dev/null; }
real 0m0,965s user 0m0,876s sys 0m0,087s
$ time { echo /nix/store/* > /dev/null; }
real 2m18,287s user 2m17,946s sys 0m0,125s
$ time { echo /nix/store/* > /dev/null; }
real 0m1,764s user 0m1,712s sys 0m0,048s
Note how initial `echo` takes alsmot 2 minutes to finish.
Let's rely on system's allocator instead.
After the change initial run is fast again:
$ time { echo /nix/store/* > /dev/null; }
real 0m1,328s user 0m1,264s sys 0m0,063s
2023-08-19 08:53:39 +02:00
|
|
|
# At least on Linux bash memory allocator has pathological performance
|
|
|
|
# in scenarios involving use of larger memory:
|
|
|
|
# https://lists.gnu.org/archive/html/bug-bash/2023-08/msg00052.html
|
|
|
|
# Various distributions default to system allocator. Let's nixpkgs
|
|
|
|
# do the same.
|
|
|
|
"--without-bash-malloc"
|
2019-01-08 06:54:31 +01:00
|
|
|
(if interactive then "--with-installed-readline" else "--disable-readline")
|
2022-12-25 21:06:50 +01:00
|
|
|
] ++ lib.optionals (stdenv.hostPlatform != stdenv.buildPlatform) [
|
2019-01-08 06:54:31 +01:00
|
|
|
"bash_cv_job_control_missing=nomissing"
|
|
|
|
"bash_cv_sys_named_pipes=nomissing"
|
|
|
|
"bash_cv_getcwd_malloc=yes"
|
2022-12-25 21:06:50 +01:00
|
|
|
] ++ lib.optionals stdenv.hostPlatform.isCygwin [
|
2019-01-08 06:54:31 +01:00
|
|
|
"--without-libintl-prefix"
|
|
|
|
"--without-libiconv-prefix"
|
|
|
|
"--with-installed-readline"
|
|
|
|
"bash_cv_dev_stdin=present"
|
|
|
|
"bash_cv_dev_fd=standard"
|
|
|
|
"bash_cv_termcap_lib=libncurses"
|
2022-12-25 21:06:50 +01:00
|
|
|
] ++ lib.optionals (stdenv.hostPlatform.libc == "musl") [
|
2019-01-08 06:54:31 +01:00
|
|
|
"--disable-nls"
|
|
|
|
];
|
|
|
|
|
2022-05-06 21:44:36 +02:00
|
|
|
strictDeps = true;
|
2019-01-08 06:54:31 +01:00
|
|
|
# Note: Bison is needed because the patches above modify parse.y.
|
|
|
|
depsBuildBuild = [ buildPackages.stdenv.cc ];
|
|
|
|
nativeBuildInputs = [ bison ]
|
2022-12-25 21:06:50 +01:00
|
|
|
++ lib.optional withDocs texinfo
|
2023-09-26 02:57:17 +02:00
|
|
|
++ lib.optional stdenv.hostPlatform.isDarwin stdenv.cc.bintools;
|
2019-01-08 06:54:31 +01:00
|
|
|
|
2022-12-25 21:06:50 +01:00
|
|
|
buildInputs = lib.optional interactive readline;
|
2019-01-08 06:54:31 +01:00
|
|
|
|
2019-01-08 07:16:45 +01:00
|
|
|
enableParallelBuilding = true;
|
2019-01-08 06:54:31 +01:00
|
|
|
|
2022-12-25 21:06:50 +01:00
|
|
|
makeFlags = lib.optionals stdenv.hostPlatform.isCygwin [
|
2019-01-08 06:54:31 +01:00
|
|
|
"LOCAL_LDFLAGS=-Wl,--export-all,--out-implib,libbash.dll.a"
|
|
|
|
"SHOBJ_LIBS=-lbash"
|
|
|
|
];
|
|
|
|
|
2023-01-21 13:00:00 +01:00
|
|
|
nativeCheckInputs = [ util-linux ];
|
2019-01-08 06:54:31 +01:00
|
|
|
doCheck = false; # dependency cycle, needs to be interactive
|
|
|
|
|
|
|
|
postInstall = ''
|
|
|
|
ln -s bash "$out/bin/sh"
|
|
|
|
rm -f $out/lib/bash/Makefile.inc
|
|
|
|
'';
|
|
|
|
|
2020-12-22 00:41:27 +01:00
|
|
|
postFixup =
|
|
|
|
if interactive
|
2019-01-08 06:54:31 +01:00
|
|
|
then ''
|
|
|
|
substituteInPlace "$out/bin/bashbug" \
|
2022-05-06 21:44:36 +02:00
|
|
|
--replace '#!/bin/sh' "#!$out/bin/bash"
|
2019-01-08 06:54:31 +01:00
|
|
|
''
|
|
|
|
# most space is taken by locale data
|
|
|
|
else ''
|
|
|
|
rm -rf "$out/share" "$out/bin/bashbug"
|
|
|
|
'';
|
|
|
|
|
2022-12-25 21:06:50 +01:00
|
|
|
passthru = {
|
|
|
|
shellPath = "/bin/bash";
|
2023-02-12 13:48:04 +01:00
|
|
|
tests.static = pkgsStatic.bash;
|
2022-12-25 21:06:50 +01:00
|
|
|
};
|
|
|
|
|
2021-01-11 08:54:33 +01:00
|
|
|
meta = with lib; {
|
2020-04-01 03:11:51 +02:00
|
|
|
homepage = "https://www.gnu.org/software/bash/";
|
2022-12-25 21:06:50 +01:00
|
|
|
description = "GNU Bourne-Again Shell, the de facto standard shell on Linux" + lib.optionalString interactive " (for interactive use)";
|
2019-01-08 06:54:31 +01:00
|
|
|
longDescription = ''
|
|
|
|
Bash is the shell, or command language interpreter, that will
|
|
|
|
appear in the GNU operating system. Bash is an sh-compatible
|
|
|
|
shell that incorporates useful features from the Korn shell
|
|
|
|
(ksh) and C shell (csh). It is intended to conform to the IEEE
|
|
|
|
POSIX P1003.2/ISO 9945.2 Shell and Tools standard. It offers
|
|
|
|
functional improvements over sh for both programming and
|
|
|
|
interactive use. In addition, most sh scripts can be run by
|
|
|
|
Bash without modification.
|
|
|
|
'';
|
|
|
|
license = licenses.gpl3Plus;
|
|
|
|
platforms = platforms.all;
|
2021-10-14 10:59:33 +02:00
|
|
|
maintainers = with maintainers; [ dtzWill ];
|
2022-02-12 20:06:05 +01:00
|
|
|
mainProgram = "bash";
|
2019-01-08 06:54:31 +01:00
|
|
|
};
|
|
|
|
}
|