2017-07-06 03:47:48 +02:00
|
|
|
{ lib, config, stdenv }:
|
2017-07-05 23:56:53 +02:00
|
|
|
|
|
|
|
rec {
|
|
|
|
# `mkDerivation` wraps the builtin `derivation` function to
|
|
|
|
# produce derivations that use this stdenv and its shell.
|
|
|
|
#
|
|
|
|
# See also:
|
|
|
|
#
|
|
|
|
# * https://nixos.org/nixpkgs/manual/#sec-using-stdenv
|
|
|
|
# Details on how to use this mkDerivation function
|
|
|
|
#
|
|
|
|
# * https://nixos.org/nix/manual/#ssec-derivation
|
|
|
|
# Explanation about derivations in general
|
|
|
|
mkDerivation =
|
2017-07-13 01:00:19 +02:00
|
|
|
{ name ? ""
|
|
|
|
|
stdenv: Fix handling of dependencies and hooks
4 far-reaching changes: Smaller PATH, New vars, different propagation
logic, and different hook logic
Smaller PATH
------------
`buildInputs` no longer go on the PATH at build time, as they cannot be
run when cross compiling and we don't want to special case. Simply make
a `nativeBuildInput` too if one needs them on the PATH. Fixes #21191.
Many new depedendency variables
-------------------------------
See the stdenv chapter of the nixpkgs manual. I pulled out the existing
documentation of dependency specification into a new section, and added
language for these two (and their propagated equivalents) along side
the others'.
More complex propagation logic
------------------------------
Before a propagated*XXX*Input always acted as if it was specified
directly as a *XXX*Input downstream. That's simple enough, but violates
the intended roles of each sort of dep, which has functional and not
just stylistic consequences.
The new algorithm is detailed in the manual, and ensures everything
ends up in the right place. I tried to give both an informal and formal
description, but I suspect in practice it will not make much sense
until one tries cross compiling, after which it will immediately make
sense as the only sane option.
Simplified hook logic
---------------------
Rather than `envHook` and `crossEnvHook`, whose behavior differs
depending on whether we are cross compiling or not, there is now one
hook per sort (or rather non-propagated and propagated pair of sorts)
of dependency. These new hooks have the same meaning regardless of
cross compilation. See the setup hook section of stdenv chapter of the
Nixpkgs manual for more details.
2017-09-11 18:20:20 +02:00
|
|
|
# These types of dependencies are all exhaustively documented in
|
|
|
|
# the "Specifying Dependencies" section of the "Standard
|
|
|
|
# Environment" chapter of the Nixpkgs manual.
|
2017-07-05 23:56:53 +02:00
|
|
|
|
stdenv: Fix handling of dependencies and hooks
4 far-reaching changes: Smaller PATH, New vars, different propagation
logic, and different hook logic
Smaller PATH
------------
`buildInputs` no longer go on the PATH at build time, as they cannot be
run when cross compiling and we don't want to special case. Simply make
a `nativeBuildInput` too if one needs them on the PATH. Fixes #21191.
Many new depedendency variables
-------------------------------
See the stdenv chapter of the nixpkgs manual. I pulled out the existing
documentation of dependency specification into a new section, and added
language for these two (and their propagated equivalents) along side
the others'.
More complex propagation logic
------------------------------
Before a propagated*XXX*Input always acted as if it was specified
directly as a *XXX*Input downstream. That's simple enough, but violates
the intended roles of each sort of dep, which has functional and not
just stylistic consequences.
The new algorithm is detailed in the manual, and ensures everything
ends up in the right place. I tried to give both an informal and formal
description, but I suspect in practice it will not make much sense
until one tries cross compiling, after which it will immediately make
sense as the only sane option.
Simplified hook logic
---------------------
Rather than `envHook` and `crossEnvHook`, whose behavior differs
depending on whether we are cross compiling or not, there is now one
hook per sort (or rather non-propagated and propagated pair of sorts)
of dependency. These new hooks have the same meaning regardless of
cross compilation. See the setup hook section of stdenv chapter of the
Nixpkgs manual for more details.
2017-09-11 18:20:20 +02:00
|
|
|
# TODO(@Ericson2314): Stop using legacy dep attribute names
|
|
|
|
|
|
|
|
# host offset -> target offset
|
|
|
|
, depsBuildBuild ? [] # -1 -> -1
|
|
|
|
, depsBuildBuildPropagated ? [] # -1 -> -1
|
|
|
|
, nativeBuildInputs ? [] # -1 -> 0 N.B. Legacy name
|
|
|
|
, propagatedNativeBuildInputs ? [] # -1 -> 0 N.B. Legacy name
|
|
|
|
, depsBuildTarget ? [] # -1 -> 1
|
|
|
|
, depsBuildTargetPropagated ? [] # -1 -> 1
|
|
|
|
|
|
|
|
, depsHostHost ? [] # 0 -> 0
|
|
|
|
, depsHostHostPropagated ? [] # 0 -> 0
|
|
|
|
, buildInputs ? [] # 0 -> 1 N.B. Legacy name
|
|
|
|
, propagatedBuildInputs ? [] # 0 -> 1 N.B. Legacy name
|
|
|
|
|
|
|
|
, depsTargetTarget ? [] # 1 -> 1
|
|
|
|
, depsTargetTargetPropagated ? [] # 1 -> 1
|
2017-07-05 23:56:53 +02:00
|
|
|
|
2018-01-08 07:33:35 +01:00
|
|
|
# Configure Phase
|
2017-07-13 01:00:19 +02:00
|
|
|
, configureFlags ? []
|
|
|
|
, # Target is not included by default because most programs don't care.
|
|
|
|
# Including it then would cause needless mass rebuilds.
|
|
|
|
#
|
|
|
|
# TODO(@Ericson2314): Make [ "build" "host" ] always the default.
|
|
|
|
configurePlatforms ? lib.optionals
|
|
|
|
(stdenv.hostPlatform != stdenv.buildPlatform)
|
|
|
|
[ "build" "host" ]
|
2018-01-08 07:33:35 +01:00
|
|
|
|
|
|
|
# Check phase
|
|
|
|
, doCheck ? false
|
|
|
|
|
|
|
|
# InstallCheck phase
|
|
|
|
, doInstallCheck ? false
|
|
|
|
|
2017-07-05 23:56:53 +02:00
|
|
|
, crossConfig ? null
|
|
|
|
, meta ? {}
|
|
|
|
, passthru ? {}
|
|
|
|
, pos ? # position used in error messages and for meta.position
|
|
|
|
(if attrs.meta.description or null != null
|
|
|
|
then builtins.unsafeGetAttrPos "description" attrs.meta
|
|
|
|
else builtins.unsafeGetAttrPos "name" attrs)
|
|
|
|
, separateDebugInfo ? false
|
|
|
|
, outputs ? [ "out" ]
|
|
|
|
, __impureHostDeps ? []
|
|
|
|
, __propagatedImpureHostDeps ? []
|
|
|
|
, sandboxProfile ? ""
|
|
|
|
, propagatedSandboxProfile ? ""
|
2017-08-28 20:56:08 +02:00
|
|
|
|
|
|
|
, hardeningEnable ? []
|
|
|
|
, hardeningDisable ? []
|
2018-01-08 07:33:35 +01:00
|
|
|
|
2017-07-05 23:56:53 +02:00
|
|
|
, ... } @ attrs:
|
2017-08-28 20:56:08 +02:00
|
|
|
|
|
|
|
# TODO(@Ericson2314): Make this more modular, and not O(n^2).
|
2017-07-05 23:56:53 +02:00
|
|
|
let
|
2017-09-01 02:46:26 +02:00
|
|
|
supportedHardeningFlags = [ "fortify" "stackprotector" "pie" "pic" "strictoverflow" "format" "relro" "bindnow" ];
|
2017-09-01 11:58:19 +02:00
|
|
|
# hardeningDisable additionally supports "all".
|
2017-09-01 02:46:26 +02:00
|
|
|
erroneousHardeningFlags = lib.subtractLists supportedHardeningFlags (hardeningEnable ++ lib.remove "all" hardeningDisable);
|
|
|
|
in if builtins.length erroneousHardeningFlags != 0
|
|
|
|
then abort ("mkDerivation was called with unsupported hardening flags: " + lib.generators.toPretty {} {
|
|
|
|
inherit erroneousHardeningFlags hardeningDisable hardeningEnable supportedHardeningFlags;
|
|
|
|
})
|
|
|
|
else let
|
2018-01-02 15:52:27 +01:00
|
|
|
references = nativeBuildInputs ++ buildInputs
|
|
|
|
++ propagatedNativeBuildInputs ++ propagatedBuildInputs;
|
|
|
|
|
stdenv: Fix handling of dependencies and hooks
4 far-reaching changes: Smaller PATH, New vars, different propagation
logic, and different hook logic
Smaller PATH
------------
`buildInputs` no longer go on the PATH at build time, as they cannot be
run when cross compiling and we don't want to special case. Simply make
a `nativeBuildInput` too if one needs them on the PATH. Fixes #21191.
Many new depedendency variables
-------------------------------
See the stdenv chapter of the nixpkgs manual. I pulled out the existing
documentation of dependency specification into a new section, and added
language for these two (and their propagated equivalents) along side
the others'.
More complex propagation logic
------------------------------
Before a propagated*XXX*Input always acted as if it was specified
directly as a *XXX*Input downstream. That's simple enough, but violates
the intended roles of each sort of dep, which has functional and not
just stylistic consequences.
The new algorithm is detailed in the manual, and ensures everything
ends up in the right place. I tried to give both an informal and formal
description, but I suspect in practice it will not make much sense
until one tries cross compiling, after which it will immediately make
sense as the only sane option.
Simplified hook logic
---------------------
Rather than `envHook` and `crossEnvHook`, whose behavior differs
depending on whether we are cross compiling or not, there is now one
hook per sort (or rather non-propagated and propagated pair of sorts)
of dependency. These new hooks have the same meaning regardless of
cross compilation. See the setup hook section of stdenv chapter of the
Nixpkgs manual for more details.
2017-09-11 18:20:20 +02:00
|
|
|
dependencies = map (map lib.chooseDevOutputs) [
|
|
|
|
[
|
|
|
|
(map (drv: drv.__spliced.buildBuild or drv) depsBuildBuild)
|
|
|
|
(map (drv: drv.nativeDrv or drv) nativeBuildInputs
|
|
|
|
++ lib.optional separateDebugInfo ../../build-support/setup-hooks/separate-debug-info.sh
|
|
|
|
++ lib.optional stdenv.hostPlatform.isWindows ../../build-support/setup-hooks/win-dll-link.sh)
|
|
|
|
(map (drv: drv.__spliced.buildTarget or drv) depsBuildTarget)
|
|
|
|
]
|
|
|
|
[
|
|
|
|
(map (drv: drv.__spliced.hostHost or drv) depsHostHost)
|
|
|
|
(map (drv: drv.crossDrv or drv) buildInputs)
|
|
|
|
]
|
|
|
|
[
|
|
|
|
(map (drv: drv.__spliced.targetTarget or drv) depsTargetTarget)
|
|
|
|
]
|
2017-07-05 23:56:53 +02:00
|
|
|
];
|
stdenv: Fix handling of dependencies and hooks
4 far-reaching changes: Smaller PATH, New vars, different propagation
logic, and different hook logic
Smaller PATH
------------
`buildInputs` no longer go on the PATH at build time, as they cannot be
run when cross compiling and we don't want to special case. Simply make
a `nativeBuildInput` too if one needs them on the PATH. Fixes #21191.
Many new depedendency variables
-------------------------------
See the stdenv chapter of the nixpkgs manual. I pulled out the existing
documentation of dependency specification into a new section, and added
language for these two (and their propagated equivalents) along side
the others'.
More complex propagation logic
------------------------------
Before a propagated*XXX*Input always acted as if it was specified
directly as a *XXX*Input downstream. That's simple enough, but violates
the intended roles of each sort of dep, which has functional and not
just stylistic consequences.
The new algorithm is detailed in the manual, and ensures everything
ends up in the right place. I tried to give both an informal and formal
description, but I suspect in practice it will not make much sense
until one tries cross compiling, after which it will immediately make
sense as the only sane option.
Simplified hook logic
---------------------
Rather than `envHook` and `crossEnvHook`, whose behavior differs
depending on whether we are cross compiling or not, there is now one
hook per sort (or rather non-propagated and propagated pair of sorts)
of dependency. These new hooks have the same meaning regardless of
cross compilation. See the setup hook section of stdenv chapter of the
Nixpkgs manual for more details.
2017-09-11 18:20:20 +02:00
|
|
|
propagatedDependencies = map (map lib.chooseDevOutputs) [
|
|
|
|
[
|
|
|
|
(map (drv: drv.__spliced.buildBuild or drv) depsBuildBuildPropagated)
|
|
|
|
(map (drv: drv.nativeDrv or drv) propagatedNativeBuildInputs)
|
|
|
|
(map (drv: drv.__spliced.buildTarget or drv) depsBuildTargetPropagated)
|
|
|
|
]
|
|
|
|
[
|
|
|
|
(map (drv: drv.__spliced.hostHost or drv) depsHostHostPropagated)
|
|
|
|
(map (drv: drv.crossDrv or drv) propagatedBuildInputs)
|
|
|
|
]
|
|
|
|
[
|
|
|
|
(map (drv: drv.__spliced.targetTarget or drv) depsTargetTargetPropagated)
|
|
|
|
]
|
2017-07-05 23:56:53 +02:00
|
|
|
];
|
|
|
|
|
|
|
|
outputs' =
|
|
|
|
outputs ++
|
2017-07-06 03:47:48 +02:00
|
|
|
(if separateDebugInfo then assert stdenv.hostPlatform.isLinux; [ "debug" ] else []);
|
2017-07-05 23:56:53 +02:00
|
|
|
|
|
|
|
derivationArg =
|
|
|
|
(removeAttrs attrs
|
|
|
|
["meta" "passthru" "crossAttrs" "pos"
|
|
|
|
"__impureHostDeps" "__propagatedImpureHostDeps"
|
|
|
|
"sandboxProfile" "propagatedSandboxProfile"])
|
|
|
|
// (let
|
|
|
|
computedSandboxProfile =
|
2017-08-15 17:30:45 +02:00
|
|
|
lib.concatMap (input: input.__propagatedSandboxProfile or [])
|
|
|
|
(stdenv.extraNativeBuildInputs
|
|
|
|
++ stdenv.extraBuildInputs
|
|
|
|
++ lib.concatLists dependencies);
|
2017-07-05 23:56:53 +02:00
|
|
|
computedPropagatedSandboxProfile =
|
2017-08-15 17:30:45 +02:00
|
|
|
lib.concatMap (input: input.__propagatedSandboxProfile or [])
|
|
|
|
(lib.concatLists propagatedDependencies);
|
2017-07-05 23:56:53 +02:00
|
|
|
computedImpureHostDeps =
|
2017-08-15 17:30:45 +02:00
|
|
|
lib.unique (lib.concatMap (input: input.__propagatedImpureHostDeps or [])
|
|
|
|
(stdenv.extraNativeBuildInputs
|
|
|
|
++ stdenv.extraBuildInputs
|
|
|
|
++ lib.concatLists dependencies));
|
2017-07-05 23:56:53 +02:00
|
|
|
computedPropagatedImpureHostDeps =
|
2017-08-15 17:30:45 +02:00
|
|
|
lib.unique (lib.concatMap (input: input.__propagatedImpureHostDeps or [])
|
|
|
|
(lib.concatLists propagatedDependencies));
|
2017-07-05 23:56:53 +02:00
|
|
|
in
|
|
|
|
{
|
2018-01-03 16:22:35 +01:00
|
|
|
# A hack to make `nix-env -qa` and `nix search` ignore broken packages.
|
|
|
|
# TODO(@oxij): remove this assert when something like NixOS/nix#1771 gets merged into nix.
|
|
|
|
name = assert validity.handled; name + lib.optionalString
|
2017-07-13 01:00:19 +02:00
|
|
|
(stdenv.hostPlatform != stdenv.buildPlatform)
|
2017-09-19 00:56:03 +02:00
|
|
|
("-" + stdenv.hostPlatform.config);
|
2018-01-03 16:22:35 +01:00
|
|
|
|
2017-07-05 23:56:53 +02:00
|
|
|
builder = attrs.realBuilder or stdenv.shell;
|
|
|
|
args = attrs.args or ["-e" (attrs.builder or ./default-builder.sh)];
|
|
|
|
inherit stdenv;
|
2017-07-06 03:47:48 +02:00
|
|
|
inherit (stdenv) system;
|
2017-07-05 23:56:53 +02:00
|
|
|
userHook = config.stdenv.userHook or null;
|
|
|
|
__ignoreNulls = true;
|
|
|
|
|
stdenv: Fix handling of dependencies and hooks
4 far-reaching changes: Smaller PATH, New vars, different propagation
logic, and different hook logic
Smaller PATH
------------
`buildInputs` no longer go on the PATH at build time, as they cannot be
run when cross compiling and we don't want to special case. Simply make
a `nativeBuildInput` too if one needs them on the PATH. Fixes #21191.
Many new depedendency variables
-------------------------------
See the stdenv chapter of the nixpkgs manual. I pulled out the existing
documentation of dependency specification into a new section, and added
language for these two (and their propagated equivalents) along side
the others'.
More complex propagation logic
------------------------------
Before a propagated*XXX*Input always acted as if it was specified
directly as a *XXX*Input downstream. That's simple enough, but violates
the intended roles of each sort of dep, which has functional and not
just stylistic consequences.
The new algorithm is detailed in the manual, and ensures everything
ends up in the right place. I tried to give both an informal and formal
description, but I suspect in practice it will not make much sense
until one tries cross compiling, after which it will immediately make
sense as the only sane option.
Simplified hook logic
---------------------
Rather than `envHook` and `crossEnvHook`, whose behavior differs
depending on whether we are cross compiling or not, there is now one
hook per sort (or rather non-propagated and propagated pair of sorts)
of dependency. These new hooks have the same meaning regardless of
cross compilation. See the setup hook section of stdenv chapter of the
Nixpkgs manual for more details.
2017-09-11 18:20:20 +02:00
|
|
|
depsBuildBuild = lib.elemAt (lib.elemAt dependencies 0) 0;
|
|
|
|
nativeBuildInputs = lib.elemAt (lib.elemAt dependencies 0) 1;
|
|
|
|
depsBuildTarget = lib.elemAt (lib.elemAt dependencies 0) 2;
|
|
|
|
depsHostBuild = lib.elemAt (lib.elemAt dependencies 1) 0;
|
|
|
|
buildInputs = lib.elemAt (lib.elemAt dependencies 1) 1;
|
|
|
|
depsTargetTarget = lib.elemAt (lib.elemAt dependencies 2) 0;
|
2017-07-05 23:56:53 +02:00
|
|
|
|
stdenv: Fix handling of dependencies and hooks
4 far-reaching changes: Smaller PATH, New vars, different propagation
logic, and different hook logic
Smaller PATH
------------
`buildInputs` no longer go on the PATH at build time, as they cannot be
run when cross compiling and we don't want to special case. Simply make
a `nativeBuildInput` too if one needs them on the PATH. Fixes #21191.
Many new depedendency variables
-------------------------------
See the stdenv chapter of the nixpkgs manual. I pulled out the existing
documentation of dependency specification into a new section, and added
language for these two (and their propagated equivalents) along side
the others'.
More complex propagation logic
------------------------------
Before a propagated*XXX*Input always acted as if it was specified
directly as a *XXX*Input downstream. That's simple enough, but violates
the intended roles of each sort of dep, which has functional and not
just stylistic consequences.
The new algorithm is detailed in the manual, and ensures everything
ends up in the right place. I tried to give both an informal and formal
description, but I suspect in practice it will not make much sense
until one tries cross compiling, after which it will immediately make
sense as the only sane option.
Simplified hook logic
---------------------
Rather than `envHook` and `crossEnvHook`, whose behavior differs
depending on whether we are cross compiling or not, there is now one
hook per sort (or rather non-propagated and propagated pair of sorts)
of dependency. These new hooks have the same meaning regardless of
cross compilation. See the setup hook section of stdenv chapter of the
Nixpkgs manual for more details.
2017-09-11 18:20:20 +02:00
|
|
|
depsBuildBuildPropagated = lib.elemAt (lib.elemAt propagatedDependencies 0) 0;
|
|
|
|
propagatedNativeBuildInputs = lib.elemAt (lib.elemAt propagatedDependencies 0) 1;
|
|
|
|
depsBuildTargetPropagated = lib.elemAt (lib.elemAt propagatedDependencies 0) 2;
|
|
|
|
depsHostBuildPropagated = lib.elemAt (lib.elemAt propagatedDependencies 1) 0;
|
|
|
|
propagatedBuildInputs = lib.elemAt (lib.elemAt propagatedDependencies 1) 1;
|
|
|
|
depsTargetTargetPropagated = lib.elemAt (lib.elemAt propagatedDependencies 2) 0;
|
2017-07-13 01:00:19 +02:00
|
|
|
|
2017-07-15 19:47:21 +02:00
|
|
|
# This parameter is sometimes a string, sometimes null, and sometimes a list, yuck
|
2017-07-13 01:00:19 +02:00
|
|
|
configureFlags = let inherit (lib) optional elem; in
|
2017-07-15 19:47:21 +02:00
|
|
|
(/**/ if lib.isString configureFlags then [configureFlags]
|
|
|
|
else if configureFlags == null then []
|
|
|
|
else configureFlags)
|
2017-07-13 01:00:19 +02:00
|
|
|
++ optional (elem "build" configurePlatforms) "--build=${stdenv.buildPlatform.config}"
|
|
|
|
++ optional (elem "host" configurePlatforms) "--host=${stdenv.hostPlatform.config}"
|
|
|
|
++ optional (elem "target" configurePlatforms) "--target=${stdenv.targetPlatform.config}";
|
|
|
|
|
2017-07-06 03:47:48 +02:00
|
|
|
} // lib.optionalAttrs (stdenv.buildPlatform.isDarwin) {
|
2017-07-05 23:56:53 +02:00
|
|
|
# TODO: remove lib.unique once nix has a list canonicalization primitive
|
|
|
|
__sandboxProfile =
|
2017-07-06 01:58:24 +02:00
|
|
|
let profiles = [ stdenv.extraSandboxProfile ] ++ computedSandboxProfile ++ computedPropagatedSandboxProfile ++ [ propagatedSandboxProfile sandboxProfile ];
|
2017-07-05 23:56:53 +02:00
|
|
|
final = lib.concatStringsSep "\n" (lib.filter (x: x != "") (lib.unique profiles));
|
|
|
|
in final;
|
|
|
|
__propagatedSandboxProfile = lib.unique (computedPropagatedSandboxProfile ++ [ propagatedSandboxProfile ]);
|
2017-07-06 01:58:24 +02:00
|
|
|
__impureHostDeps = computedImpureHostDeps ++ computedPropagatedImpureHostDeps ++ __propagatedImpureHostDeps ++ __impureHostDeps ++ stdenv.__extraImpureHostDeps ++ [
|
2017-07-05 23:56:53 +02:00
|
|
|
"/dev/zero"
|
|
|
|
"/dev/random"
|
|
|
|
"/dev/urandom"
|
|
|
|
"/bin/sh"
|
|
|
|
];
|
|
|
|
__propagatedImpureHostDeps = computedPropagatedImpureHostDeps ++ __propagatedImpureHostDeps;
|
2018-01-08 07:33:35 +01:00
|
|
|
} // lib.optionalAttrs (outputs' != [ "out" ]) {
|
2017-07-05 23:56:53 +02:00
|
|
|
outputs = outputs';
|
2018-01-08 07:33:35 +01:00
|
|
|
} // lib.optionalAttrs (attrs ? doCheck) {
|
|
|
|
# TODO(@Ericson2314): Make unconditional / resolve #33599
|
2018-01-09 22:21:24 +01:00
|
|
|
doCheck = doCheck && (stdenv.hostPlatform == stdenv.buildPlatform);
|
2018-01-08 07:33:35 +01:00
|
|
|
} // lib.optionalAttrs (attrs ? doInstallCheck) {
|
|
|
|
# TODO(@Ericson2314): Make unconditional / resolve #33599
|
2018-01-09 22:21:24 +01:00
|
|
|
doInstallCheck = doInstallCheck && (stdenv.hostPlatform == stdenv.buildPlatform);
|
2018-01-08 07:33:35 +01:00
|
|
|
});
|
2017-07-05 23:56:53 +02:00
|
|
|
|
2017-12-25 18:38:45 +01:00
|
|
|
validity = import ./check-meta.nix {
|
2018-01-31 04:10:34 +01:00
|
|
|
inherit lib config meta;
|
2017-12-25 18:38:45 +01:00
|
|
|
# Nix itself uses the `system` field of a derivation to decide where
|
|
|
|
# to build it. This is a bit confusing for cross compilation.
|
lib, stdenv: Check `meta.platforms` against host platform and be open world
First, we need check against the host platform, not the build platform.
That's simple enough.
Second, we move away from exahustive finite case analysis (i.e.
exhaustively listing all platforms the package builds on). That only
work in a closed-world setting, where we know all platforms we might
build one. But with cross compilation, we may be building for arbitrary
platforms, So we need fancier filters. This is the closed world to open
world change.
The solution is instead of having a list of systems (strings in the form
"foo-bar"), we have a list of of systems or "patterns", i.e. attributes
that partially match the output of the parsers in `lib.systems.parse`.
The "check meta" logic treats the systems strings as an exact whitelist
just as before, but treats the patterns as a fuzzy whitelist,
intersecting the actual `hostPlatform` with the pattern and then
checking for equality. (This is done using `matchAttrs`).
The default convenience lists for `meta.platforms` are now changed to be
lists of patterns (usually a single pattern) in
`lib/systems/for-meta.nix` for maximum flexibility under this new
system.
Fixes #30902
2018-01-31 06:11:03 +01:00
|
|
|
inherit (stdenv) hostPlatform;
|
2018-01-31 04:10:34 +01:00
|
|
|
} attrs;
|
2017-12-25 18:38:45 +01:00
|
|
|
|
2017-07-05 23:56:53 +02:00
|
|
|
# The meta attribute is passed in the resulting attribute set,
|
|
|
|
# but it's not part of the actual derivation, i.e., it's not
|
|
|
|
# passed to the builder and is not a dependency. But since we
|
|
|
|
# include it in the result, it *is* available to nix-env for queries.
|
2018-01-02 15:52:27 +01:00
|
|
|
meta = {
|
2018-01-03 16:22:35 +01:00
|
|
|
# `name` above includes cross-compilation cruft (and is under assert),
|
|
|
|
# lets have a clean always accessible version here.
|
|
|
|
inherit name;
|
|
|
|
|
2017-07-05 23:56:53 +02:00
|
|
|
# If the packager hasn't specified `outputsToInstall`, choose a default,
|
|
|
|
# which is the name of `p.bin or p.out or p`;
|
|
|
|
# if he has specified it, it will be overridden below in `// meta`.
|
|
|
|
# Note: This default probably shouldn't be globally configurable.
|
|
|
|
# Services and users should specify outputs explicitly,
|
|
|
|
# unless they are comfortable with this default.
|
2018-01-02 15:52:27 +01:00
|
|
|
outputsToInstall =
|
|
|
|
let
|
|
|
|
outs = outputs'; # the value passed to derivation primitive
|
|
|
|
hasOutput = out: builtins.elem out outs;
|
|
|
|
in [( lib.findFirst hasOutput null (["bin" "out"] ++ outs) )];
|
2017-07-05 23:56:53 +02:00
|
|
|
}
|
|
|
|
// attrs.meta or {}
|
2018-01-02 15:52:27 +01:00
|
|
|
# Fill `meta.position` to identify the source location of the package.
|
|
|
|
// lib.optionalAttrs (pos != null) {
|
|
|
|
position = pos.file + ":" + toString pos.line;
|
2018-01-02 15:52:27 +01:00
|
|
|
# Expose the result of the checks for everyone to see.
|
|
|
|
} // {
|
2018-02-17 19:44:23 +01:00
|
|
|
available = validity.valid
|
2018-01-02 15:52:27 +01:00
|
|
|
&& (if config.checkMetaRecursively or false
|
2018-02-17 19:44:23 +01:00
|
|
|
then lib.all (d: d.meta.available or true) references
|
2018-01-02 15:52:27 +01:00
|
|
|
else true);
|
2018-01-02 15:52:27 +01:00
|
|
|
};
|
2017-07-05 23:56:53 +02:00
|
|
|
|
|
|
|
in
|
|
|
|
|
2017-12-25 18:38:45 +01:00
|
|
|
lib.extendDerivation
|
|
|
|
validity.handled
|
|
|
|
({
|
|
|
|
overrideAttrs = f: mkDerivation (attrs // (f attrs));
|
|
|
|
inherit meta passthru;
|
|
|
|
} //
|
|
|
|
# Pass through extra attributes that are not inputs, but
|
|
|
|
# should be made available to Nix expressions using the
|
|
|
|
# derivation (e.g., in assertions).
|
|
|
|
passthru)
|
|
|
|
(derivation derivationArg);
|
|
|
|
|
2017-07-05 23:56:53 +02:00
|
|
|
}
|