From 04ae8fffa73f05a25e14ff5ca4f0e51958bfe0a1 Mon Sep 17 00:00:00 2001
From: Doron Behar <doron.behar@gmail.com>
Date: Fri, 30 Jun 2023 15:40:30 +0300
Subject: [PATCH] beets: disable failing test

Reported here: https://github.com/beetbox/beets/issues/4836
---
 pkgs/tools/audio/beets/common.nix             |  3 +++
 .../remove-failing-embedart-test.patch        | 24 +++++++++++++++++++
 2 files changed, 27 insertions(+)
 create mode 100644 pkgs/tools/audio/beets/patches/remove-failing-embedart-test.patch

diff --git a/pkgs/tools/audio/beets/common.nix b/pkgs/tools/audio/beets/common.nix
index b3eefbf9cba6..10db9441258a 100644
--- a/pkgs/tools/audio/beets/common.nix
+++ b/pkgs/tools/audio/beets/common.nix
@@ -52,6 +52,9 @@ python3Packages.buildPythonApplication rec {
   patches = [
     # Bash completion fix for Nix
     ./patches/bash-completion-always-print.patch
+    # Reported upstream at:
+    # https://github.com/beetbox/beets/issues/4836
+    ./patches/remove-failing-embedart-test.patch
     (fetchpatch {
       # Fix unidecode>=1.3.5 compat
       url = "https://github.com/beetbox/beets/commit/5ae1e0f3c8d3a450cb39f7933aa49bb78c2bc0d9.patch";
diff --git a/pkgs/tools/audio/beets/patches/remove-failing-embedart-test.patch b/pkgs/tools/audio/beets/patches/remove-failing-embedart-test.patch
new file mode 100644
index 000000000000..ac531ef20c65
--- /dev/null
+++ b/pkgs/tools/audio/beets/patches/remove-failing-embedart-test.patch
@@ -0,0 +1,24 @@
+diff --git i/test/test_embedart.py w/test/test_embedart.py
+index 23a6f5e5..91b9c8c2 100644
+--- i/test/test_embedart.py
++++ w/test/test_embedart.py
+@@ -163,19 +163,6 @@ class EmbedartCliTest(TestHelper, FetchImageHelper):
+                          'Image written is not {}'.format(
+                          displayable_path(self.abbey_artpath)))
+ 
+-    @require_artresizer_compare
+-    def test_accept_similar_art(self):
+-        self._setup_data(self.abbey_similarpath)
+-        album = self.add_album_fixture()
+-        item = album.items()[0]
+-        self.run_command('embedart', '-y', '-f', self.abbey_artpath)
+-        config['embedart']['compare_threshold'] = 20
+-        self.run_command('embedart', '-y', '-f', self.abbey_similarpath)
+-        mediafile = MediaFile(syspath(item.path))
+-
+-        self.assertEqual(mediafile.images[0].data, self.image_data,
+-                         'Image written is not {}'.format(
+-                         displayable_path(self.abbey_similarpath)))
+ 
+     def test_non_ascii_album_path(self):
+         resource_path = os.path.join(_common.RSRC, b'image.mp3')