cafkafk/nixpkgs
cafkafk/nixpkgs
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions 2

buildBazelPackage: never append to fFetchAttrs.installPhase

Browse source 
In f8ee061247, the fallback installPhase
if fFetchAttrs.installPhase is not provided, became dynamically computed.
Due to operator precedence this had the side effect of appending to
fFetchAttrs.installPhase if it is provided, breaking custom
installPhases altogether.
This commit is contained in:
sternenseemann 2023-04-26 13:02:00 +02:00
parent 513e072bcc
commit 1d71d2e883
1 changed files with 2 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
pkgs/build-support/build-bazel-package/default.nix
View file

@ -139,7 +139,7 @@ stdenv.mkDerivation (fBuildAttrs // {
runHook postBuild
'';
installPhase = fFetchAttrs.installPhase or ''
installPhase = fFetchAttrs.installPhase or (''
runHook preInstall
# Remove all built in external workspaces, Bazel will recreate them when building
@ -183,7 +183,7 @@ stdenv.mkDerivation (fBuildAttrs // {
(cd $bazelOut/ && tar czf $out --sort=name --mtime='@1' --owner=0 --group=0 --numeric-owner external/)
runHook postInstall
'';
'');
dontFixup = true;
allowedRequisites = [];