From 275f9025ca55e2f3f2c65a94ea9557be02a11cd9 Mon Sep 17 00:00:00 2001 From: Sergei Trofimovich Date: Wed, 1 Jun 2022 16:08:01 +0100 Subject: [PATCH] netdata: use disallowedReferences to guard against closure regressions Suggested by Mindavi in https://github.com/NixOS/nixpkgs/pull/175719#issuecomment-1143586412. --- pkgs/tools/system/netdata/default.nix | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/pkgs/tools/system/netdata/default.nix b/pkgs/tools/system/netdata/default.nix index dd50e48f0735..24c791bed4a4 100644 --- a/pkgs/tools/system/netdata/default.nix +++ b/pkgs/tools/system/netdata/default.nix @@ -55,6 +55,13 @@ in stdenv.mkDerivation rec { ./skip-CONFIGURE_COMMAND.patch ]; + # Guard against unused buld-time development inputs in closure. Without + # the ./skip-CONFIGURE_COMMAND.patch patch the closure retains inputs up + # to bootstrap tools: + # https://github.com/NixOS/nixpkgs/pull/175719 + # We pick zlib.dev as a simple canary package with pkg-config input. + disallowedReferences = [ zlib.dev ]; + NIX_CFLAGS_COMPILE = optionalString withDebug "-O1 -ggdb -DNETDATA_INTERNAL_CHECKS=1"; postInstall = ''