From 30a6bef0266576857c3597f8aac19326bfee4983 Mon Sep 17 00:00:00 2001 From: Madoura Date: Mon, 28 Nov 2022 05:53:23 -0600 Subject: [PATCH] rocm-related: deprecate rocmVersion and repoVersion clang-ocl: deprecate rocmVersion and repoVersion hipcub: deprecate rocmVersion and repoVersion hipsparse: deprecate rocmVersion and repoVersion miopen: deprecate rocmVersion and repoVersion miopengemm: deprecate rocmVersion and repoVersion rccl: deprecate rocmVersion and repoVersion rocblas: deprecate rocmVersion and repoVersion rocfft: deprecate rocmVersion and repoVersion rocmlir: deprecate rocmVersion and repoVersion rocprim: deprecate rocmVersion and repoVersion rocrand: deprecate rocmVersion and repoVersion rocsparse: deprecate rocmVersion and repoVersion rocthrust: deprecate rocmVersion and repoVersion rocwmma: deprecate rocmVersion and repoVersion tensile: deprecate rocmVersion and repoVersion --- pkgs/development/libraries/clang-ocl/default.nix | 12 ++++++------ pkgs/development/libraries/hipcub/default.nix | 16 ++++++---------- pkgs/development/libraries/hipsparse/default.nix | 16 ++++++---------- pkgs/development/libraries/miopen/default.nix | 15 ++++++--------- .../development/libraries/miopengemm/default.nix | 12 ++++++------ pkgs/development/libraries/rccl/default.nix | 16 ++++++---------- pkgs/development/libraries/rocblas/default.nix | 16 ++++++---------- pkgs/development/libraries/rocfft/default.nix | 16 ++++++---------- pkgs/development/libraries/rocmlir/default.nix | 12 ++++++------ pkgs/development/libraries/rocprim/default.nix | 16 ++++++---------- pkgs/development/libraries/rocrand/default.nix | 16 ++++++---------- pkgs/development/libraries/rocsparse/default.nix | 16 ++++++---------- pkgs/development/libraries/rocthrust/default.nix | 16 ++++++---------- pkgs/development/libraries/rocwmma/default.nix | 16 ++++++---------- pkgs/development/libraries/tensile/default.nix | 14 +++++--------- 15 files changed, 89 insertions(+), 136 deletions(-) diff --git a/pkgs/development/libraries/clang-ocl/default.nix b/pkgs/development/libraries/clang-ocl/default.nix index eb5bde219f76..7a8d5061bbbc 100644 --- a/pkgs/development/libraries/clang-ocl/default.nix +++ b/pkgs/development/libraries/clang-ocl/default.nix @@ -10,13 +10,12 @@ stdenv.mkDerivation (finalAttrs: { pname = "clang-ocl"; - rocmVersion = "5.3.3"; - version = finalAttrs.rocmVersion; + version = "5.3.3"; src = fetchFromGitHub { owner = "RadeonOpenCompute"; repo = "clang-ocl"; - rev = "rocm-${finalAttrs.rocmVersion}"; + rev = "rocm-${finalAttrs.version}"; hash = "sha256-uMSvcVJj+me2E+7FsXZ4l4hTcK6uKEegXpkHGcuist0="; }; @@ -38,8 +37,9 @@ stdenv.mkDerivation (finalAttrs: { passthru.updateScript = writeScript "update.sh" '' #!/usr/bin/env nix-shell #!nix-shell -i bash -p curl jq common-updater-scripts - rocmVersion="$(curl ''${GITHUB_TOKEN:+"-u \":$GITHUB_TOKEN\""} -sL "https://api.github.com/repos/RadeonOpenCompute/clang-ocl/releases?per_page=1" | jq '.[0].tag_name | split("-") | .[1]' --raw-output)" - update-source-version clang-ocl "$rocmVersion" --ignore-same-hash --version-key=rocmVersion + version="$(curl ''${GITHUB_TOKEN:+"-u \":$GITHUB_TOKEN\""} \ + -sL "https://api.github.com/repos/RadeonOpenCompute/clang-ocl/releases?per_page=1" | jq '.[0].tag_name | split("-") | .[1]' --raw-output)" + update-source-version clang-ocl "$version" --ignore-same-hash ''; meta = with lib; { @@ -47,6 +47,6 @@ stdenv.mkDerivation (finalAttrs: { homepage = "https://github.com/RadeonOpenCompute/clang-ocl"; license = with licenses; [ mit ]; maintainers = teams.rocm.members; - broken = finalAttrs.rocmVersion != clang.version; + broken = finalAttrs.version != clang.version; }; }) diff --git a/pkgs/development/libraries/hipcub/default.nix b/pkgs/development/libraries/hipcub/default.nix index 29310be85368..651f5ccc5b59 100644 --- a/pkgs/development/libraries/hipcub/default.nix +++ b/pkgs/development/libraries/hipcub/default.nix @@ -18,9 +18,7 @@ # CUB can also be used as a backend instead of rocPRIM. stdenv.mkDerivation (finalAttrs: { pname = "hipcub"; - repoVersion = "2.12.0"; - rocmVersion = "5.3.3"; - version = "${finalAttrs.repoVersion}-${finalAttrs.rocmVersion}"; + version = "5.3.3"; outputs = [ "out" @@ -33,7 +31,7 @@ stdenv.mkDerivation (finalAttrs: { src = fetchFromGitHub { owner = "ROCmSoftwarePlatform"; repo = "hipCUB"; - rev = "rocm-${finalAttrs.rocmVersion}"; + rev = "rocm-${finalAttrs.version}"; hash = "sha256-/GMZKbMD1sZQCM2FulM9jiJQ8ByYZinn0C8d/deFh0g="; }; @@ -81,11 +79,9 @@ stdenv.mkDerivation (finalAttrs: { passthru.updateScript = writeScript "update.sh" '' #!/usr/bin/env nix-shell #!nix-shell -i bash -p curl jq common-updater-scripts - json="$(curl ''${GITHUB_TOKEN:+"-u \":$GITHUB_TOKEN\""} -sL "https://api.github.com/repos/ROCmSoftwarePlatform/hipCUB/releases?per_page=1")" - repoVersion="$(echo "$json" | jq '.[0].name | split(" ") | .[1]' --raw-output)" - rocmVersion="$(echo "$json" | jq '.[0].tag_name | split("-") | .[1]' --raw-output)" - update-source-version hipcub "$repoVersion" --ignore-same-hash --version-key=repoVersion - update-source-version hipcub "$rocmVersion" --ignore-same-hash --version-key=rocmVersion + version="$(curl ''${GITHUB_TOKEN:+"-u \":$GITHUB_TOKEN\""} \ + -sL "https://api.github.com/repos/ROCmSoftwarePlatform/hipCUB/releases?per_page=1" | jq '.[0].tag_name | split("-") | .[1]' --raw-output)" + update-source-version hipcub "$version" --ignore-same-hash ''; meta = with lib; { @@ -93,6 +89,6 @@ stdenv.mkDerivation (finalAttrs: { homepage = "https://github.com/ROCmSoftwarePlatform/hipCUB"; license = with licenses; [ bsd3 ]; maintainers = teams.rocm.members; - broken = finalAttrs.rocmVersion != hip.version; + broken = finalAttrs.version != hip.version; }; }) diff --git a/pkgs/development/libraries/hipsparse/default.nix b/pkgs/development/libraries/hipsparse/default.nix index 68c94ba4867c..182173fccdb5 100644 --- a/pkgs/development/libraries/hipsparse/default.nix +++ b/pkgs/development/libraries/hipsparse/default.nix @@ -18,9 +18,7 @@ # This can also use cuSPARSE as a backend instead of rocSPARSE stdenv.mkDerivation (finalAttrs: { pname = "hipsparse"; - repoVersion = "2.3.1"; - rocmVersion = "5.3.3"; - version = "${finalAttrs.repoVersion}-${finalAttrs.rocmVersion}"; + version = "5.3.3"; outputs = [ "out" @@ -31,7 +29,7 @@ stdenv.mkDerivation (finalAttrs: { src = fetchFromGitHub { owner = "ROCmSoftwarePlatform"; repo = "hipSPARSE"; - rev = "rocm-${finalAttrs.rocmVersion}"; + rev = "rocm-${finalAttrs.version}"; hash = "sha256-Phcihat774ZSAe1QetE/GSZzGlnCnvS9GwsHBHCaD4c="; }; @@ -117,11 +115,9 @@ stdenv.mkDerivation (finalAttrs: { passthru.updateScript = writeScript "update.sh" '' #!/usr/bin/env nix-shell #!nix-shell -i bash -p curl jq common-updater-scripts - json="$(curl ''${GITHUB_TOKEN:+"-u \":$GITHUB_TOKEN\""} -sL "https://api.github.com/repos/ROCmSoftwarePlatform/hipSPARSE/releases?per_page=1")" - repoVersion="$(echo "$json" | jq '.[0].name | split(" ") | .[1]' --raw-output)" - rocmVersion="$(echo "$json" | jq '.[0].tag_name | split("-") | .[1]' --raw-output)" - update-source-version hipsparse "$repoVersion" --ignore-same-hash --version-key=repoVersion - update-source-version hipsparse "$rocmVersion" --ignore-same-hash --version-key=rocmVersion + version="$(curl ''${GITHUB_TOKEN:+"-u \":$GITHUB_TOKEN\""} \ + -sL "https://api.github.com/repos/ROCmSoftwarePlatform/hipSPARSE/releases?per_page=1" | jq '.[0].tag_name | split("-") | .[1]' --raw-output)" + update-source-version hipsparse "$version" --ignore-same-hash ''; meta = with lib; { @@ -129,6 +125,6 @@ stdenv.mkDerivation (finalAttrs: { homepage = "https://github.com/ROCmSoftwarePlatform/hipSPARSE"; license = with licenses; [ mit ]; maintainers = teams.rocm.members; - broken = finalAttrs.rocmVersion != hip.version; + broken = finalAttrs.version != hip.version; }; }) diff --git a/pkgs/development/libraries/miopen/default.nix b/pkgs/development/libraries/miopen/default.nix index ee3b4814dc22..9add23f02a11 100644 --- a/pkgs/development/libraries/miopen/default.nix +++ b/pkgs/development/libraries/miopen/default.nix @@ -57,11 +57,7 @@ let }; in stdenv.mkDerivation (finalAttrs: { pname = "miopen"; - # We have to manually specify the repoVersion for now - # Find the github release or `-- MIOpen_VERSION= X.X.X` in the build log - repoVersion = "2.18.0"; - rocmVersion = "5.3.3"; - version = "${finalAttrs.repoVersion}-${finalAttrs.rocmVersion}"; + version = "5.3.3"; outputs = [ "out" @@ -74,7 +70,7 @@ in stdenv.mkDerivation (finalAttrs: { src = fetchFromGitHub { owner = "ROCmSoftwarePlatform"; repo = "MIOpen"; - rev = "rocm-${finalAttrs.rocmVersion}"; + rev = "rocm-${finalAttrs.version}"; hash = "sha256-5/JitdGJ0afzK4pGOOywRLsB3/Thc6/71sRkKIxf2Lg="; }; @@ -184,8 +180,9 @@ in stdenv.mkDerivation (finalAttrs: { passthru.updateScript = writeScript "update.sh" '' #!/usr/bin/env nix-shell #!nix-shell -i bash -p curl jq common-updater-scripts - rocmVersion="$(curl ''${GITHUB_TOKEN:+"-u \":$GITHUB_TOKEN\""} -sL "https://api.github.com/repos/ROCmSoftwarePlatform/MIOpen/releases?per_page=1" | jq '.[0].tag_name | split("-") | .[1]' --raw-output)" - update-source-version miopen "$rocmVersion" --ignore-same-hash --version-key=rocmVersion + version="$(curl ''${GITHUB_TOKEN:+"-u \":$GITHUB_TOKEN\""} \ + -sL "https://api.github.com/repos/ROCmSoftwarePlatform/MIOpen/releases?per_page=1" | jq '.[0].tag_name | split("-") | .[1]' --raw-output)" + update-source-version miopen "$version" --ignore-same-hash ''; meta = with lib; { @@ -193,7 +190,7 @@ in stdenv.mkDerivation (finalAttrs: { homepage = "https://github.com/ROCmSoftwarePlatform/MIOpen"; license = with licenses; [ mit ]; maintainers = teams.rocm.members; - broken = finalAttrs.rocmVersion != hip.version; + broken = finalAttrs.version != hip.version; # MIOpen will produce a very large output due to KDBs fetched # Also possibly in the future because of KDB generation hydraPlatforms = [ ]; diff --git a/pkgs/development/libraries/miopengemm/default.nix b/pkgs/development/libraries/miopengemm/default.nix index 9c944f43a75d..2246f9cde6a7 100644 --- a/pkgs/development/libraries/miopengemm/default.nix +++ b/pkgs/development/libraries/miopengemm/default.nix @@ -32,8 +32,7 @@ let }; in stdenv.mkDerivation (finalAttrs: { pname = "miopengemm"; - rocmVersion = "5.3.3"; - version = finalAttrs.rocmVersion; + version = "5.3.3"; outputs = [ "out" @@ -48,7 +47,7 @@ in stdenv.mkDerivation (finalAttrs: { src = fetchFromGitHub { owner = "ROCmSoftwarePlatform"; repo = "MIOpenGEMM"; - rev = "rocm-${finalAttrs.rocmVersion}"; + rev = "rocm-${finalAttrs.version}"; hash = "sha256-AiRzOMYRA/0nbQomyq4oOEwNZdkPYWRA2W6QFlctvFc="; }; @@ -114,8 +113,9 @@ in stdenv.mkDerivation (finalAttrs: { passthru.updateScript = writeScript "update.sh" '' #!/usr/bin/env nix-shell #!nix-shell -i bash -p curl jq common-updater-scripts - rocmVersion="$(curl ''${GITHUB_TOKEN:+"-u \":$GITHUB_TOKEN\""} -sL "https://api.github.com/repos/ROCmSoftwarePlatform/MIOpenGEMM/releases?per_page=1" | jq '.[0].tag_name | split("-") | .[1]' --raw-output)" - update-source-version miopengemm "$rocmVersion" --ignore-same-hash --version-key=rocmVersion + version="$(curl ''${GITHUB_TOKEN:+"-u \":$GITHUB_TOKEN\""} \ + -sL "https://api.github.com/repos/ROCmSoftwarePlatform/MIOpenGEMM/releases?per_page=1" | jq '.[0].tag_name | split("-") | .[1]' --raw-output)" + update-source-version miopengemm "$version" --ignore-same-hash ''; meta = with lib; { @@ -123,6 +123,6 @@ in stdenv.mkDerivation (finalAttrs: { homepage = "https://github.com/ROCmSoftwarePlatform/MIOpenGEMM"; license = with licenses; [ mit ]; maintainers = teams.rocm.members; - broken = finalAttrs.rocmVersion != clang.version; + broken = finalAttrs.version != clang.version; }; }) diff --git a/pkgs/development/libraries/rccl/default.nix b/pkgs/development/libraries/rccl/default.nix index ab735e5f06fe..81b2746b261f 100644 --- a/pkgs/development/libraries/rccl/default.nix +++ b/pkgs/development/libraries/rccl/default.nix @@ -16,9 +16,7 @@ stdenv.mkDerivation (finalAttrs: { pname = "rccl"; - repoVersion = "2.12.10"; - rocmVersion = "5.3.3"; - version = "${finalAttrs.repoVersion}-${finalAttrs.rocmVersion}"; + version = "5.3.3"; outputs = [ "out" @@ -29,7 +27,7 @@ stdenv.mkDerivation (finalAttrs: { src = fetchFromGitHub { owner = "ROCmSoftwarePlatform"; repo = "rccl"; - rev = "rocm-${finalAttrs.rocmVersion}"; + rev = "rocm-${finalAttrs.version}"; hash = "sha256-whRXGD8oINDYhFs8+hEWKWoGNqacGlyy7xi8peA8Qsk="; }; @@ -77,11 +75,9 @@ stdenv.mkDerivation (finalAttrs: { passthru.updateScript = writeScript "update.sh" '' #!/usr/bin/env nix-shell #!nix-shell -i bash -p curl jq common-updater-scripts - json="$(curl ''${GITHUB_TOKEN:+"-u \":$GITHUB_TOKEN\""} -sL "https://api.github.com/repos/ROCmSoftwarePlatform/rccl/releases?per_page=1")" - repoVersion="$(echo "$json" | jq '.[0].name | split(" ") | .[1]' --raw-output)" - rocmVersion="$(echo "$json" | jq '.[0].tag_name | split("-") | .[1]' --raw-output)" - update-source-version rccl "$repoVersion" --ignore-same-hash --version-key=repoVersion - update-source-version rccl "$rocmVersion" --ignore-same-hash --version-key=rocmVersion + version="$(curl ''${GITHUB_TOKEN:+"-u \":$GITHUB_TOKEN\""} \ + -sL "https://api.github.com/repos/ROCmSoftwarePlatform/rccl/releases?per_page=1" | jq '.[0].tag_name | split("-") | .[1]' --raw-output)" + update-source-version rccl "$version" --ignore-same-hash ''; meta = with lib; { @@ -89,6 +85,6 @@ stdenv.mkDerivation (finalAttrs: { homepage = "https://github.com/ROCmSoftwarePlatform/rccl"; license = with licenses; [ bsd2 bsd3 ]; maintainers = teams.rocm.members; - broken = finalAttrs.rocmVersion != hip.version; + broken = finalAttrs.version != hip.version; }; }) diff --git a/pkgs/development/libraries/rocblas/default.nix b/pkgs/development/libraries/rocblas/default.nix index 6151ecd8d914..efadcf863a23 100644 --- a/pkgs/development/libraries/rocblas/default.nix +++ b/pkgs/development/libraries/rocblas/default.nix @@ -30,14 +30,12 @@ stdenv.mkDerivation (finalAttrs: { pname = "rocblas"; - repoVersion = "2.45.0"; - rocmVersion = "5.3.3"; - version = "${finalAttrs.repoVersion}-${finalAttrs.rocmVersion}"; + version = "5.3.3"; src = fetchFromGitHub { owner = "ROCmSoftwarePlatform"; repo = "rocBLAS"; - rev = "rocm-${finalAttrs.rocmVersion}"; + rev = "rocm-${finalAttrs.version}"; hash = "sha256-z40WxF+suMeIZihBWJPRWyL20S2FUbeZb5JewmQWOJo="; }; @@ -118,11 +116,9 @@ stdenv.mkDerivation (finalAttrs: { passthru.updateScript = writeScript "update.sh" '' #!/usr/bin/env nix-shell #!nix-shell -i bash -p curl jq common-updater-scripts - json="$(curl ''${GITHUB_TOKEN:+"-u \":$GITHUB_TOKEN\""} -sL "https://api.github.com/repos/ROCmSoftwarePlatform/rocBLAS/releases?per_page=1")" - repoVersion="$(echo "$json" | jq '.[0].name | split(" ") | .[1]' --raw-output)" - rocmVersion="$(echo "$json" | jq '.[0].tag_name | split("-") | .[1]' --raw-output)" - update-source-version rocblas "$repoVersion" --ignore-same-hash --version-key=repoVersion - update-source-version rocblas "$rocmVersion" --ignore-same-hash --version-key=rocmVersion + version="$(curl ''${GITHUB_TOKEN:+"-u \":$GITHUB_TOKEN\""} \ + -sL "https://api.github.com/repos/ROCmSoftwarePlatform/rocBLAS/releases?per_page=1" | jq '.[0].tag_name | split("-") | .[1]' --raw-output)" + update-source-version rocblas "$version" --ignore-same-hash ''; meta = with lib; { @@ -132,6 +128,6 @@ stdenv.mkDerivation (finalAttrs: { maintainers = teams.rocm.members; # Tests and benchmarks are a can of worms that I will tackle in a different PR # It involves completely rewriting the amd-blis derivation - broken = finalAttrs.rocmVersion != hip.version || buildTests || buildBenchmarks; + broken = finalAttrs.version != hip.version || buildTests || buildBenchmarks; }; }) diff --git a/pkgs/development/libraries/rocfft/default.nix b/pkgs/development/libraries/rocfft/default.nix index 3536461469ee..5d9ec9ad1dca 100644 --- a/pkgs/development/libraries/rocfft/default.nix +++ b/pkgs/development/libraries/rocfft/default.nix @@ -21,9 +21,7 @@ stdenv.mkDerivation (finalAttrs: { pname = "rocfft"; - repoVersion = "1.0.18"; - rocmVersion = "5.3.3"; - version = "${finalAttrs.repoVersion}-${finalAttrs.rocmVersion}"; + version = "5.3.3"; outputs = [ "out" @@ -36,7 +34,7 @@ stdenv.mkDerivation (finalAttrs: { src = fetchFromGitHub { owner = "ROCmSoftwarePlatform"; repo = "rocFFT"; - rev = "rocm-${finalAttrs.rocmVersion}"; + rev = "rocm-${finalAttrs.version}"; hash = "sha256-jb2F1fRe+YLloYJ/KtzrptUDhmdBDBtddeW/g55owKM="; }; @@ -103,11 +101,9 @@ stdenv.mkDerivation (finalAttrs: { passthru.updateScript = writeScript "update.sh" '' #!/usr/bin/env nix-shell #!nix-shell -i bash -p curl jq common-updater-scripts - json="$(curl ''${GITHUB_TOKEN:+"-u \":$GITHUB_TOKEN\""} -sL "https://api.github.com/repos/ROCmSoftwarePlatform/rocFFT/releases?per_page=1")" - repoVersion="$(echo "$json" | jq '.[0].name | split(" ") | .[1]' --raw-output)" - rocmVersion="$(echo "$json" | jq '.[0].tag_name | split("-") | .[1]' --raw-output)" - update-source-version rocfft "$repoVersion" --ignore-same-hash --version-key=repoVersion - update-source-version rocfft "$rocmVersion" --ignore-same-hash --version-key=rocmVersion + version="$(curl ''${GITHUB_TOKEN:+"-u \":$GITHUB_TOKEN\""} \ + -sL "https://api.github.com/repos/ROCmSoftwarePlatform/rocFFT/releases?per_page=1" | jq '.[0].tag_name | split("-") | .[1]' --raw-output)" + update-source-version rocfft "$version" --ignore-same-hash ''; meta = with lib; { @@ -115,7 +111,7 @@ stdenv.mkDerivation (finalAttrs: { homepage = "https://github.com/ROCmSoftwarePlatform/rocFFT"; license = with licenses; [ mit ]; maintainers = teams.rocm.members; - broken = finalAttrs.rocmVersion != hip.version; + broken = finalAttrs.version != hip.version; hydraPlatforms = [ ]; # rocFFT produces an extremely large output }; }) diff --git a/pkgs/development/libraries/rocmlir/default.nix b/pkgs/development/libraries/rocmlir/default.nix index 6dbf70551b4d..4f592eddecef 100644 --- a/pkgs/development/libraries/rocmlir/default.nix +++ b/pkgs/development/libraries/rocmlir/default.nix @@ -9,13 +9,12 @@ stdenv.mkDerivation (finalAttrs: { pname = "rocmlir"; - rocmVersion = "5.3.3"; - version = finalAttrs.rocmVersion; + version = "5.3.3"; src = fetchFromGitHub { owner = "ROCmSoftwarePlatform"; repo = "rocMLIR"; - rev = "rocm-${finalAttrs.rocmVersion}"; + rev = "rocm-${finalAttrs.version}"; hash = "sha256-s/5gAH5vh2tgATZemPP66juQFDg8BR2sipzX2Q6pOOQ="; }; @@ -35,8 +34,9 @@ stdenv.mkDerivation (finalAttrs: { passthru.updateScript = writeScript "update.sh" '' #!/usr/bin/env nix-shell #!nix-shell -i bash -p curl jq common-updater-scripts - rocmVersion="$(curl ''${GITHUB_TOKEN:+"-u \":$GITHUB_TOKEN\""} -sL "https://api.github.com/repos/ROCmSoftwarePlatform/rocMLIR/tags?per_page=2" | jq '.[1].name | split("-") | .[1]' --raw-output)" - update-source-version rocmlir "$rocmVersion" --ignore-same-hash --version-key=rocmVersion + version="$(curl ''${GITHUB_TOKEN:+"-u \":$GITHUB_TOKEN\""} \ + -sL "https://api.github.com/repos/ROCmSoftwarePlatform/rocMLIR/tags?per_page=2" | jq '.[1].name | split("-") | .[1]' --raw-output)" + update-source-version rocmlir "$version" --ignore-same-hash ''; meta = with lib; { @@ -44,6 +44,6 @@ stdenv.mkDerivation (finalAttrs: { homepage = "https://github.com/ROCmSoftwarePlatform/rocMLIR"; license = with licenses; [ asl20 ]; maintainers = teams.rocm.members; - broken = finalAttrs.rocmVersion != hip.version; + broken = finalAttrs.version != hip.version; }; }) diff --git a/pkgs/development/libraries/rocprim/default.nix b/pkgs/development/libraries/rocprim/default.nix index 8343b95a02d5..33c84822ef52 100644 --- a/pkgs/development/libraries/rocprim/default.nix +++ b/pkgs/development/libraries/rocprim/default.nix @@ -16,9 +16,7 @@ stdenv.mkDerivation (finalAttrs: { pname = "rocprim"; - repoVersion = "2.11.1"; - rocmVersion = "5.3.3"; - version = "${finalAttrs.repoVersion}-${finalAttrs.rocmVersion}"; + version = "5.3.3"; outputs = [ "out" @@ -31,7 +29,7 @@ stdenv.mkDerivation (finalAttrs: { src = fetchFromGitHub { owner = "ROCmSoftwarePlatform"; repo = "rocPRIM"; - rev = "rocm-${finalAttrs.rocmVersion}"; + rev = "rocm-${finalAttrs.version}"; hash = "sha256-jfTuGEPyssARpdo0ZnfVJt0MBkoHnmBtf6Zg4xXNJ1U="; }; @@ -77,11 +75,9 @@ stdenv.mkDerivation (finalAttrs: { passthru.updateScript = writeScript "update.sh" '' #!/usr/bin/env nix-shell #!nix-shell -i bash -p curl jq common-updater-scripts - json="$(curl ''${GITHUB_TOKEN:+"-u \":$GITHUB_TOKEN\""} -sL "https://api.github.com/repos/ROCmSoftwarePlatform/rocPRIM/releases?per_page=1")" - repoVersion="$(echo "$json" | jq '.[0].name | split(" ") | .[1]' --raw-output)" - rocmVersion="$(echo "$json" | jq '.[0].tag_name | split("-") | .[1]' --raw-output)" - update-source-version rocprim "$repoVersion" --ignore-same-hash --version-key=repoVersion - update-source-version rocprim "$rocmVersion" --ignore-same-hash --version-key=rocmVersion + version="$(curl ''${GITHUB_TOKEN:+"-u \":$GITHUB_TOKEN\""} \ + -sL "https://api.github.com/repos/ROCmSoftwarePlatform/rocPRIM/releases?per_page=1" | jq '.[0].tag_name | split("-") | .[1]' --raw-output)" + update-source-version rocprim "$version" --ignore-same-hash ''; meta = with lib; { @@ -89,6 +85,6 @@ stdenv.mkDerivation (finalAttrs: { homepage = "https://github.com/ROCmSoftwarePlatform/rocPRIM"; license = with licenses; [ mit ]; maintainers = teams.rocm.members; - broken = finalAttrs.rocmVersion != hip.version; + broken = finalAttrs.version != hip.version; }; }) diff --git a/pkgs/development/libraries/rocrand/default.nix b/pkgs/development/libraries/rocrand/default.nix index 3af874b3806a..4bb2cf984c70 100644 --- a/pkgs/development/libraries/rocrand/default.nix +++ b/pkgs/development/libraries/rocrand/default.nix @@ -16,9 +16,7 @@ stdenv.mkDerivation (finalAttrs: { pname = "rocrand"; - repoVersion = "2.10.15"; - rocmVersion = "5.3.3"; - version = "${finalAttrs.repoVersion}-${finalAttrs.rocmVersion}"; + version = "5.3.3"; outputs = [ "out" @@ -31,7 +29,7 @@ stdenv.mkDerivation (finalAttrs: { src = fetchFromGitHub { owner = "ROCmSoftwarePlatform"; repo = "rocRAND"; - rev = "rocm-${finalAttrs.rocmVersion}"; + rev = "rocm-${finalAttrs.version}"; hash = "sha256-awQLqPmhVxegrqqSoC8fiCQJ33bPKZlljSAXnHVcIZo="; fetchSubmodules = true; # For inline hipRAND }; @@ -80,11 +78,9 @@ stdenv.mkDerivation (finalAttrs: { passthru.updateScript = writeScript "update.sh" '' #!/usr/bin/env nix-shell #!nix-shell -i bash -p curl jq common-updater-scripts - json="$(curl ''${GITHUB_TOKEN:+"-u \":$GITHUB_TOKEN\""} -sL "https://api.github.com/repos/ROCmSoftwarePlatform/rocRAND/releases?per_page=1")" - repoVersion="$(echo "$json" | jq '.[0].name | split(" ") | .[1]' --raw-output)" - rocmVersion="$(echo "$json" | jq '.[0].tag_name | split("-") | .[1]' --raw-output)" - update-source-version rocrand "$repoVersion" --ignore-same-hash --version-key=repoVersion - update-source-version rocrand "$rocmVersion" --ignore-same-hash --version-key=rocmVersion + version="$(curl ''${GITHUB_TOKEN:+"-u \":$GITHUB_TOKEN\""} \ + -sL "https://api.github.com/repos/ROCmSoftwarePlatform/rocRAND/releases?per_page=1" | jq '.[0].tag_name | split("-") | .[1]' --raw-output)" + update-source-version rocrand "$version" --ignore-same-hash ''; meta = with lib; { @@ -92,6 +88,6 @@ stdenv.mkDerivation (finalAttrs: { homepage = "https://github.com/ROCmSoftwarePlatform/rocRAND"; license = with licenses; [ mit ]; maintainers = teams.rocm.members; - broken = finalAttrs.rocmVersion != hip.version; + broken = finalAttrs.version != hip.version; }; }) diff --git a/pkgs/development/libraries/rocsparse/default.nix b/pkgs/development/libraries/rocsparse/default.nix index 8d6d1322d3be..0d2e2ae093e0 100644 --- a/pkgs/development/libraries/rocsparse/default.nix +++ b/pkgs/development/libraries/rocsparse/default.nix @@ -21,9 +21,7 @@ stdenv.mkDerivation (finalAttrs: { pname = "rocsparse"; - repoVersion = "2.3.2"; - rocmVersion = "5.3.3"; - version = "${finalAttrs.repoVersion}-${finalAttrs.rocmVersion}"; + version = "5.3.3"; outputs = [ "out" @@ -36,7 +34,7 @@ stdenv.mkDerivation (finalAttrs: { src = fetchFromGitHub { owner = "ROCmSoftwarePlatform"; repo = "rocSPARSE"; - rev = "rocm-${finalAttrs.rocmVersion}"; + rev = "rocm-${finalAttrs.version}"; hash = "sha256-1069oBrIpZ4M9CAkzoQ9a5j3WlCXErirTbgTUZuT6b0="; }; @@ -139,11 +137,9 @@ stdenv.mkDerivation (finalAttrs: { updateScript = writeScript "update.sh" '' #!/usr/bin/env nix-shell #!nix-shell -i bash -p curl jq common-updater-scripts - json="$(curl ''${GITHUB_TOKEN:+"-u \":$GITHUB_TOKEN\""} -sL "https://api.github.com/repos/ROCmSoftwarePlatform/rocSPARSE/releases?per_page=1")" - repoVersion="$(echo "$json" | jq '.[0].name | split(" ") | .[1]' --raw-output)" - rocmVersion="$(echo "$json" | jq '.[0].tag_name | split("-") | .[1]' --raw-output)" - update-source-version rocsparse "$repoVersion" --ignore-same-hash --version-key=repoVersion - update-source-version rocsparse "$rocmVersion" --ignore-same-hash --version-key=rocmVersion + version="$(curl ''${GITHUB_TOKEN:+"-u \":$GITHUB_TOKEN\""} \ + -sL "https://api.github.com/repos/ROCmSoftwarePlatform/rocSPARSE/releases?per_page=1" | jq '.[0].tag_name | split("-") | .[1]' --raw-output)" + update-source-version rocsparse "$version" --ignore-same-hash ''; }; @@ -152,6 +148,6 @@ stdenv.mkDerivation (finalAttrs: { homepage = "https://github.com/ROCmSoftwarePlatform/rocSPARSE"; license = with licenses; [ mit ]; maintainers = teams.rocm.members; - broken = finalAttrs.rocmVersion != hip.version; + broken = finalAttrs.version != hip.version; }; }) diff --git a/pkgs/development/libraries/rocthrust/default.nix b/pkgs/development/libraries/rocthrust/default.nix index b5865fc8bc1c..8c3e8921bd44 100644 --- a/pkgs/development/libraries/rocthrust/default.nix +++ b/pkgs/development/libraries/rocthrust/default.nix @@ -16,9 +16,7 @@ stdenv.mkDerivation (finalAttrs: { pname = "rocthrust"; - repoVersion = "2.16.0"; - rocmVersion = "5.3.3"; - version = "${finalAttrs.repoVersion}-${finalAttrs.rocmVersion}"; + version = "5.3.3"; # Comment out these outputs until tests/benchmarks are fixed (upstream?) # outputs = [ @@ -32,7 +30,7 @@ stdenv.mkDerivation (finalAttrs: { src = fetchFromGitHub { owner = "ROCmSoftwarePlatform"; repo = "rocThrust"; - rev = "rocm-${finalAttrs.rocmVersion}"; + rev = "rocm-${finalAttrs.version}"; hash = "sha256-WODOeWWL0AOYu0djwDlVZuiJDxcchsAT7BFG9JKYScw="; }; @@ -79,11 +77,9 @@ stdenv.mkDerivation (finalAttrs: { passthru.updateScript = writeScript "update.sh" '' #!/usr/bin/env nix-shell #!nix-shell -i bash -p curl jq common-updater-scripts - json="$(curl ''${GITHUB_TOKEN:+"-u \":$GITHUB_TOKEN\""} -sL "https://api.github.com/repos/ROCmSoftwarePlatform/rocThrust/releases?per_page=1")" - repoVersion="$(echo "$json" | jq '.[0].name | split(" ") | .[1]' --raw-output)" - rocmVersion="$(echo "$json" | jq '.[0].tag_name | split("-") | .[1]' --raw-output)" - update-source-version rocthrust "$repoVersion" --ignore-same-hash --version-key=repoVersion - update-source-version rocthrust "$rocmVersion" --ignore-same-hash --version-key=rocmVersion + version="$(curl ''${GITHUB_TOKEN:+"-u \":$GITHUB_TOKEN\""} \ + -sL "https://api.github.com/repos/ROCmSoftwarePlatform/rocThrust/releases?per_page=1" | jq '.[0].tag_name | split("-") | .[1]' --raw-output)" + update-source-version rocthrust "$version" --ignore-same-hash ''; meta = with lib; { @@ -93,6 +89,6 @@ stdenv.mkDerivation (finalAttrs: { maintainers = teams.rocm.members; # Tests/Benchmarks don't seem to work, thousands of errors compiling with no clear fix # Is this an upstream issue? We don't seem to be missing dependencies - broken = finalAttrs.rocmVersion != hip.version || buildTests || buildBenchmarks; + broken = finalAttrs.version != hip.version || buildTests || buildBenchmarks; }; }) diff --git a/pkgs/development/libraries/rocwmma/default.nix b/pkgs/development/libraries/rocwmma/default.nix index 49746f83cd83..b2969237e1d4 100644 --- a/pkgs/development/libraries/rocwmma/default.nix +++ b/pkgs/development/libraries/rocwmma/default.nix @@ -34,9 +34,7 @@ let }; in stdenv.mkDerivation (finalAttrs: { pname = "rocwmma"; - repoVersion = "0.8"; - rocmVersion = "5.3.3"; - version = "${finalAttrs.repoVersion}-${finalAttrs.rocmVersion}"; + version = "5.3.3"; outputs = [ "out" @@ -51,7 +49,7 @@ in stdenv.mkDerivation (finalAttrs: { src = fetchFromGitHub { owner = "ROCmSoftwarePlatform"; repo = "rocWMMA"; - rev = "rocm-${finalAttrs.rocmVersion}"; + rev = "rocm-${finalAttrs.version}"; hash = "sha256-wU3R1XGTy7uFbceUyE0wy+XayicuyJIVfd1ih6pbTN0="; }; @@ -126,11 +124,9 @@ in stdenv.mkDerivation (finalAttrs: { passthru.updateScript = writeScript "update.sh" '' #!/usr/bin/env nix-shell #!nix-shell -i bash -p curl jq common-updater-scripts - json="$(curl ''${GITHUB_TOKEN:+"-u \":$GITHUB_TOKEN\""} -sL "https://api.github.com/repos/ROCmSoftwarePlatform/rocWMMA/releases?per_page=1")" - repoVersion="$(echo "$json" | jq '.[0].name | split(" ") | .[1]' --raw-output)" - rocmVersion="$(echo "$json" | jq '.[0].tag_name | split("-") | .[1]' --raw-output)" - update-source-version rocwmma "$repoVersion" --ignore-same-hash --version-key=repoVersion - update-source-version rocwmma "$rocmVersion" --ignore-same-hash --version-key=rocmVersion + version="$(curl ''${GITHUB_TOKEN:+"-u \":$GITHUB_TOKEN\""} \ + -sL "https://api.github.com/repos/ROCmSoftwarePlatform/rocWMMA/releases?per_page=1" | jq '.[0].tag_name | split("-") | .[1]' --raw-output)" + update-source-version rocwmma "$version" --ignore-same-hash ''; meta = with lib; { @@ -140,6 +136,6 @@ in stdenv.mkDerivation (finalAttrs: { maintainers = teams.rocm.members; # Building tests isn't working for now # undefined reference to symbol '_ZTIN7testing4TestE' - broken = finalAttrs.rocmVersion != hip.version || buildTests; + broken = finalAttrs.version != hip.version || buildTests; }; }) diff --git a/pkgs/development/libraries/tensile/default.nix b/pkgs/development/libraries/tensile/default.nix index c3ee1e6ea768..4c9cb80b80e9 100644 --- a/pkgs/development/libraries/tensile/default.nix +++ b/pkgs/development/libraries/tensile/default.nix @@ -10,14 +10,12 @@ buildPythonPackage rec { pname = "tensile"; - repoVersion = "4.34.0"; - rocmVersion = "5.3.3"; - version = "${repoVersion}-${rocmVersion}"; + version = "5.3.3"; src = fetchFromGitHub { owner = "ROCmSoftwarePlatform"; repo = "Tensile"; - rev = "rocm-${rocmVersion}"; + rev = "rocm-${version}"; hash = "sha256-6A7REYdIw/ZmjrJh7B+wCXZMleh4bf04TFpRItPtctA="; }; @@ -30,11 +28,9 @@ buildPythonPackage rec { passthru.updateScript = writeScript "update.sh" '' #!/usr/bin/env nix-shell #!nix-shell -i bash -p curl jq common-updater-scripts - json="$(curl ''${GITHUB_TOKEN:+"-u \":$GITHUB_TOKEN\""} -sL "https://api.github.com/repos/ROCmSoftwarePlatform/Tensile/releases?per_page=1")" - repoVersion="$(echo "$json" | jq '.[0].name | split(" ") | .[1]' --raw-output)" - rocmVersion="$(echo "$json" | jq '.[0].tag_name | split("-") | .[1]' --raw-output)" - update-source-version tensile "$repoVersion" --ignore-same-hash --version-key=repoVersion - update-source-version tensile "$rocmVersion" --ignore-same-hash --version-key=rocmVersion + version="$(curl ''${GITHUB_TOKEN:+"-u \":$GITHUB_TOKEN\""} \ + -sL "https://api.github.com/repos/ROCmSoftwarePlatform/Tensile/releases?per_page=1" | jq '.[0].tag_name | split("-") | .[1]' --raw-output)" + update-source-version tensile "$version" --ignore-same-hash ''; meta = with lib; {