From 3c84ae406d80ba01f96a6da27de954b61f0e735b Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Domen=20Ko=C5=BEar?= Date: Sun, 28 Feb 2016 08:49:55 +0000 Subject: [PATCH] PULL_REQUEST_TEMPLATE.md: clarify a few things --- .github/PULL_REQUEST_TEMPLATE.md | 18 ++++++++++-------- 1 file changed, 10 insertions(+), 8 deletions(-) diff --git a/.github/PULL_REQUEST_TEMPLATE.md b/.github/PULL_REQUEST_TEMPLATE.md index 787524c75758..64904c2908ba 100644 --- a/.github/PULL_REQUEST_TEMPLATE.md +++ b/.github/PULL_REQUEST_TEMPLATE.md @@ -1,15 +1,17 @@ ###### Things done: -- [ ] Tested via `nix.useChroot`. -- [ ] Built on platform(s): . -- [ ] Tested compilation of all pkgs that depend on this change. -- [ ] Tested execution of binary products. +- [ ] Tested using sandboxing (`nix-build --option build-use-chroot true` or [nix.useChroot](http://nixos.org/nixos/manual/options.html#opt-nix.useChroot) on NixOS) +- [ ] Built on platform(s): NixOS + OSX + Linux +- [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nox --run "nox-review wip"` +- [ ] Tested execution of all binary files (usually in `./result/bin/`) - [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md). -###### Extra -Fixes # . +###### More + +Fixes issue # + +cc @ -cc @ . --- -_Please note, that points are not mandatory._ +_Please note, that points are not mandatory, but ._