cafkafk/nixpkgs
cafkafk/nixpkgs
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions 2

nixos/tests/kubo: use subtests instead of comments

Browse source 
Specify the intent of parts of the tests by using `with subtest("...")` instead of a comment for more clarity.
This commit is contained in:
Luflosi 2023-04-14 02:46:22 +02:00
parent bf97703f0e
commit 409df93c01
No known key found for this signature in database
GPG key ID: 4E41E29EDCC345D0
1 changed files with 29 additions and 29 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

10
nixos/tests/kubo.nix
View file

@ -25,7 +25,7 @@
testScript = ''
start_all()
# IPv4 socket activation
with subtest("IPv4 socket activation"):
machine.succeed("ipfs --api /ip4/127.0.0.1/tcp/2324 id")
ipfs_hash = machine.succeed(
"echo fnord | ipfs --api /ip4/127.0.0.1/tcp/2324 add --quieter"
@ -34,7 +34,7 @@
machine.stop_job("ipfs")
# Unix domain socket activation
with subtest("Unix domain socket activation"):
ipfs_hash = machine.succeed(
"echo fnord2 | ipfs --api /unix/run/ipfs.sock add --quieter"
)
@ -42,11 +42,11 @@
f"ipfs --api /unix/run/ipfs.sock cat /ipfs/{ipfs_hash.strip()} | grep fnord2"
)
# Test if setting dataDir works properly with the hardened systemd unit
with subtest("Setting dataDir works properly with the hardened systemd unit"):
machine.succeed("test -e /mnt/ipfs/config")
machine.succeed("test ! -e /var/lib/ipfs/")
# Test FUSE mountpoint
with subtest("FUSE mountpoint"):
# The FUSE mount functionality is broken as of v0.13.0 and v0.17.0.
# See https://github.com/ipfs/kubo/issues/9044.
# Workaround: using CID Version 1 avoids that.
@ -56,8 +56,8 @@
fuse.succeed(f"cat /ipfs/{ipfs_hash} | grep fnord3")
with subtest("Unmounting of /ipns and /ipfs"):
# Force Kubo to crash and wait for it to restart
# Tests the unmounting of /ipns and /ipfs
fuse.systemctl("kill --signal=SIGKILL ipfs.service")
fuse.wait_for_unit("ipfs.service", timeout = 30)