diff --git a/nixos/tests/nixops/default.nix b/nixos/tests/nixops/default.nix index bd00e6143639..b8f747b2a19f 100644 --- a/nixos/tests/nixops/default.nix +++ b/nixos/tests/nixops/default.nix @@ -14,11 +14,12 @@ let # inherit testsForPackage; }; - testsForPackage = lib.makeOverridable (args: lib.recurseIntoAttrs { + testsForPackage = args: lib.recurseIntoAttrs { legacyNetwork = testLegacyNetwork args; - }); + passthru.override = args': testsForPackage (args // args'); + }; - testLegacyNetwork = { nixopsPkg }: pkgs.nixosTest ({ + testLegacyNetwork = { nixopsPkg, ... }: pkgs.nixosTest ({ name = "nixops-legacy-network"; nodes = { deployer = { config, lib, nodes, pkgs, ... }: { @@ -52,7 +53,7 @@ let chmod 0400 ~/.ssh/id_ed25519 ''; serverNetworkJSON = pkgs.writeText "server-network.json" - (builtins.toJSON nodes.server.config.system.build.networkConfig); + (builtins.toJSON nodes.server.system.build.networkConfig); in '' import shlex diff --git a/pkgs/applications/networking/cluster/nixops/default.nix b/pkgs/applications/networking/cluster/nixops/default.nix index 012625a2b051..de79e9759bc0 100644 --- a/pkgs/applications/networking/cluster/nixops/default.nix +++ b/pkgs/applications/networking/cluster/nixops/default.nix @@ -92,7 +92,7 @@ let } ).python; - pkg = interpreter.pkgs.nixops.withPlugins(ps: [ + pkg = (interpreter.pkgs.nixops.withPlugins(ps: [ ps.nixops-aws ps.nixops-digitalocean ps.nixops-encrypted-links @@ -102,11 +102,10 @@ let ps.nixopsvbox ps.nixops-virtd ps.nixops-hetznercloud - ]) // rec { - # Workaround for https://github.com/NixOS/nixpkgs/issues/119407 - # TODO after #1199407: Use .overrideAttrs(pkg: old: { passthru.tests = .....; }) - tests = nixosTests.nixops.unstable.override { nixopsPkg = pkg; }; - # Not strictly necessary, but probably expected somewhere; part of the workaround: - passthru.tests = tests; - }; + ])).overrideAttrs (finalAttrs: prevAttrs: { + passthru = prevAttrs.passthru or {} // { + tests = prevAttrs.passthru.tests or {} // + nixosTests.nixops.unstable.passthru.override { nixopsPkg = pkg; }; + }; + }); in pkg