cafkafk/nixpkgs
cafkafk/nixpkgs
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions 2

Merge pull request #253621 from tweag/minor-contrib-docs-improvements

Browse source 
Minor contrib docs improvements
This commit is contained in:
Silvan Mosberger 2023-09-07 05:21:59 +02:00 committed by GitHub
commit 5433e5b1e7
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 11 additions and 11 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
.github/workflows/backport.yml vendored
View file

@ -31,5 +31,5 @@ jobs:
pull_description: |- pull_description: |-
Bot-based backport to `${target_branch}`, triggered by a label in #${pull_number}. Bot-based backport to `${target_branch}`, triggered by a label in #${pull_number}.
* [ ] Before merging, ensure that this backport complies with the [Criteria for Backporting](https://github.com/NixOS/nixpkgs/blob/master/CONTRIBUTING.md#criteria-for-backporting-changes). * [ ] Before merging, ensure that this backport is [acceptable for the release](https://github.com/NixOS/nixpkgs/blob/master/CONTRIBUTING.md#changes-acceptable-for-releases).
* Even as a non-commiter, if you find that it does not comply, leave a comment. * Even as a non-commiter, if you find that it is not acceptable, leave a comment.

18
CONTRIBUTING.md
View file

@ -483,17 +483,17 @@ The oldest supported release (`YYMM`) can be found using
nix-instantiate --eval -A lib.trivial.oldestSupportedRelease nix-instantiate --eval -A lib.trivial.oldestSupportedRelease
``` ```
The release branches should generally not receive any breaking changes, both for the Nix expressions and derivations. The release branches should generally only receive backwards-compatible changes, both for the Nix expressions and derivations.
So these changes are acceptable to backport: Here are some examples of backwards-compatible changes that are okay to backport:
- New packages, modules and functions - ✔️ New packages, modules and functions
- Security fixes - ✔️ Security fixes
- Package version updates - ✔️ Package version updates
- Patch versions with fixes - ✔️ Patch versions with fixes
- Minor versions with new functionality, but no breaking changes - ✔️ Minor versions with new functionality, but no breaking changes
In addition, major package version updates with breaking changes are also acceptable for: In addition, major package version updates with breaking changes are also acceptable for:
- Services that would fail without up-to-date client software, such as `spotify`, `steam`, and `discord` - ✔️ Services that would fail without up-to-date client software, such as `spotify`, `steam`, and `discord`
- Security critical applications, such as `firefox` and `chromium` - ✔️ Security critical applications, such as `firefox` and `chromium`
### Changes causing mass rebuilds ### Changes causing mass rebuilds
[mass-rebuild]: #changes-causing-mass-rebuilds [mass-rebuild]: #changes-causing-mass-rebuilds