cafkafk/nixpkgs
cafkafk/nixpkgs
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions 2

stdenv: make inputDerivation never fixed-output

Browse source 
This fixes using inputDerivation on derivations that are fixed-output.

Previously:

```
nix-repl> drv = runCommand "huh" { outputHash = "sha256-47DEQpj8HBSa+/TImW+5JCeuQeRkm5NMpJWZG3hSuFU="; outputHashAlgo = "sha256"; outputHashType = "flat"; } "touch $out"

nix-repl> drv.inputDerivation
«derivation /nix/store/d8mjs6cmmvsr1fv7psm6imis5pmh9bcs-huh.drv»

nix-repl> :b drv.inputDerivation
error: fixed output derivation 'huh' is not allowed to refer to other store paths.
       You may need to use the 'unsafeDiscardReferences' derivation attribute, see the manual for more details.
```

Fixes: https://github.com/NixOS/nixpkgs/issues/304209
This commit is contained in:
Jade Lovelace 2024-04-15 00:50:38 -07:00
parent a4a608e794
commit 78945a827c
2 changed files with 29 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

8
pkgs/stdenv/generic/make-derivation.nix
View file

@ -574,6 +574,12 @@ let
"The ‘env’ attribute set can only contain derivation, string, boolean or integer attributes. The ‘${n}’ attribute is of type ${builtins.typeOf v}."; v) "The ‘env’ attribute set can only contain derivation, string, boolean or integer attributes. The ‘${n}’ attribute is of type ${builtins.typeOf v}."; v)
env; env;
# Fixed-output derivations may not reference other paths, which means that
# for a fixed-output derivation, the corresponding inputDerivation should
# *not* be fixed-output. To achieve this we simply delete the attributes that
# would make it fixed-output.
deleteFixedOutputRelatedAttrs = lib.flip builtins.removeAttrs [ "outputHashAlgo" "outputHash" "outputHashMode" ];
in in
extendDerivation extendDerivation
@ -584,7 +590,7 @@ extendDerivation
# This allows easy building and distributing of all derivations # This allows easy building and distributing of all derivations
# needed to enter a nix-shell with # needed to enter a nix-shell with
# nix-build shell.nix -A inputDerivation # nix-build shell.nix -A inputDerivation
inputDerivation = derivation (derivationArg // { inputDerivation = derivation (deleteFixedOutputRelatedAttrs derivationArg // {
# Add a name in case the original drv didn't have one # Add a name in case the original drv didn't have one
name = derivationArg.name or "inputDerivation"; name = derivationArg.name or "inputDerivation";
# This always only has one output # This always only has one output

22
pkgs/test/stdenv/default.nix
View file

@ -166,6 +166,28 @@ in
touch $out touch $out
''; '';
test-inputDerivation-fixed-output = let
inherit (stdenv.mkDerivation {
dep1 = derivation { name = "dep1"; builder = "/bin/sh"; args = [ "-c" ": > $out" ]; system = builtins.currentSystem; };
dep2 = derivation { name = "dep2"; builder = "/bin/sh"; args = [ "-c" ": > $out" ]; system = builtins.currentSystem; };
name = "meow";
outputHash = "sha256-47DEQpj8HBSa+/TImW+5JCeuQeRkm5NMpJWZG3hSuFU=";
outputHashMode = "flat";
outputHashAlgo = "sha256";
buildCommand = ''
touch $out
'';
passAsFile = [ "dep2" ];
}) inputDerivation;
in
runCommand "test-inputDerivation" {
exportReferencesGraph = [ "graph" inputDerivation ];
} ''
grep ${inputDerivation.dep1} graph
grep ${inputDerivation.dep2} graph
touch $out
'';
test-prepend-append-to-var = testPrependAndAppendToVar { test-prepend-append-to-var = testPrependAndAppendToVar {
name = "test-prepend-append-to-var"; name = "test-prepend-append-to-var";
stdenv' = bootStdenv; stdenv' = bootStdenv;