From 7ae938330517dc85516b5e2cd0ccbf44b0bfc7cf Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Sandro=20J=C3=A4ckel?= Date: Sun, 10 Apr 2022 03:14:44 +0200 Subject: [PATCH] golint: disable broken tests, normalize version --- pkgs/development/tools/golint/default.nix | 13 +++++++++---- 1 file changed, 9 insertions(+), 4 deletions(-) diff --git a/pkgs/development/tools/golint/default.nix b/pkgs/development/tools/golint/default.nix index aa6ce6c7cda5..4a835067ac81 100644 --- a/pkgs/development/tools/golint/default.nix +++ b/pkgs/development/tools/golint/default.nix @@ -1,22 +1,27 @@ { lib, buildGoModule, fetchgit }: buildGoModule rec { - pname = "lint"; - version = "20201208-${lib.strings.substring 0 7 rev}"; - rev = "83fdc39ff7b56453e3793356bcff3070b9b96445"; + pname = "golint"; + version = "unstable-2020-12-08"; # we must allow references to the original `go` package, as golint uses # compiler go/build package to load the packages it's linting. allowGoReference = true; src = fetchgit { - inherit rev; url = "https://go.googlesource.com/lint"; + rev = "83fdc39ff7b56453e3793356bcff3070b9b96445"; sha256 = "sha256-g4Z9PREOxGoN7n/XhutawsITBznJlbz6StXeDYvOQ1c="; }; vendorSha256 = "sha256-dPadFoymYu2Uw2AXZfbaBfxsN8IWMuK1TrcknHco3Bo="; + # tests no longer work: + # found packages pkg (4.go) and foo (blank-import-lib.go) in /build/lint-6edffad/testdata + # testdata/errorf-custom.go:9:2: cannot find package "." in: + # /build/lint-6edffad/vendor/github.com/pkg/errors + doCheck = false; + meta = with lib; { homepage = "https://golang.org"; description = "Linter for Go source code";