cafkafk/nixpkgs
cafkafk/nixpkgs
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions 2

doc/coding-conventions: Increase passthru test timeout 3s -> 60s

Browse source 
3s is too small a margin for a loaded slow system to start a bloated
program.
This leads to problems when tests are written on decent dev hardware
but later run on build farms of potentially slower hardware,
particularly in the case of non x86.

The chance of needing the timeout is actually very small, so those
rare 57s are a reasonable price to pay for fewer timeouts on build
farms, each of which should be investigated and usually fixed by
increasing the timeout.
This commit is contained in:
Robert Hensing 2021-07-14 19:03:58 +02:00
parent b141a58ff2
commit 840fd0a4f8
2 changed files with 2 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
doc/contributing/coding-conventions.chapter.md
View file

@ -568,7 +568,7 @@ let
inherit (phoronix-test-suite) pname version; inherit (phoronix-test-suite) pname version;
in in
runCommand "${pname}-tests" { meta.timeout = 3; } runCommand "${pname}-tests" { meta.timeout = 60; }
'' ''
# automatic initial setup to prevent interactive questions # automatic initial setup to prevent interactive questions
${phoronix-test-suite}/bin/phoronix-test-suite enterprise-setup >/dev/null ${phoronix-test-suite}/bin/phoronix-test-suite enterprise-setup >/dev/null

2
pkgs/tools/misc/phoronix-test-suite/tests.nix
View file

@ -4,7 +4,7 @@ let
inherit (phoronix-test-suite) pname version; inherit (phoronix-test-suite) pname version;
in in
runCommand "${pname}-tests" { meta.timeout = 3; } runCommand "${pname}-tests" { meta.timeout = 60; }
'' ''
# automatic initial setup to prevent interactive questions # automatic initial setup to prevent interactive questions
${phoronix-test-suite}/bin/phoronix-test-suite enterprise-setup >/dev/null ${phoronix-test-suite}/bin/phoronix-test-suite enterprise-setup >/dev/null