From 34fa9cc4c48735a3b45c879d58a879285e6118d4 Mon Sep 17 00:00:00 2001 From: Sergey Vlasov Date: Sun, 10 Mar 2024 15:20:56 +0300 Subject: [PATCH 1/2] perlPackages.X11XCB: link with xcb-randr and xcb-xkb Some used XCB libraries were missing from `NIX_CFLAGS_LINK`, which resulted in undefined symbols when actually trying to use the module. --- pkgs/top-level/perl-packages.nix | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pkgs/top-level/perl-packages.nix b/pkgs/top-level/perl-packages.nix index c562b88f9c9c..9297156a4020 100644 --- a/pkgs/top-level/perl-packages.nix +++ b/pkgs/top-level/perl-packages.nix @@ -28433,7 +28433,7 @@ with self; { nativeBuildInputs = [ pkgs.pkg-config ]; buildInputs = [ pkgs.xorg.libxcb pkgs.xorg.xcbproto pkgs.xorg.xcbutil pkgs.xorg.xcbutilwm ExtUtilsDepends ExtUtilsPkgConfig TestDeep TestException XSObjectMagic ]; propagatedBuildInputs = [ DataDump MouseXNativeTraits XMLDescent XMLSimple ]; - NIX_CFLAGS_LINK = "-lxcb -lxcb-util -lxcb-xinerama -lxcb-icccm"; + NIX_CFLAGS_LINK = "-lxcb -lxcb-util -lxcb-xinerama -lxcb-icccm -lxcb-randr -lxcb-xkb"; doCheck = false; # requires an X server meta = { description = "Perl bindings for libxcb"; From 9a066bfbed7563b98387798c60c6da6a5a164b6f Mon Sep 17 00:00:00 2001 From: Sergey Vlasov Date: Sun, 10 Mar 2024 15:33:36 +0300 Subject: [PATCH 2/2] perlPackages.X11XCB: move XSObjectMagic to propagatedBuildInputs `XSObjectMagic` is a runtime dependency (`XCB.pm` actually contains `use XS::Object::Magic;`), so it should be in `propagatedBuildInputs`. --- pkgs/top-level/perl-packages.nix | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/pkgs/top-level/perl-packages.nix b/pkgs/top-level/perl-packages.nix index 9297156a4020..718153801014 100644 --- a/pkgs/top-level/perl-packages.nix +++ b/pkgs/top-level/perl-packages.nix @@ -28431,8 +28431,8 @@ with self; { }; env.AUTOMATED_TESTING = false; nativeBuildInputs = [ pkgs.pkg-config ]; - buildInputs = [ pkgs.xorg.libxcb pkgs.xorg.xcbproto pkgs.xorg.xcbutil pkgs.xorg.xcbutilwm ExtUtilsDepends ExtUtilsPkgConfig TestDeep TestException XSObjectMagic ]; - propagatedBuildInputs = [ DataDump MouseXNativeTraits XMLDescent XMLSimple ]; + buildInputs = [ pkgs.xorg.libxcb pkgs.xorg.xcbproto pkgs.xorg.xcbutil pkgs.xorg.xcbutilwm ExtUtilsDepends ExtUtilsPkgConfig TestDeep TestException ]; + propagatedBuildInputs = [ DataDump MouseXNativeTraits XMLDescent XMLSimple XSObjectMagic ]; NIX_CFLAGS_LINK = "-lxcb -lxcb-util -lxcb-xinerama -lxcb-icccm -lxcb-randr -lxcb-xkb"; doCheck = false; # requires an X server meta = {