From 92775fc62fe541d780d89877345e4cb07637132c Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Robert=20Sch=C3=BCtz?= Date: Sat, 11 Jun 2022 04:47:13 +0000 Subject: [PATCH 1/2] rapidjson: run tests --- .../libraries/rapidjson/default.nix | 39 ++++++++++++++++--- 1 file changed, 34 insertions(+), 5 deletions(-) diff --git a/pkgs/development/libraries/rapidjson/default.nix b/pkgs/development/libraries/rapidjson/default.nix index 1211892890ad..49cbc7ab764c 100644 --- a/pkgs/development/libraries/rapidjson/default.nix +++ b/pkgs/development/libraries/rapidjson/default.nix @@ -1,4 +1,11 @@ -{ stdenv, lib, fetchFromGitHub, fetchpatch, pkg-config, cmake }: +{ lib +, stdenv +, fetchFromGitHub +, fetchpatch +, pkg-config +, cmake +, gtest +}: stdenv.mkDerivation rec { pname = "rapidjson"; @@ -16,20 +23,42 @@ stdenv.mkDerivation rec { url = "https://src.fedoraproject.org/rpms/rapidjson/raw/48402da9f19d060ffcd40bf2b2e6987212c58b0c/f/rapidjson-1.1.0-c++20.patch"; sha256 = "1qm62iad1xfsixv1li7qy475xc7gc04hmi2q21qdk6l69gk7mf82"; }) + (fetchpatch { + url = "https://git.alpinelinux.org/aports/plain/community/rapidjson/do-not-include-gtest-src-dir.patch"; + hash = "sha256-BjSZEwfCXA/9V+kxQ/2JPWbc26jQn35CfN8+8NW24s4="; + }) ]; + postPatch = '' + find -name CMakeLists.txt | xargs \ + sed -i -e "s/-Werror//g" -e "s/-march=native//g" + ''; + nativeBuildInputs = [ pkg-config cmake ]; - preConfigure = '' - substituteInPlace CMakeLists.txt --replace "-Werror" "" - substituteInPlace example/CMakeLists.txt --replace "-Werror" "" + cmakeFlags = [ + "-DGTEST_SOURCE_DIR=${gtest.dev}/include" + ]; + + checkInputs = [ + gtest + ]; + + checkPhase = '' + runHook preCheck + + ctest -E '.*valgrind.*' + + runHook postCheck ''; + doCheck = true; + meta = with lib; { description = "Fast JSON parser/generator for C++ with both SAX/DOM style API"; homepage = "http://rapidjson.org/"; license = licenses.mit; platforms = platforms.unix; - maintainers = with maintainers; [ cstrahan ]; + maintainers = with maintainers; [ cstrahan dotlambda ]; }; } From 11cc18cddd0a1c7aa7c5e008b91696ed8ac5a04e Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Robert=20Sch=C3=BCtz?= Date: Sat, 11 Jun 2022 05:03:47 +0000 Subject: [PATCH 2/2] python310Packages.python-rapidjson: unvendor rapidjson --- .../python-rapidjson/default.nix | 47 ++++++++++++++----- 1 file changed, 34 insertions(+), 13 deletions(-) diff --git a/pkgs/development/python-modules/python-rapidjson/default.nix b/pkgs/development/python-modules/python-rapidjson/default.nix index 35d11e981e4d..a9423a7a58df 100644 --- a/pkgs/development/python-modules/python-rapidjson/default.nix +++ b/pkgs/development/python-modules/python-rapidjson/default.nix @@ -1,37 +1,58 @@ { lib , buildPythonPackage +, fetchFromGitHub +, fetchpatch , fetchPypi , pythonOlder -, pytest +, rapidjson +, pytestCheckHook , pytz , glibcLocales }: -buildPythonPackage rec { +let + rapidjson' = rapidjson.overrideAttrs (old: { + version = "unstable-2022-05-24"; + src = fetchFromGitHub { + owner = "Tencent"; + repo = "rapidjson"; + rev = "232389d4f1012dddec4ef84861face2d2ba85709"; + hash = "sha256-RLvDcInUa8E8DRA4U/oXEE8+TZ0SDXXDU/oWvpfDWjw="; + }; + patches = [ + (fetchpatch { + url = "https://git.alpinelinux.org/aports/plain/community/rapidjson/do-not-include-gtest-src-dir.patch"; + hash = "sha256-BjSZEwfCXA/9V+kxQ/2JPWbc26jQn35CfN8+8NW24s4="; + }) + ]; + }); +in buildPythonPackage rec { version = "1.6"; pname = "python-rapidjson"; - disabled = pythonOlder "3.4"; + disabled = pythonOlder "3.7"; src = fetchPypi { inherit pname version; sha256 = "sha256-GJzxqWv5/NhtADYPFa12qDzgiJuK6NHLD9srKZXlocg="; }; - LC_ALL="en_US.utf-8"; - buildInputs = [ glibcLocales ]; + setupPyBuildFlags = [ + "--rj-include-dir=${lib.getDev rapidjson'}/include" + ]; - # buildInputs = [ ]; - checkInputs = [ pytest pytz ]; - # propagatedBuildInputs = [ ]; + checkInputs = [ + pytestCheckHook + pytz + ]; - checkPhase = '' - pytest tests - ''; + disabledTestPaths = [ + "benchmarks" + ]; meta = with lib; { homepage = "https://github.com/python-rapidjson/python-rapidjson"; - description = "Python wrapper around rapidjson "; + description = "Python wrapper around rapidjson"; license = licenses.mit; - maintainers = [ maintainers.costrouc ]; + maintainers = with maintainers; [ costrouc dotlambda ]; }; }