cafkafk/nixpkgs
cafkafk/nixpkgs
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions 2

vde2: build with --disable-python by default

Browse source 
This package explicitly depends on `python2` which will be EOLed at the
end of the year[1]. This package provides python bindings for `python2`,
however the latest release (also used by other distros) is from 2011[2]
and doesn't support v3. For instance, debian ships `vde2` without
`python2` support since Debian Jessie[3].

KVM and QEMU appear to build fine, also NixOS tests and ISO builds are
still functional.

By running `nix-review` against this change, only `xen` packages failed,
but those were already broken on master[4].

Finally it's also worth mentioning that the closure size of `vde2` drops
from 99.5M to 33.5M without `python2` according to `nix path-info -S -h`.

[1] https://pythonclock.org/
[2] https://github.com/virtualsquare/vde-2/releases/tag/vde-2
    (vde.sourceforge.net redirects to this github page)
[3] https://packages.debian.org/en/jessie/vde2
[4] https://hydra.nixos.org/build/99185451, https://hydra.nixos.org/build/99187262
This commit is contained in:
Maximilian Bosch 2019-08-25 18:06:33 +02:00 committed by Frederik Rietdijk
parent 1296b10c31
commit b4a4d98c52
1 changed files with 4 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
pkgs/tools/networking/vde2/default.nix
View file

@ -1,4 +1,4 @@
{ stdenv, fetchurl, fetchpatch, openssl, libpcap, python2 }:
{ stdenv, fetchurl, fetchpatch, openssl, libpcap, python2, withPython ? false }:
stdenv.mkDerivation rec {
name = "vde2-2.3.2";
@ -15,8 +15,10 @@ stdenv.mkDerivation rec {
}
);
configureFlags = stdenv.lib.optional (!withPython) [ "--disable-python" ];
buildInputs = [ openssl libpcap python2 ];
buildInputs = [ openssl libpcap ]
++ stdenv.lib.optional withPython python2;
hardeningDisable = [ "format" ];