Merge pull request #180858 from azahi/albert

albert: 0.17.2 -> 0.17.3

pkgs/applications/misc/albert/default.nix

@@ -1,45 +1,75 @@
-{ mkDerivation, lib, fetchFromGitHub, makeWrapper, qtbase,
+{ lib
-  qtdeclarative, qtsvg, qtx11extras, muparser, cmake, python3,
+, stdenv
-  qtcharts }:
+, fetchFromGitHub
+, cmake
+, muparser
+, python3
+, qtbase
+, qtcharts
+, qtdeclarative
+, qtgraphicaleffects
+, qtsvg
+, qtx11extras
+, wrapQtAppsHook
+, nix-update-script
+}:
 
-mkDerivation rec {
+stdenv.mkDerivation rec {
   pname = "albert";
-  version = "0.17.2";
+  version = "0.17.3";
 
   src = fetchFromGitHub {
-    owner  = "albertlauncher";
+    owner = "albertlauncher";
-    repo   = "albert";
+    repo = "albert";
-    rev    = "v${version}";
+    rev = "v${version}";
-    sha256 = "0lpp8rqx5b6rwdpcdldfdlw5327harr378wnfbc6rp3ajmlb4p7w";
+    sha256 = "sha256-UIG6yLkIcdf5IszhNPwkBcSfZe4/CyI5shK/QPOmpPE=";
     fetchSubmodules = true;
   };
 
-  nativeBuildInputs = [ cmake makeWrapper ];
+  nativeBuildInputs = [
+    cmake
+    wrapQtAppsHook
+  ];
 
-  buildInputs = [ qtbase qtdeclarative qtsvg qtx11extras muparser python3 qtcharts ];
+  buildInputs = [
-
+    muparser
-  # We don't have virtualbox sdk so disable plugin
+    python3
-  cmakeFlags = [ "-DBUILD_VIRTUALBOX=OFF" "-DCMAKE_INSTALL_LIBDIR=libs" ];
+    qtbase
+    qtcharts
+    qtdeclarative
+    qtgraphicaleffects
+    qtsvg
+    qtx11extras
+  ];
 
   postPatch = ''
-    sed -i "/QStringList dirs = {/a    \"$out/libs\"," \
+    find -type f -name CMakeLists.txt -exec sed -i {} -e '/INSTALL_RPATH/d' \;
-      src/app/main.cpp
+
+    sed -i src/app/main.cpp \
+      -e "/QStringList dirs = {/a    QFileInfo(\"$out/lib\").canonicalFilePath(),"
   '';
 
-  preBuild = ''
+  postFixup = ''
-    mkdir -p "$out/"
+    for i in $out/{bin/.albert-wrapped,lib/albert/plugins/*.so}; do
-    ln -s "$PWD/lib" "$out/lib"
+      patchelf $i --add-rpath $out/lib/albert
+    done
   '';
 
-  postBuild = ''
+  passthru.updateScript = nix-update-script {
-    rm "$out/lib"
+    attrPath = pname;
-  '';
+  };
 
   meta = with lib; {
-    homepage    = "https://albertlauncher.github.io/";
+    description = "A fast and flexible keyboard launcher";
-    description = "Desktop agnostic launcher";
+    longDescription = ''
-    license     = licenses.gpl3Plus;
+      Albert is a desktop agnostic launcher. Its goals are usability and beauty,
+      performance and extensibility. It is written in C++ and based on the Qt
+      framework.
+    '';
+    homepage = "https://albertlauncher.github.io";
+    changelog = "https://github.com/albertlauncher/albert/blob/${src.rev}/CHANGELOG.md";
+    license = licenses.gpl3Plus;
     maintainers = with maintainers; [ ericsagnes synthetica ];
-    platforms   = platforms.linux;
+    platforms = platforms.linux;
   };
 }