From 931964e3009f8ced440076223717acd0a3bc2f42 Mon Sep 17 00:00:00 2001 From: Nydragon Date: Mon, 6 May 2024 13:22:29 +0900 Subject: [PATCH 1/3] lollypop: format file --- pkgs/applications/audio/lollypop/default.nix | 52 +++++++++----------- 1 file changed, 23 insertions(+), 29 deletions(-) diff --git a/pkgs/applications/audio/lollypop/default.nix b/pkgs/applications/audio/lollypop/default.nix index 34dbf0318a71..414d3fa144c8 100644 --- a/pkgs/applications/audio/lollypop/default.nix +++ b/pkgs/applications/audio/lollypop/default.nix @@ -23,7 +23,7 @@ , youtubeSupport ? true }: -python3.pkgs.buildPythonApplication rec { +python3.pkgs.buildPythonApplication rec { pname = "lollypop"; version = "1.4.37"; @@ -48,32 +48,28 @@ python3.pkgs.buildPythonApplication rec { wrapGAppsHook ]; - buildInputs = with gst_all_1; [ - gdk-pixbuf - glib - glib-networking - gst-libav - gst-plugins-bad - gst-plugins-base - gst-plugins-good - gst-plugins-ugly - gstreamer - gtk3 - libhandy - libsoup_3 - pango - totem-pl-parser - ] ++ lib.optional lastFMSupport libsecret; + buildInputs = with gst_all_1; + [ + gdk-pixbuf + glib + glib-networking + gst-libav + gst-plugins-bad + gst-plugins-base + gst-plugins-good + gst-plugins-ugly + gstreamer + gtk3 + libhandy + libsoup_3 + pango + totem-pl-parser + ] ++ lib.optional lastFMSupport libsecret; - propagatedBuildInputs = with python3.pkgs; [ - beautifulsoup4 - pillow - pycairo - pygobject3 - ] - ++ lib.optional lastFMSupport pylast - ++ lib.optional youtubeSupport youtube-dl - ; + propagatedBuildInputs = with python3.pkgs; + [ beautifulsoup4 pillow pycairo pygobject3 ] + ++ lib.optional lastFMSupport pylast + ++ lib.optional youtubeSupport youtube-dl; postPatch = '' chmod +x meson_post_install.py @@ -95,9 +91,7 @@ python3.pkgs.buildPythonApplication rec { makeWrapperArgs+=("''${gappsWrapperArgs[@]}") ''; - passthru = { - updateScript = nix-update-script { }; - }; + passthru = { updateScript = nix-update-script { }; }; meta = with lib; { changelog = "https://gitlab.gnome.org/World/lollypop/tags/${version}"; From ff59531e8319d7c068e54989923e70d8801bef94 Mon Sep 17 00:00:00 2001 From: Nydragon Date: Mon, 6 May 2024 13:24:28 +0900 Subject: [PATCH 2/3] lollypop: 1.4.37 -> 1.4.39 Bump to latest version --- pkgs/applications/audio/lollypop/default.nix | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/pkgs/applications/audio/lollypop/default.nix b/pkgs/applications/audio/lollypop/default.nix index 414d3fa144c8..fb495a997154 100644 --- a/pkgs/applications/audio/lollypop/default.nix +++ b/pkgs/applications/audio/lollypop/default.nix @@ -25,7 +25,7 @@ python3.pkgs.buildPythonApplication rec { pname = "lollypop"; - version = "1.4.37"; + version = "1.4.39"; format = "other"; @@ -35,7 +35,7 @@ python3.pkgs.buildPythonApplication rec { repo = pname; rev = version; fetchSubmodules = true; - sha256 = "sha256-3GPmGNbbSxvLq0t3F9q1x64BwNQCEvFQWLb0bSO9KUY="; + sha256 = "sha256-VPHQwy2+XR9R7toIN5sNFB91ddROlL7Scr8AKLgUzuo="; }; nativeBuildInputs = [ From 93ecf9499319389c332bb7c810cdb086ec6d4ac3 Mon Sep 17 00:00:00 2001 From: Nydragon Date: Mon, 6 May 2024 13:24:59 +0900 Subject: [PATCH 3/3] lollypop: add kid3 to build inputs. Lollypop allows for metadata editing through kid3, which was missing from its derivation. --- pkgs/applications/audio/lollypop/default.nix | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/pkgs/applications/audio/lollypop/default.nix b/pkgs/applications/audio/lollypop/default.nix index fb495a997154..652c4ca2515e 100644 --- a/pkgs/applications/audio/lollypop/default.nix +++ b/pkgs/applications/audio/lollypop/default.nix @@ -21,6 +21,7 @@ , wrapGAppsHook , lastFMSupport ? true , youtubeSupport ? true +, kid3Support ? true }: python3.pkgs.buildPythonApplication rec { @@ -69,7 +70,8 @@ python3.pkgs.buildPythonApplication rec { propagatedBuildInputs = with python3.pkgs; [ beautifulsoup4 pillow pycairo pygobject3 ] ++ lib.optional lastFMSupport pylast - ++ lib.optional youtubeSupport youtube-dl; + ++ lib.optional youtubeSupport youtube-dl + ++ lib.optional kid3Support pkgs.kid3; postPatch = '' chmod +x meson_post_install.py