cafkafk/nixpkgs
cafkafk/nixpkgs
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions 2

_1password: do not strip binary on darwin(OSX) (#88091)

Browse source 
Stripping the binary on OSX causes op(1password) to fail immediately.
Setting dontStrip = true; fixes the issue.
Additionally, adding a very simple installCheck section for testing
purposes.

Co-authored-by: Corban Raun <craun@instructure.com>
This commit is contained in:
Corban Raun 2020-05-25 07:46:14 -06:00 committed by GitHub
parent 28667152aa
commit c640f7efd1
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 8 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

8
pkgs/applications/misc/1password/default.nix
View file

@ -34,8 +34,16 @@ stdenv.mkDerivation rec {
install -D op $out/bin/op
'';
dontStrip = stdenv.isDarwin;
nativeBuildInputs = stdenv.lib.optionals stdenv.isLinux [ autoPatchelfHook ];
doInstallCheck = true;
installCheckPhase = ''
$out/bin/op --version
'';
meta = with stdenv.lib; {
description = "1Password command-line tool";
homepage = "https://support.1password.com/command-line/";