cafkafk/nixpkgs
cafkafk/nixpkgs
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions 2

fish: switch to fetchFromGitHub

Browse source 
The expression claimed there are differences between the release tarball and the tarball github packages from the tag but fetchFromGitHub literally downloads the same tarball.
This commit is contained in:
Jan Tojnar 2019-10-18 16:06:53 +02:00
parent f203d50d09
commit cc997f28d1
No known key found for this signature in database
GPG key ID: 7FAB2A15F7A607A4
1 changed files with 6 additions and 6 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

12
pkgs/shells/fish/default.nix
View file

@ -1,4 +1,4 @@
{ stdenv, fetchurl, coreutils, utillinux,
{ stdenv, fetchFromGitHub, coreutils, utillinux,
which, gnused, gnugrep,
groff, man-db, getent, libiconv, pcre2,
gettext, ncurses, python3,
@ -93,11 +93,11 @@ let
etcConfigAppendix = builtins.toFile "etc-config.appendix.fish" etcConfigAppendixText;
src = fetchurl {
# There are differences between the release tarball and the tarball github packages from the tag
# Hence we cannot use fetchFromGithub
url = "https://github.com/fish-shell/fish-shell/releases/download/${version}/${pname}-${version}.tar.gz";
sha256 = "03j3jl9jzlnhq4p86zj8wqsh5sx45j1d1fvfa80ks1cfdg68qwhl";
src = fetchFromGitHub {
owner = "fish-shell";
repo = "fish-shell";
rev = version;
sha256 = "1qh6dka1ayz352ihcq4529hjgnz255gyrqs3xyif6b2ycvrm4ad5";
};
nativeBuildInputs = [ cmake ];