From 36ca205e44d839306b8ce1ba1c3f217d90d26738 Mon Sep 17 00:00:00 2001 From: Archit Gupta Date: Fri, 30 Jun 2023 13:15:53 -0700 Subject: [PATCH] nixos/gdm: fix plymouth-quit bootup error message If plymouth is not enabled, there is no plymouth-quit service created otherwise, so setting systemd.services.plymouth-quit.wantedBy creates an empty service which logs an error during bootup. The plymouth fix should only be applied if plymouth is actually available to prevent a needless systemd service error on systems with gdm but no plymouth (such as a default gnome setup). --- nixos/modules/services/x11/display-managers/gdm.nix | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/nixos/modules/services/x11/display-managers/gdm.nix b/nixos/modules/services/x11/display-managers/gdm.nix index f8f82bda3fa4..676d08b93e2c 100644 --- a/nixos/modules/services/x11/display-managers/gdm.nix +++ b/nixos/modules/services/x11/display-managers/gdm.nix @@ -207,7 +207,9 @@ in # conflicts display-manager.service, then when nixos-rebuild # switch starts multi-user.target, display-manager.service is # stopped so plymouth-quit.service can be started.) - systemd.services.plymouth-quit.wantedBy = lib.mkForce []; + systemd.services.plymouth-quit = mkIf config.boot.plymouth.enable { + wantedBy = lib.mkForce []; + }; systemd.services.display-manager.serviceConfig = { # Restart = "always"; - already defined in xserver.nix