cafkafk/nixpkgs
cafkafk/nixpkgs
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions 2

handbrake: fix missing audio

Browse source 
We build HandBrake with a newer ffmpeg than upstream expects,
triggering a problem where the audio samplerate defaults to zero
because HandBrake was not explicitly setting it.

This has been fixed in HandBrake upstream, but we must cherry pick
this change in order to produce videos with audio until HandBrake
1.3.0 is released.
This commit is contained in:
Anthony Cowley 2019-10-23 15:33:08 -04:00
parent 1c40ee6fc4
commit d51e366ffe
1 changed files with 8 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

9
pkgs/applications/video/handbrake/default.nix
View file

@ -7,7 +7,7 @@
# be nice to add the native GUI (and/or the GTK GUI) as an option too, but that # be nice to add the native GUI (and/or the GTK GUI) as an option too, but that
# requires invoking the Xcode build system, which is non-trivial for now. # requires invoking the Xcode build system, which is non-trivial for now.
{ stdenv, lib, fetchurl, { stdenv, lib, fetchurl, fetchpatch,
# Main build tools # Main build tools
python2, pkgconfig, autoconf, automake, cmake, nasm, libtool, m4, lzma, python2, pkgconfig, autoconf, automake, cmake, nasm, libtool, m4, lzma,
# Processing, video codecs, containers # Processing, video codecs, containers
@ -81,6 +81,13 @@ stdenv.mkDerivation rec {
# cp: cannot create regular file './internal_defaults.json': File exists # cp: cannot create regular file './internal_defaults.json': File exists
enableParallelBuilding = false; enableParallelBuilding = false;
# The samplerate patch should be removed when HandBrake 1.3.0 is released
patches = [(fetchpatch {
name = "set-ffmpeg-samplerate.patch";
url = "https://patch-diff.githubusercontent.com/raw/HandBrake/HandBrake/pull/2126.patch";
sha256 = "00lds9h27cvyr53qpvv8gbv01hfxdxd8gphxcwbwg8akqrvk9gbf";
})];
preConfigure = '' preConfigure = ''
patchShebangs scripts patchShebangs scripts