Merge pull request #251267 from lilyinstarlight/fix/dotnet-installPath

buildDotnetModule: actually use installPath
This commit is contained in:
Ryan Lahfa 2024-01-12 19:30:12 +01:00 committed by GitHub
commit d74aefe80e
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
3 changed files with 4 additions and 4 deletions

View file

@ -37,7 +37,7 @@
# The path to publish the project to. When unset, the directory "$out/lib/$pname" is used. # The path to publish the project to. When unset, the directory "$out/lib/$pname" is used.
, installPath ? null , installPath ? null
# The binaries that should get installed to `$out/bin`, relative to `$out/lib/$pname/`. These get wrapped accordingly. # The binaries that should get installed to `$out/bin`, relative to `$installPath/`. These get wrapped accordingly.
# Unfortunately, dotnet has no method for doing this automatically. # Unfortunately, dotnet has no method for doing this automatically.
# If unset, all executables in the projects root will get installed. This may cause bloat! # If unset, all executables in the projects root will get installed. This may cause bloat!
, executables ? null , executables ? null

View file

@ -32,7 +32,7 @@ dotnetFixupHook() {
if [ "${executables-}" ]; then if [ "${executables-}" ]; then
for executable in ${executables[@]}; do for executable in ${executables[@]}; do
path="$out/lib/$pname/$executable" path="${installPath-$out/lib/$pname}/$executable"
if test -x "$path"; then if test -x "$path"; then
wrapDotnetProgram "$path" "$out/bin/$(basename "$executable")" wrapDotnetProgram "$path" "$out/bin/$(basename "$executable")"
@ -45,7 +45,7 @@ dotnetFixupHook() {
else else
while IFS= read -d '' executable; do while IFS= read -d '' executable; do
wrapDotnetProgram "$executable" "$out/bin/$(basename "$executable")" \; wrapDotnetProgram "$executable" "$out/bin/$(basename "$executable")" \;
done < <(find "$out/lib/$pname" ! -name "*.dll" -executable -type f -print0) done < <(find "${installPath-$out/lib/$pname}" ! -name "*.dll" -executable -type f -print0)
fi fi
echo "Finished dotnetFixupPhase" echo "Finished dotnetFixupPhase"

View file

@ -30,7 +30,7 @@ dotnetInstallHook() {
env dotnet publish ${project-} \ env dotnet publish ${project-} \
-p:ContinuousIntegrationBuild=true \ -p:ContinuousIntegrationBuild=true \
-p:Deterministic=true \ -p:Deterministic=true \
--output "$out/lib/${pname}" \ --output "${installPath-$out/lib/$pname}" \
--configuration "@buildType@" \ --configuration "@buildType@" \
--no-build \ --no-build \
${runtimeIdFlags[@]} \ ${runtimeIdFlags[@]} \