cafkafk/nixpkgs
cafkafk/nixpkgs
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions 2

buildPythonPackage: document why we always propagate python

Browse source 
python applications should not propagate python in PATH but we do it
nevertheless to avoid rebuilds see https://github.com/NixOS/nixpkgs/issues/170887
for an explanation.
This commit is contained in:
Matthieu Coudron 2022-06-27 11:44:20 +02:00 committed by Frederik Rietdijk
parent 9525331e5a
commit de50d08d73
1 changed files with 6 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

7
pkgs/development/interpreters/python/mk-python-derivation.nix
View file

@ -148,7 +148,12 @@ let
buildInputs = buildInputs ++ pythonPath; buildInputs = buildInputs ++ pythonPath;
propagatedBuildInputs = propagatedBuildInputs ++ [ python ]; propagatedBuildInputs = propagatedBuildInputs ++ [
# we propagate python even for packages transformed with 'toPythonApplication'
# this pollutes the PATH but avoids rebuilds
# see https://github.com/NixOS/nixpkgs/issues/170887 for more context
python
];
inherit strictDeps; inherit strictDeps;