From e8b241cdbad6f7c0af4115c0d733874b02f5c54f Mon Sep 17 00:00:00 2001 From: Michael Weiss Date: Mon, 24 Jan 2022 22:02:17 +0100 Subject: [PATCH] chromiumDev: Fix the configuration phase This fixes: -------------------------------------------------------------------------------- configuring ERROR at //ui/gtk/BUILD.gn:17:1: Assertion failed. assert(use_gio, "GIO is required for building with GTK") ^----- GIO is required for building with GTK See //content/shell/BUILD.gn:308:15: which caused the file to be included. deps += [ "//ui/gtk" ] ^--------- -------------------------------------------------------------------------------- But there's still another build issue(s) left: -------------------------------------------------------------------------------- [25491/48383] ACTION //components/url_formatter/spoof_checks/top_domains:generate_top_domain_list_variables_file(//build/toolchain/linux/unbundle:default)d_tmp/browser_command.mojom-webui.jsab_page_third_party.mojom-webui.js FAILED: gen/components/url_formatter/spoof_checks/top_domains/top500-domains-inc.cc python3 ../../build/gn_run_binary.py make_top_domain_list_variables ../../components/url_formatter/spoof_checks/top_domains/domains.list top500_domains gen/components/url_formatter/spoof_checks/top_domains/top500-domains-inc.cc make_top_domain_list_variables failed with exit code -4 ninja: build stopped: subcommand failed. -------------------------------------------------------------------------------- --- pkgs/applications/networking/browsers/chromium/common.nix | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pkgs/applications/networking/browsers/chromium/common.nix b/pkgs/applications/networking/browsers/chromium/common.nix index d9385ceb0427..74133a9d47e9 100644 --- a/pkgs/applications/networking/browsers/chromium/common.nix +++ b/pkgs/applications/networking/browsers/chromium/common.nix @@ -288,7 +288,7 @@ let google_api_key = "AIzaSyDGi15Zwl11UNe6Y-5XW_upsfyw31qwZPI"; # Optional features: - use_gio = gnomeSupport; + use_gio = gnomeSupport || chromiumVersionAtLeast "99"; use_gnome_keyring = gnomeKeyringSupport; use_cups = cupsSupport;