Bjørn Forsman 581226cfb4 nixos/bcache: /bin/sh -> ${bash}/bin/sh ... Or else `services.udev.packages = [ bcache-tools ]` cannot be used. To not break bcache in the initrd I'm modifying this in stage-1.nix: - --replace /bin/sh ${extraUtils}/bin/sh + --replace ${bash}/bin/sh ${extraUtils}/bin/sh Reasoning behind that change: * If not modifying the /bin/sh pattern in any way, it will also match ${bash}/bin/sh, creating a broken path like /nix/store/HASH-bash/nix/store/HASH-bash/bin/sh in the udev rule file. * The addition of /bin/sh was done in 775f381a9e ("stage-1: add bcache support"). It seems somewhat plausible that no new users have appeared since then and we can take this opportunity to back out of this change without much fear of regressions. If there _are_ regressions, they should be in the form of build time errors, not runtime (boot), due to how the udev rule output is checked for invalid path references. So low risk, IMHO. * An alternative approach could be to copy the /bin/sh substitute rule over to the non-initrd udev rules implementation in NixOS, but I think this way is better: - The rules file comes with a working path out of the box. - We can use more precise pattern matching when modifying the udev rules for the initrd.		2017-06-10 17:10:49 +02:00
..
activation	Add facility to append secrets to the initrd	2017-04-02 16:33:37 -04:00
boot	nixos/bcache: /bin/sh -> ${bash}/bin/sh	2017-06-10 17:10:49 +02:00
etc	Merge remote-tracking branch 'upstream/master' into staging	2016-10-02 10:36:47 +03:00