0dcdf60c38
Previously, even if the check also failed on the base branch, it looked like the PR introduced the failure. We can easily have a better error message for such cases. Meanwhile this also paves the road for something like https://github.com/NixOS/nixpkgs/issues/256788
143 lines
6 KiB
YAML
143 lines
6 KiB
YAML
# Checks pkgs/by-name (see pkgs/by-name/README.md)
|
|
# using the nixpkgs-check-by-name tool (see pkgs/test/nixpkgs-check-by-name)
|
|
name: Check pkgs/by-name
|
|
|
|
# The pre-built tool is fetched from a channel,
|
|
# making it work predictable on all PRs.
|
|
on:
|
|
# Using pull_request_target instead of pull_request avoids having to approve first time contributors
|
|
pull_request_target
|
|
|
|
# The tool doesn't need any permissions, it only outputs success or not based on the checkout
|
|
permissions: {}
|
|
|
|
jobs:
|
|
check:
|
|
# This is x86_64-linux, for which the tool is always prebuilt on the nixos-* channels,
|
|
# as specified in nixos/release-combined.nix
|
|
runs-on: ubuntu-latest
|
|
steps:
|
|
- uses: actions/checkout@v4
|
|
with:
|
|
# pull_request_target checks out the base branch by default
|
|
ref: refs/pull/${{ github.event.pull_request.number }}/merge
|
|
# Fetches the merge commit and its parents
|
|
fetch-depth: 2
|
|
- name: Determining PR git hashes
|
|
run: |
|
|
echo "mergedSha=$(git rev-parse HEAD)" >> "$GITHUB_ENV"
|
|
|
|
# For pull_request_target this is the same as $GITHUB_SHA
|
|
echo "baseSha=$(git rev-parse HEAD^1)" >> "$GITHUB_ENV"
|
|
|
|
echo "headSha=$(git rev-parse HEAD^2)" >> "$GITHUB_ENV"
|
|
- uses: cachix/install-nix-action@v23
|
|
- name: Determining channel to use for dependencies
|
|
run: |
|
|
echo "Determining which channel to use for PR base branch $GITHUB_BASE_REF"
|
|
if [[ "$GITHUB_BASE_REF" =~ ^(release|staging|staging-next)-([0-9][0-9]\.[0-9][0-9])$ ]]; then
|
|
# Use the release channel for all PRs to release-XX.YY, staging-XX.YY and staging-next-XX.YY
|
|
channel=nixos-${BASH_REMATCH[2]}
|
|
echo "PR is for a release branch, using release channel $channel"
|
|
else
|
|
# Use the nixos-unstable channel for all other PRs
|
|
channel=nixos-unstable
|
|
echo "PR is for a non-release branch, using unstable channel $channel"
|
|
fi
|
|
echo "channel=$channel" >> "$GITHUB_ENV"
|
|
- name: Fetching latest version of channel
|
|
run: |
|
|
echo "Fetching latest version of channel $channel"
|
|
# This is probably the easiest way to get Nix to output the path to a downloaded channel!
|
|
nixpkgs=$(nix-instantiate --find-file nixpkgs -I nixpkgs=channel:"$channel")
|
|
# This file only exists in channels
|
|
rev=$(<"$nixpkgs"/.git-revision)
|
|
echo "Channel $channel is at revision $rev"
|
|
echo "nixpkgs=$nixpkgs" >> "$GITHUB_ENV"
|
|
echo "rev=$rev" >> "$GITHUB_ENV"
|
|
- name: Fetching pre-built nixpkgs-check-by-name from the channel
|
|
run: |
|
|
echo "Fetching pre-built nixpkgs-check-by-name from channel $channel at revision $rev"
|
|
# Passing --max-jobs 0 makes sure that we won't build anything
|
|
nix-build "$nixpkgs" -A tests.nixpkgs-check-by-name --max-jobs 0
|
|
- name: Running nixpkgs-check-by-name
|
|
run: |
|
|
echo "Checking whether the check succeeds on the base branch $GITHUB_BASE_REF"
|
|
git checkout -q "$baseSha"
|
|
if baseOutput=$(result/bin/nixpkgs-check-by-name . 2>&1); then
|
|
baseSuccess=1
|
|
else
|
|
baseSuccess=
|
|
fi
|
|
printf "%s\n" "$baseOutput"
|
|
|
|
echo "Checking whether the check would succeed after merging this pull request"
|
|
git checkout -q "$mergedSha"
|
|
if mergedOutput=$(result/bin/nixpkgs-check-by-name . 2>&1); then
|
|
mergedSuccess=1
|
|
exitCode=0
|
|
else
|
|
mergedSuccess=
|
|
exitCode=1
|
|
fi
|
|
printf "%s\n" "$mergedOutput"
|
|
|
|
resultToEmoji() {
|
|
if [[ -n "$1" ]]; then
|
|
echo ":heavy_check_mark:"
|
|
else
|
|
echo ":x:"
|
|
fi
|
|
}
|
|
|
|
# Print a markdown summary in GitHub actions
|
|
{
|
|
echo "| Nixpkgs version | Check result |"
|
|
echo "| --- | --- |"
|
|
echo "| Latest base commit | $(resultToEmoji "$baseSuccess") |"
|
|
echo "| After merging this PR | $(resultToEmoji "$mergedSuccess") |"
|
|
echo ""
|
|
|
|
if [[ -n "$baseSuccess" ]]; then
|
|
if [[ -n "$mergedSuccess" ]]; then
|
|
echo "The check succeeds on both the base branch and after merging this PR"
|
|
else
|
|
echo "The check succeeds on the base branch, but would fail after merging this PR:"
|
|
echo "\`\`\`"
|
|
echo "$mergedOutput"
|
|
echo "\`\`\`"
|
|
echo ""
|
|
fi
|
|
else
|
|
if [[ -n "$mergedSuccess" ]]; then
|
|
echo "The check fails on the base branch, but this PR fixes it, nicely done!"
|
|
else
|
|
echo "The check fails on both the base branch and after merging this PR, unknown if only this PRs changes would satisfy the check, the base branch needs to be fixed first."
|
|
echo ""
|
|
echo "Failure on the base branch:"
|
|
echo "\`\`\`"
|
|
echo "$baseOutput"
|
|
echo "\`\`\`"
|
|
echo ""
|
|
echo "Failure after merging this PR:"
|
|
echo "\`\`\`"
|
|
echo "$mergedOutput"
|
|
echo "\`\`\`"
|
|
echo ""
|
|
fi
|
|
fi
|
|
|
|
echo "### Details"
|
|
echo "- nixpkgs-check-by-name tool:"
|
|
echo " - Channel: $channel"
|
|
echo " - Nixpkgs commit: [$rev](https://github.com/${GITHUB_REPOSITORY}/commit/$rev)"
|
|
echo " - Store path: \`$(realpath result)\`"
|
|
echo "- Tested Nixpkgs:"
|
|
echo " - Base branch $GITHUB_BASE_REF"
|
|
echo " - Latest base branch commit: [$baseSha](https://github.com/${GITHUB_REPOSITORY}/commit/$baseSha)"
|
|
echo " - Latest PR commit: [$headSha](https://github.com/${GITHUB_REPOSITORY}/commit/$headSha)"
|
|
echo " - Merge commit: [$mergedSha](https://github.com/${GITHUB_REPOSITORY}/commit/$mergedSha)"
|
|
} >> "$GITHUB_STEP_SUMMARY"
|
|
|
|
exit "$exitCode"
|
|
|