cafkafk/nixpkgs
cafkafk/nixpkgs
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions 2
nixpkgs/pkgs/desktops
History
Chuck a45b3ad89f
makeWrapper: Remove unused extraFlagsArray feature 
There is a bug in this feature: It allows extra arguments to leak in
from the environment. For example:

  $ export extraFlagsArray=date
  $ man ls

Note that you get the man page for date rather than for ls. This happens
because 'man' happens to use a wrapper (to add groff to its PATH).

An attempt to fix this was made in 5ae18574fc in PR #19328 for
issue #2537, but 1. That change didn't actually fix the problem because
it addressed makeWrapper's environment during the build process, not the
constructed wrapper script's environment after installation, and 2. That
change was apparently accidentally lost when merged with 7ff6eec5fd.

Rather than trying to fix the bug again, we remove the extraFlagsArray
feature, since it has never been used in the public repo in the ten
years it has been available.

wrapAclocal continues to use its own, separate flavor of extraFlagsArray
in a more limited context. The analogous bug there was fixed in
4d7d10da6b in 2011.
2019-09-25 09:23:09 -07:00
..
deepin treewide: icons propagate hicolor-icon-theme, dontDropIconThemeCache 2019-09-18 22:47:29 +02:00
enlightenment enlightenment.enlightenment: add dependency on bc 2019-09-18 11:28:49 -03:00
gnome-2 tree-wide: s/GTK+/GTK/g 2019-09-06 02:54:53 +02:00
gnome-3 treewide: drop adding hicolor-icon-theme where possible 2019-09-18 22:47:26 +02:00
gnustep makeWrapper: Remove unused extraFlagsArray feature 2019-09-25 09:23:09 -07:00
lumina lumina.lumina-pdf: init at 2019-04-27 2019-05-24 18:14:46 -03:00
lxde/core tree-wide: s/GTK+/GTK/g 2019-09-06 02:54:53 +02:00
lxqt treewide: drop adding hicolor-icon-theme where possible 2019-09-18 22:47:26 +02:00
mate treewide: icons propagate hicolor-icon-theme, dontDropIconThemeCache 2019-09-18 22:47:29 +02:00
maxx gdk-pixbuf: rename from gdk_pixbuf 2019-07-22 18:50:57 -04:00
pantheon gtk3.setupHook: clear icon-theme.cache in preFixup (#68552) 2019-09-22 16:30:42 +02:00
plasma-5 kwin-tiling: init at 2.2 2019-09-11 13:50:05 +08:00
rox/rox-filer treewide: drop adding hicolor-icon-theme where possible 2019-09-18 22:47:26 +02:00
surf-display treewide: don't use single quotes with placeholder 2019-09-03 13:01:42 -04:00
xfce tree-wide: s/GTK+/GTK/g 2019-09-06 02:54:53 +02:00
xfce4-14 nixos/xfce4-14: remove gtk-xfce-engine 2019-09-17 17:05:39 -04:00