nixpkgs/pkgs/development/python-modules/Cython/default.nix
Martin Weinelt c8ece5516e
python310Packages.cython: Force regeneration of generated code in sdists
Lots of python packages seem to ship their source distributions with
generated code. In recent cython versions there is a way to force a
regeneration of these files and using it sounds generally sounds like a
good thing.

If it turns out, that this causes problems on individual packages,
setting `dontForceRegenCython` will prevent the regeneration.

Added in 3.0.0a11 and backported to 2.9.34, so both cython versions we
ship right now support this flag.
2023-04-02 21:35:05 +02:00

88 lines
3 KiB
Nix

{ lib
, stdenv
, buildPythonPackage
, fetchPypi
, fetchpatch
, python
, pkg-config
, gdb
, numpy
, ncurses
}:
let
excludedTests = [ "reimport_from_subinterpreter" ]
# cython's testsuite is not working very well with libc++
# We are however optimistic about things outside of testsuite still working
++ lib.optionals (stdenv.cc.isClang or false) [ "cpdef_extern_func" "libcpp_algo" ]
# Some tests in the test suite isn't working on aarch64. Disable them for
# now until upstream finds a workaround.
# Upstream issue here: https://github.com/cython/cython/issues/2308
++ lib.optionals stdenv.isAarch64 [ "numpy_memoryview" ]
++ lib.optionals stdenv.isi686 [ "future_division" "overflow_check_longlong" ]
;
in buildPythonPackage rec {
pname = "cython";
version = "0.29.34";
src = fetchPypi {
pname = "Cython";
inherit version;
hash = "sha256-GQloj117Uhpgw5bSC7qeR6Gy0nhL+whUAeHh59KaKag=";
};
nativeBuildInputs = [
pkg-config
];
nativeCheckInputs = [
gdb numpy ncurses
];
LC_ALL = "en_US.UTF-8";
patches = [
# backport Cython 3.0 trashcan support (https://github.com/cython/cython/pull/2842) to 0.X series.
# it does not affect Python code unless the code explicitly uses the feature.
# trashcan support is needed to avoid stack overflows during object deallocation in sage (https://trac.sagemath.org/ticket/27267)
./trashcan.patch
# The above commit introduces custom trashcan macros, as well as
# compiler changes to use them in Cython-emitted code. The latter
# change is still useful, but the former has been upstreamed as of
# Python 3.8, and the patch below makes Cython use the upstream
# trashcan macros whenever available. This is needed for Python
# 3.11 support, because the API used in Cython's implementation
# changed: https://github.com/cython/cython/pull/4475
(fetchpatch {
name = "disable-trashcan.patch";
url = "https://github.com/cython/cython/commit/e337825cdcf5e94d38ba06a0cb0188e99ce0cc92.patch";
hash = "sha256-q0f63eetKrDpmP5Z4v8EuGxg26heSyp/62OYqhRoSso=";
})
];
checkPhase = ''
export HOME="$NIX_BUILD_TOP"
${python.interpreter} runtests.py -j$NIX_BUILD_CORES \
--no-code-style \
${lib.optionalString (builtins.length excludedTests != 0)
''--exclude="(${builtins.concatStringsSep "|" excludedTests})"''}
'';
# https://github.com/cython/cython/issues/2785
# Temporary solution
doCheck = false;
# doCheck = !stdenv.isDarwin;
# force regeneration of generated code in source distributions
# https://github.com/cython/cython/issues/5089
setupHook = ./setup-hook.sh;
meta = {
changelog = "https://github.com/cython/cython/blob/${version}/CHANGES.rst";
description = "An optimising static compiler for both the Python programming language and the extended Cython programming language";
homepage = "https://cython.org";
license = lib.licenses.asl20;
maintainers = with lib.maintainers; [ fridh ];
};
}