Fixed problem introduced by error handling.
This does not fix fast or fix lack of message input.
Signed-off-by: Christina Sørensen <christina@cafkafk.com>
Updated pretty-env-logger to 0.5.0, as it was pulling atty which has a
potential security vulnerability, and further has been unmaintained and
unresponsive for 3 years.
https://github.com/advisories/GHSA-g98v-hv3f-hcfr
Signed-off-by: Christina Sørensen <christina@cafkafk.com>
As described in preceding commits.
Also added documentation changes that I forgot to add before amending to
previous commit :(
Signed-off-by: Christina Sørensen <christina@cafkafk.com>
This follows up on previous commits message, but with a completely
different implementation that is a lot tighter.
It doesn't handle commit messages, but quick is now implemented.
This has also shown that the previous fall-through behaviour of quick
wasn't a bug but a feature, as it would try to pull, not fail if it
couldn't.
This means it would be a good idea to implement an alternative version
of quick that keeps this old behaviour, or probably more likely,
creating a new command that does what the quick in this commit does, and
then finding a way to recreate the old behaviour of quick.
This is dev branch thou, so I don't have to do that before pushing :D
Signed-off-by: Christina Sørensen <christina@cafkafk.com>
Started thinking about a new problem relating to how to deal with a
series of operations, as quick has been doing so far.
Now that we are trying to react to errors, it would be cool if we could
stop early, but this require maintaining a list of things that have
failed to avoid running them, and so we need to perform that logic
inside of the function (at least it's the more reasonable approach imo)
One way I can sketch rn might be to copy the hashmap structure of repos
as a reference, and then delete the references from our cloned map as
they fail. This is not ideal in any specific way, but it's a good first
approximation.
Signed-off-by: Christina Sørensen <christina@cafkafk.com>
Propagates the git exit code up through the layers, making the config
handle the actual errors at the output layer.
Signed-off-by: Christina Sørensen <christina@cafkafk.com>
Following up on previous commit, added spinner to all repo actions.
Also introduced on_all_spinner helper function, which is a version of
on_all, but intended for a single repo action (not a composed one like
quick), that takes care of managing the spinner.
Signed-off-by: Christina Sørensen <christina@cafkafk.com>
Spinners are a blinking lights UX component. Ideally, a flag will be
added to run silently.
This only implements a sketch for using spinners when doing a quick
sync.
Signed-off-by: Christina Sørensen <christina@cafkafk.com>
Fixed tests to work with the new hashmap based architecture.
Introduced some handy helper functions in main.rs testing that I might
wanna move to the impl block of config later.
Signed-off-by: Christina Sørensen <christina@cafkafk.com>
This is an implementation of the nested hashmap architecture, outlined
in architecture.md, however, with a hashmap instead of a btreemap.
This is ultimately just a sketch.
Signed-off-by: Christina Sørensen <christina@cafkafk.com>
This commit introduces on_all() on the config struct.
This unifies behaviour for iterating over all repos
in the config.
I'm introducing this to make testing various architectural
choices a breeze.
NOTE: Ideally, GitRepo should also be made generic, allowing
other types of repos at some point.
Signed-off-by: Christina Sørensen <christina@cafkafk.com>
Naive category implementation.
Works somewhat, including part of tests.
However, I realize now that perhaps, having unique category names in
nescesarry for subcommands.
On the other hand, allowing them to be non unique would allow splitting
up category definitions.
But finding the category in a vec would be slow...
...and I want a lot of categories probably...
I'm still working on this... here is one way to do it ᕕ( ᐛ )ᕗ
Saved in the git log for posterity.
Signed-off-by: Christina Sørensen <christina@cafkafk.com>
Flags indicate what operations should be masked on a repo.
This is done in a way that is relatively more pleasurable to configure,
and should reduce the amount of breaking changes long term.
Overally, a very nice commit :D
Signed-off-by: Christina Sørensen <christina@cafkafk.com>
Commented out code that could potentially be destructive, right now it's
only a sketch, and if the unimplemented macro was removed one might be
mistaken thinking the associated function was intended for use.
Signed-off-by: Christina Sørensen <christina@cafkafk.com>
Made the GitRepo associated functions easier to debug, by providing
additional output of the struct when running the git command on the repo
fails.
Also removed commented out code in main.
Signed-off-by: Christina Sørensen <christina@cafkafk.com>
This still has an issue, because tests cannot run with network inside of
the flake.
When this is solved, the code just needs to be refactored and it's
ready.
Signed-off-by: Christina Sørensen <christina@cafkafk.com>
Refactored Links::link implementation to be able to deal with
several possible scenarios:
- file already linked (happy case)
- link to different file exists
- non link file exists
- broken symlink exists
- no file exists (happy case)
- generic failure
Also attempted to make the code more readable than previous attempt.
Admittedly, still needs some work.
Signed-off-by: Christina Sørensen <christina@cafkafk.com>
Moved the help template into its own const, and concatenated it with the
interactive notice to append it to the help output.
Also, adjusted the license, warranty, and notice strings for increased
readability.
Signed-off-by: Christina Sørensen <christina@cafkafk.com>
Made the clap Parser able to be run without a subcommand, by wrapping
the subcommand field of the Parser struct in an Option<Command>.
Further destructured the subcommand arms fields in main with Some(),
and made the default case None just return ().
Signed-off-by: Christina Sørensen <christina@cafkafk.com>
Implemented the flag arms for license, warranty in main,
but this will not work before we make the clap Parser able
to be run without a subcommand, by wrapping the subcommand
field of the Parser struct in an Option<Command>.
Signed-off-by: Christina Sørensen <christina@cafkafk.com>
Made the following utils/strings consts public
- INTERACTIVE_NOTICE
- INTERACTIVE_LICENSE
- INTERACTIVE_WARRANTY
This is to allow their use in the flags match in main.
Signed-off-by: Christina Sørensen <christina@cafkafk.com>
Added an arm to the match statement for parsing flags in main.
Using the pattern and hopefully ongoing convention of making
unimplemented arms indicated by using the unimplemented!() macro.
Signed-off-by: Christina Sørensen <christina@cafkafk.com>
Added the --warranty flag.
Removed part of docstring that said the --license would give full-text.
This is wrong, as will be implementing the shorter notice.
Signed-off-by: Christina Sørensen <christina@cafkafk.com>
Added these three constants to utils/strings:
- INTERACTIVE_NOTICE
- INTERACTIVE_LICENSE
- INTERACTIVE_WARRANTY
These were based of the license text's notices for interactive programs,
found in the "How to Apply These Terms to Your New Programs" section.
Signed-off-by: Christina Sørensen <christina@cafkafk.com>
Strings representing where to run commands where one of:
.current_dir(&(self.path.to_owned() + &self.name))
.current_dir(format!("{}{}", &self.path, &self.name))
Decided to change all instances to the latter, as asking people seemed
to prefer it for readability.
Signed-off-by: Christina Sørensen <christina@cafkafk.com>
