troldspejlet/forgejo
troldspejlet/forgejo
1
0
Fork 0
mirror of https://codeberg.org/forgejo/forgejo.git synced 2024-11-27 21:03:56 +01:00
Code Issues Projects Releases Packages Wiki Activity Actions 8

Improve the deletion of issue (#18945)

Browse source 
Co-authored-by: 6543 <6543@obermui.de>
This commit is contained in:
Lunny Xiao 2022-03-03 01:38:56 +08:00 committed by GitHub
parent f8898c30dc
commit 04971c33a3
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 9 additions and 9 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

18
models/issue.go
View file

@ -2043,17 +2043,17 @@ func deleteIssue(ctx context.Context, issue *Issue) error {
} }
// delete actions assigned to this issue // delete actions assigned to this issue
var comments []int64 subQuery := builder.Select("`id`").
if err := e.Table(new(Comment)).In("issue_id", issue.ID).Cols("id").Find(&comments); err != nil { From("`comment`").
Where(builder.Eq{"`issue_id`": issue.ID})
if _, err := e.In("comment_id", subQuery).Delete(&Action{}); err != nil {
return err return err
} }
for i := range comments {
if _, err := e.Where("comment_id = ?", comments[i]).Delete(&Action{}); err != nil { if _, err := e.Table("action").Where("repo_id = ?", issue.RepoID).
return err In("op_type", ActionCreateIssue, ActionCreatePullRequest).
} Where("content LIKE ?", strconv.FormatInt(issue.ID, 10)+"|%").
} Delete(&Action{}); err != nil {
if _, err := e.Table("action").Where("repo_id = ?", issue.RepoID).In("op_type", ActionCreateIssue, ActionCreatePullRequest).
Where("content LIKE ?", strconv.FormatInt(issue.ID, 10)+"|%").Delete(&Action{}); err != nil {
return err return err
} }