From 499bff43d935f1334a76b86fe3a44a5a670479ef Mon Sep 17 00:00:00 2001
From: Lunny Xiao <xiaolunwen@gmail.com>
Date: Wed, 21 Nov 2018 01:10:18 +0800
Subject: [PATCH] dont' send assign webhooks when creating issue (#5365)
---
models/issue_assignees.go | 9 +++++----
1 file changed, 5 insertions(+), 4 deletions(-)
diff --git a/models/issue_assignees.go b/models/issue_assignees.go
index b4f346974b..09d4d310dc 100644
--- a/models/issue_assignees.go
+++ b/models/issue_assignees.go
@@ -159,12 +159,13 @@ func (issue *Issue) changeAssignee(sess *xorm.Session, doer *User, assigneeID in
return fmt.Errorf("createAssigneeComment: %v", err)
}
+ // if issue/pull is in the middle of creation - don't call webhook
+ if isCreate {
+ return nil
+ }
+
mode, _ := accessLevel(sess, doer.ID, issue.Repo)
if issue.IsPull {
- // if pull request is in the middle of creation - don't call webhook
- if isCreate {
- return nil
- }
if err = issue.loadPullRequest(sess); err != nil {
return fmt.Errorf("loadPullRequest: %v", err)
}