Xavier Vello
147ae2c5be
Fix opengraph meta for wiki pages ( #4427 )
...
Fixes https://codeberg.org/forgejo/forgejo/issues/4417 by adding a conditional branch to the `head_opengraph` template to match wiki pages. I tried to be consistent with the other types:
- `og:title` is the wiki page title
- `og:url` is built via `{{AppUrl}}{{.Link}}` like it is done for commit and file views. This has the caveat of doubling the slash (see test below). Should we `{{trimSuffix "/" AppUrl}}` to remove this, if sprig is available?
- `og:description` is the repository description to match GH behaviour. Also, the first sentences of the page might not be descriptive enough. Should we prefix the repo description with the repo name?
- `og:type` and `og:image` are common
Added a `TestOpenGraphProperties` integration test using existing fixtures. Coverage is not 100% but can be improved later.
## Output on a test repo
```html
<meta property="og:title" content="Project architecture">
<meta property="og:url" content="http://localhost:3000//xvello/wiki-test/wiki/Project-architecture ">
<meta property="og:description" content="description for a test project">
<meta property="og:type" content="object">
<meta property="og:image" content="http://localhost:3000/avatars/3dd4d1e4eef065d1b4ad4bdb081ab6e7 ">
```
Reviewed-on: https://codeberg.org/forgejo/forgejo/pulls/4427
Co-authored-by: Xavier Vello <xavier.vello@gmail.com>
Co-committed-by: Xavier Vello <xavier.vello@gmail.com>
2024-07-10 18:29:35 +00:00
Earl Warren
9b8622bc58
Merge pull request 'docs(release-notes): fix artifact range requests [skip ci]' ( #4443 ) from earl-warren/forgejo:wip-release-notes into forgejo
...
Reviewed-on: https://codeberg.org/forgejo/forgejo/pulls/4443
Reviewed-by: Michael Kriese <michael.kriese@gmx.de>
Reviewed-by: twenty-panda <twenty-panda@noreply.codeberg.org>
2024-07-10 18:27:03 +00:00
Earl Warren
52775aa66a
docs(release-notes): fix artifact range requests
...
Refs: https://codeberg.org/forgejo/forgejo/pulls/4218
2024-07-10 08:52:06 +02:00
Earl Warren
436f8fda07
Merge pull request 'Make user privacy settings more clear' ( #4439 ) from 0ko/forgejo:ui-settings-activity into forgejo
...
Reviewed-on: https://codeberg.org/forgejo/forgejo/pulls/4439
Reviewed-by: Earl Warren <earl-warren@noreply.codeberg.org>
2024-07-10 06:09:52 +00:00
ThetaDev
e80f8ff69f
fix artifact range requests ( #4218 )
...
I noticed that Forgejo does not allow HTTP range requests when downloading artifacts. All other file downloads like releases and packages support them.
So I looked at the code and found that the artifact download endpoint uses a simple io.Copy to serve the file contents instead of using the established `ServeContentByReadSeeker` function which does take range requests into account.
Reviewed-on: https://codeberg.org/forgejo/forgejo/pulls/4218
Reviewed-by: Earl Warren <earl-warren@noreply.codeberg.org>
Reviewed-by: Gusted <gusted@noreply.codeberg.org>
Co-authored-by: ThetaDev <thetadev@magenta.de>
Co-committed-by: ThetaDev <thetadev@magenta.de>
2024-07-10 05:28:01 +00:00
Shiny Nematoda
928f188689
fix(code search): various ui/ux improvements raised by user research ( #4332 )
...
various improvements from [user research](https://codeberg.org/forgejo/user-research/src/branch/main/interviews/2024-06/issues%28search%2Cfeatures%29%2Cselfhosting%2CCI%2Caccessibility%2Ccodesearch.md )
- filenames are links to the respective files
fixes: `fold menu: user clicked and expected to view file, instead the file collapsed`
- refactor(searchfile.tmpl): ordered lists with lines grouped together instead of table
fixes: `multiple matches per file are "merged", only visible in the code lines (no visual separation)`
- feat: display fuzzy as "Either" when using git-grep which is much more accurate than "fuzzy"
git-grep does not support fuzzy searching, in this context selecting fuzzy searching worked similar to an OR of white space separated keywords
fixes: `typo doesn't bring results in fuzzy search`
---
<details>
<summary>Before</summary>
</details>
<details>
<summary>After</summary>
</details>
Reviewed-on: https://codeberg.org/forgejo/forgejo/pulls/4332
Reviewed-by: 0ko <0ko@noreply.codeberg.org>
Co-authored-by: Shiny Nematoda <snematoda.751k2@aleeas.com>
Co-committed-by: Shiny Nematoda <snematoda.751k2@aleeas.com>
2024-07-10 05:25:32 +00:00
Earl Warren
2d85d51879
docs(release-notes): for pull requests #4400 , #4375 [skip ci] ( #4442 )
...
Refs: https://codeberg.org/forgejo/forgejo/pulls/4400
Reviewed-on: https://codeberg.org/forgejo/forgejo/pulls/4442
Reviewed-by: 0ko <0ko@noreply.codeberg.org>
Co-authored-by: Earl Warren <contact@earl-warren.org>
Co-committed-by: Earl Warren <contact@earl-warren.org>
2024-07-10 05:14:16 +00:00
0ko
29a1c786a3
ui(settings): make user privacy settings more clear
2024-07-10 10:07:23 +05:00
Earl Warren
8acaa427d6
Merge pull request 'Port of Refactor login page' ( #4400 ) from 0ko/forgejo:ui-login-redesign into forgejo
...
Reviewed-on: https://codeberg.org/forgejo/forgejo/pulls/4400
Reviewed-by: Earl Warren <earl-warren@noreply.codeberg.org>
2024-07-10 04:15:56 +00:00
Earl Warren
cd70d36bbb
Merge pull request 'Update module golang.org/x/tools to v0.23.0 (forgejo)' ( #4441 ) from renovate/forgejo-xtools into forgejo
...
Reviewed-on: https://codeberg.org/forgejo/forgejo/pulls/4441
Reviewed-by: Earl Warren <earl-warren@noreply.codeberg.org>
2024-07-10 04:13:47 +00:00
Renovate Bot
6154befef6
Update module golang.org/x/tools to v0.23.0
2024-07-10 00:01:50 +00:00
Earl Warren
1efec2adab
Merge pull request 'Update module github.com/buildkite/terminal-to-html/v3 to v3.14.0 (forgejo)' ( #4429 ) from renovate/forgejo-github.com-buildkite-terminal-to-html-v3-3.x into forgejo
...
Reviewed-on: https://codeberg.org/forgejo/forgejo/pulls/4429
Reviewed-by: Earl Warren <earl-warren@noreply.codeberg.org>
Reviewed-by: Michael Kriese <michael.kriese@gmx.de>
2024-07-09 21:58:01 +00:00
Earl Warren
51c5b993ab
Merge pull request 'chore(renovate): group x/tools/* upgrade' ( #4436 ) from earl-warren/forgejo:wip-renovate-x/tools into forgejo
...
Reviewed-on: https://codeberg.org/forgejo/forgejo/pulls/4436
Reviewed-by: Michael Kriese <michael.kriese@gmx.de>
2024-07-09 06:57:02 +00:00
Earl Warren
e2d09101d4
docs(release-notes): display URLs in .sh-session files
2024-07-09 08:24:46 +02:00
Earl Warren
4f6c823ae7
Merge pull request '[gitea] week 2024-28 cherry pick (gitea/main -> forgejo)' ( #4391 ) from earl-warren/wcp/2024-28 into forgejo
...
Reviewed-on: https://codeberg.org/forgejo/forgejo/pulls/4391
Reviewed-by: twenty-panda <twenty-panda@noreply.codeberg.org>
2024-07-09 05:37:52 +00:00
Earl Warren
f915532703
chore(renovate): group x/tools/* upgrade
...
Refs: https://codeberg.org/forgejo/forgejo/pulls?q=x%2Ftools&type=all
2024-07-09 07:23:22 +02:00
Earl Warren
6c9e0a6641
Merge pull request 'test: add valkey to remote cache test' ( #4434 ) from jthvai/forgejo:test-valkey into forgejo
...
Reviewed-on: https://codeberg.org/forgejo/forgejo/pulls/4434
Reviewed-by: Earl Warren <earl-warren@noreply.codeberg.org>
2024-07-09 05:21:15 +00:00
Earl Warren
cf5fb9a2e7
Merge pull request 'Update module golang.org/x/net to v0.27.0 (forgejo)' ( #4430 ) from renovate/forgejo-golang.org-x-net-0.x into forgejo
...
Reviewed-on: https://codeberg.org/forgejo/forgejo/pulls/4430
Reviewed-by: Earl Warren <earl-warren@noreply.codeberg.org>
2024-07-09 05:02:44 +00:00
Earl Warren
6c2106b5be
Merge pull request 'Update module golang.org/x/tools/cmd/deadcode to v0.23.0 (forgejo)' ( #4433 ) from renovate/forgejo-golang.org-x-tools-cmd-deadcode-0.x into forgejo
...
Reviewed-on: https://codeberg.org/forgejo/forgejo/pulls/4433
Reviewed-by: Earl Warren <earl-warren@noreply.codeberg.org>
2024-07-09 04:54:08 +00:00
Elias Elwyn
f3f6bc5b33
test: add valkey to remote cache test
2024-07-09 14:26:46 +10:00
Renovate Bot
a86380419e
Update module golang.org/x/tools/cmd/deadcode to v0.23.0
2024-07-09 00:03:39 +00:00
Renovate Bot
a8f35f6edd
Update module github.com/buildkite/terminal-to-html/v3 to v3.14.0
2024-07-09 00:03:10 +00:00
Earl Warren
764b9abc6b
Merge pull request 'tests: run JavaScript tests when web_src/js is modified' ( #4419 ) from earl-warren/forgejo:wip-e2e into forgejo
...
Reviewed-on: https://codeberg.org/forgejo/forgejo/pulls/4419
Reviewed-by: twenty-panda <twenty-panda@noreply.codeberg.org>
2024-07-08 18:50:02 +00:00
banaanihillo
099682892b
accessibility: anchor elements' missing href added ( #4375 )
...
Add an empty hash `href="#"` attribute to anchors that did not yet have any `href` attribute, as a quick work-around to make those elements possible to interact with via keyboard. See discussion on linked issue (https://codeberg.org/forgejo/forgejo/issues/4273 ) for more information on how the button-like elements like this could eventually be improved even more.
Fixes https://codeberg.org/forgejo/forgejo/issues/4273 .
Reviewed-on: https://codeberg.org/forgejo/forgejo/pulls/4375
Reviewed-by: Gusted <gusted@noreply.codeberg.org>
Co-authored-by: banaanihillo <banaanihillo@noreply.codeberg.org>
Co-committed-by: banaanihillo <banaanihillo@noreply.codeberg.org>
2024-07-08 17:32:59 +00:00
Earl Warren
a6a64f1fdc
tests: run JavaScript tests when web_src/js is modified
...
otherwise they are not useful
2024-07-08 19:26:14 +02:00
Earl Warren
dd39b6d1bc
Merge pull request 'Update renovate to v37.425.2 (forgejo)' ( #4418 ) from renovate/forgejo-renovate into forgejo
...
Reviewed-on: https://codeberg.org/forgejo/forgejo/pulls/4418
Reviewed-by: Michael Kriese <michael.kriese@gmx.de>
2024-07-08 13:42:29 +00:00
Renovate Bot
faaf03a44a
Update renovate to v37.425.2
2024-07-08 13:01:21 +00:00
Earl Warren
01bda22721
Merge pull request 'Fix branch selector in commit graph' ( #4401 ) from beowulf/fix-commit-graph-branch-selector into forgejo
...
Reviewed-on: https://codeberg.org/forgejo/forgejo/pulls/4401
Reviewed-by: 0ko <0ko@noreply.codeberg.org>
Reviewed-by: Earl Warren <earl-warren@noreply.codeberg.org>
2024-07-08 11:21:54 +00:00
Earl Warren
964310b7ba
Merge pull request 'chore(renovate): remove schedules for stable branches' ( #4409 ) from viceice/renovate-schedules into forgejo
...
Reviewed-on: https://codeberg.org/forgejo/forgejo/pulls/4409
Reviewed-by: Earl Warren <earl-warren@noreply.codeberg.org>
2024-07-08 08:17:11 +00:00
Michael Kriese
f4a9fb73b4
chore(renovate): remove schedules for stable branches
2024-07-08 09:03:37 +02:00
Earl Warren
567fccb02e
Merge pull request 'Update module golang.org/x/crypto to v0.25.0 (forgejo)' ( #4408 ) from renovate/forgejo-golang.org-x-crypto-0.x into forgejo
...
Reviewed-on: https://codeberg.org/forgejo/forgejo/pulls/4408
Reviewed-by: Earl Warren <earl-warren@noreply.codeberg.org>
2024-07-08 05:42:30 +00:00
Renovate Bot
1630a94cfa
Update module golang.org/x/net to v0.27.0
2024-07-08 00:05:03 +00:00
Renovate Bot
e4e2e91467
Update module golang.org/x/crypto to v0.25.0
2024-07-08 00:04:57 +00:00
Earl Warren
8d64891b8b
Merge pull request '[BUG] Fix mobile UI for organisation creation' ( #4382 ) from gusted/mobile-org into forgejo
...
Reviewed-on: https://codeberg.org/forgejo/forgejo/pulls/4382
Reviewed-by: Beowulf <beowulf@noreply.codeberg.org>
2024-07-07 19:28:30 +00:00
Beowulf
11ff38dd40
fix branch selector in commit graph
...
Regression from 5ef80ceb64
2024-07-07 20:26:30 +02:00
0ko
7d5972d330
i18n: separate string for OpenID
2024-07-07 22:23:11 +05:00
0ko
2a03e2c6b9
i18n: cleanup
2024-07-07 22:18:39 +05:00
0ko
458bbe3f1a
ui: remove non-working passkey link
2024-07-07 22:11:50 +05:00
Earl Warren
502adec4ce
Merge pull request '[CHORE] Remove github.com/yuin/goldmark-meta' ( #4383 ) from gusted/chore-goldmark-meta into forgejo
...
Reviewed-on: https://codeberg.org/forgejo/forgejo/pulls/4383
Reviewed-by: Earl Warren <earl-warren@noreply.codeberg.org>
2024-07-07 13:47:30 +00:00
0ko
dcd1039215
i18n: fix strings related to sign in
...
Improve localizability, clean up.
2024-07-07 14:40:50 +05:00
0ko
577dc2d7d6
i18n: fix sign up strings
...
To avoid conflicting with existing strings in translations. Also improve localizability.
2024-07-07 14:37:45 +05:00
Anbraten
629ca22a97
Refactor login page ( #31530 )
...
As requested in
https://github.com/go-gitea/gitea/pull/31504#issuecomment-2196196646 .
This PR refactor the login page:
- [x] use separate box for passkey login and go to registration
- [x] move forgot passoword next to password label
- [x] fix password required label `*` and padding
- [x] remove tabs from login page
---------
Co-authored-by: silverwind <me@silverwind.io>
(cherry picked from commit 9c00dda33ad7bd594dd8f331fa1bf0acefc2ca54)
Conflict resolution:
* signin_navbar.tmpl has been deleted
* additions in form.css
* major code changes in signin_openid
* ...
2024-07-07 14:22:44 +05:00
Brecht Van Lommel
33f9fb8150
Fix slow patch checking with commits that add or remove many files ( #31548 )
...
Running git update-index for every individual file is slow, so add and
remove everything with a single git command.
When such a big commit lands in the default branch, it could cause PR
creation and patch checking for all open PRs to be slow, or time out
entirely. For example, a commit that removes 1383 files was measured to
take more than 60 seconds and timed out. With this change checking took
about a second.
This is related to #27967 , though this will not help with commits that
change many lines in few files.
(cherry picked from commit b88e5fc72d99e9d4a0aa9c13f70e0a9e967fe057)
2024-07-07 07:33:01 +02:00
charles
f92591b825
Fix markdown preview $$ support ( #31514 )
...
close #31481
currently `$$A + B$$ test` will ignore text after $$ block
test text
before fix
after fix
github display
(cherry picked from commit f0033051d5ce07f5a18d2aacef6bfdca5fc69014)
2024-07-07 07:29:49 +02:00
silverwind
e1b90212e4
Use stable version of fabric ( #31526 )
...
Fabric 6 is [now
stable](https://github.com/fabricjs/fabric.js/releases/tag/v6.0.0-rc5 ),
use it.
(cherry picked from commit 5821d22891cb3aa1e1c9590d8b921728b4969c5f)
2024-07-07 07:27:53 +02:00
0ko
c19222b22f
ui: improve button gap consistency in repos ( #4365 )
...
Improve UI in a few areas in a similar way to dc0d3a40abhttps://codeberg.org/attachments/cfca200a-3b68-4ba8-9876-75cea7822a00
https://codeberg.org/attachments/aaa5d387-919b-45af-8854-6d0f5273125f
https://codeberg.org/attachments/989225b7-b1dd-491d-bf76-7e4a962ea54e
Reviewed-on: https://codeberg.org/forgejo/forgejo/pulls/4365
Reviewed-by: Earl Warren <earl-warren@noreply.codeberg.org>
Reviewed-by: Gusted <gusted@noreply.codeberg.org>
2024-07-07 03:21:58 +00:00
Gusted
cf8f26d616
[CHORE] Remove github.com/yuin/goldmark-meta
...
- Remove a unused dependency. This dependency was added to handle YAML
'frontmatter' meta, parsing them and converting them to a table or
details in the resulting HTML. As can be read in the issue that reported
the behavior of YAML frontmatter being rendered literally,
https://github.com/go-gitea/gitea/issues/5377 .
- It's an unused dependency as the codebase since then moved on to do this YAML
parsing and rendering on their own, this was implemented in
812cfd0ad9
2024-07-07 03:18:13 +02:00
Gusted
610487eb83
[BUG] Fix mobile UI for organisation creation
...
- Don't make checkpoints or radio inputs full width on a small screen,
these obviously shouldn't try to take up the whole width of a container.
- Wrap the label for organisation permission box inside a `<span
class="inline field">`, so it gets a left-margin from the `.inline.field
> :first-child` selector. This make the checkboxes and radio buttons
groups look indented from the left.
- Resolves #4361
2024-07-07 01:37:38 +02:00
Earl Warren
3ff661fe9e
Merge pull request '[BUG] Use correct SHA in GetCommitPullRequest' ( #4377 ) from gusted/commit-to-pull into forgejo
...
Reviewed-on: https://codeberg.org/forgejo/forgejo/pulls/4377
Reviewed-by: Earl Warren <earl-warren@noreply.codeberg.org>
2024-07-06 20:59:18 +00:00
Earl Warren
bf0c9837cc
Merge pull request '[ENHANCEMENT] Improve caching of contributor stats' ( #4367 ) from gusted/contributors-stats-cache into forgejo
...
Reviewed-on: https://codeberg.org/forgejo/forgejo/pulls/4367
Reviewed-by: Earl Warren <earl-warren@noreply.codeberg.org>
2024-07-06 20:12:35 +00:00
