988 commits

Author	SHA1	Message	Date
Gusted	618eb8e72a	security: add permission check to 'delete branch after merge' ... - Add a permission check that the doer has write permissions to the head repository if the the 'delete branch after merge' is enabled when merging a pull request. - Unify the checks in the web and API router to `DeleteBranchAfterMerge`. - Added integration tests. (cherry picked from commit 266e0b2ce9)	2024-10-28 06:04:45 +00:00
Gusted	1f62fe8ae0	fix: make branch protection work for new branches ... - If `GetAffectedFiles` is called for a push with an empty oldCommitID, then set the oldCommitID to the empty tree. This will effictively diff all the changes included in the push, which is the expected behavior for branches. - Integration test added. - Resolves #5683 - Port of gitea#31778 but implemented differently. (cherry picked from commit f5e025917f)	2024-10-24 20:21:43 +00:00
Gusted	ef8f366734	fix: don't show truncated comments in RSS/Atom feeds ... - When a truncated comment is detected in the RSS/Atom feeds, fetch the comment from the database and use the original content. - Added integration test. - Resolves #5650 (cherry picked from commit f4a7132a89)	2024-10-22 16:50:57 +00:00
Michael Kriese	804051b9dd	fix: typo on releases for source code downloads ... Closes #5648 (cherry picked from commit 02f8fad54d)	2024-10-22 14:03:42 +00:00
dragon	fa307f06ac	fix arch pkg ... (cherry picked from commit 95c7599db5)	2024-10-21 05:10:13 +00:00
Gusted	642dd61446	fix: Add recentupdated as recognized sort option ... - Add `recentupdated` to the `OrderByMap`. - Add integration testing for organization and user repository sorting. - Resolves #5612 - Regression from 12e23ee199 where the `recentupdated` case was not added to the map, but was handled seperately as a fallback. The regression came into affect when 5a0bc35799 also relied on this map but didn't handle the `recentupdated` case. (cherry picked from commit df38c41c7a)	2024-10-20 10:58:07 +00:00
Gusted	fe35a17dbe	[BUG] Don't allow owner team with incorrect unit access ... - On editting a team, only update the units if the team isn't the 'Owners' team. Otherwise the 'Owners' team end up having all of their unit access modes set to 'None'; because the request form doesn't send over any units, as it's simply not shown in the UI. - Adds a database inconstency check and fix for the case where the 'Owners' team is affected by this bug. - Adds unit test. - Adds integration test. - Resolves #5528 - Regression of https://github.com/go-gitea/gitea/pull/24012 (cherry picked from commit 9de9034400)	2024-10-14 19:59:17 +00:00
Earl Warren	044cd5cf7e	Merge pull request '[v9.0/forgejo] Fix bug when a token is given public only' (#5526) from earl-warren/forgejo:wip-v9.0-public-scope into v9.0/forgejo ... Reviewed-on: https://codeberg.org/forgejo/forgejo/pulls/5526 Reviewed-by: Gusted <gusted@noreply.codeberg.org>	2024-10-11 20:16:28 +00:00
Otto	d8c8fa9bae	Merge pull request '[v9.0/forgejo] feat: "Assign to me" button on PR and Issues #5215' (#5524) from bp-v9.0/forgejo-2feb3d0 into v9.0/forgejo ... Reviewed-on: https://codeberg.org/forgejo/forgejo/pulls/5524 Reviewed-by: Otto <otto@codeberg.org>	2024-10-11 12:33:50 +00:00
Earl Warren	1f9104d96f	chore(lint): Fix bug when a token is given public only ... (cherry picked from commit 14d85597f8)	2024-10-11 05:25:32 +03:00
Lunny Xiao	ea5a8c7809	Fix bug when a token is given public only ... Port of https://github.com/go-gitea/gitea/pull/32204 (cherry picked from commit d6d3c96e6555fc91b3e2ef21f4d8d7475564bb3e) Conflicts: routers/api/v1/api.go services/context/api.go trivial context conflicts (cherry picked from commit a052d2b602) Conflicts: routers/api/v1/user/user.go trivial context conflict (search by email is not in v9.0)	2024-10-11 05:24:23 +03:00
TimedIn	5ae3b81f3c	Small fixes and rename for #5482 ... - New Issue Fixed assign me being hidden after assignees were cleared https://codeberg.org/forgejo/forgejo/pulls/5482/files#issuecomment-2365431 - Test for verifying the above - Removed wait for network idle from e2e test - Renamed templ key assigneeId to assigneeIds	2024-10-11 03:41:23 +02:00
TimedIn	6d2c29ae85	feat: "assign to me" button on PRs and issues ... includes: Tests for assignees on issues Move assignees selector of new Issue to assignees.tmpl (cherry picked from commit 2feb3d03d7)	2024-10-11 01:39:54 +00:00
Kidsan	e2ffe12e50	fix: improve discord webhook api conformance ... This commit corrects some cases in the discord webhook payload that do not align with the discord documentation (cherry picked from commit 6ea6f224b8)	2024-10-09 16:07:34 +00:00
Job	7d3a013e5e	Fix PR creation on forked repositories (#31863) ... Resolves #20475 (cherry picked from commit 7e68bc88238104d2ee8b5a877fc1ad437f1778a4) Conflicts: tests/integration/pull_create_test.go add missing testPullCreateDirectly from c63060b130d34e3f03f28f4dccbf04d381a95c17 Fix code owners will not be mentioned when a pull request comes from a forked repository (#30476)	2024-10-06 11:45:22 +02:00
Earl Warren	00e5c68060	Fix the logic of finding the latest pull review commit ID (#32139) (followup) ... Adjust the tests for review deletion to ignore a newly inserted fixture. It is a review request and cannot be deleted.	2024-10-06 11:45:22 +02:00
Zettat123	700e9f027b	Fix the logic of finding the latest pull review commit ID (#32139) ... Fix #31423 (cherry picked from commit f4b8f6fc40ce2869135372a5c6ec6418d27ebfba) Conflicts: models/fixtures/comment.yml comment fixtures have to be shifted because there is one more in Forgejo	2024-10-06 11:34:08 +02:00
Earl Warren	b2483b2ae0	Fix artifact v4 upload above 8MB (#31664) (fix lint errors)	2024-09-29 11:43:20 +02:00
ChristopherHX	14c7055494	Fix artifact v4 upload above 8MB (#31664) ... Multiple chunks are uploaded with type "block" without using "appendBlock" and eventually out of order for bigger uploads. 8MB seems to be the chunk size This change parses the blockList uploaded after all blocks to get the final artifact size and order them correctly before calculating the sha256 checksum over all blocks Fixes #31354 (cherry picked from commit b594cec2bda6f861effedb2e8e0a7ebba191c0e9) Conflicts: routers/api/actions/artifactsv4.go conflict because of Refactor AppURL usage (#30885) 67c1a07285008cc00036a87cef966c3bd519a50c that was not cherry-picked in Forgejo the resolution consist of removing the extra ctx argument	2024-09-29 11:43:18 +02:00
Earl Warren	5442b0a6b1	Merge pull request '[v9.0/forgejo] feat: add architecture-specific removal support for arch package' (#5407) from bp-v9.0/forgejo-89742c4 into v9.0/forgejo ... Reviewed-on: https://codeberg.org/forgejo/forgejo/pulls/5407	2024-09-27 12:09:01 +00:00
Exploding Dragon	658ed564cb	feat: add architecture-specific removal support for arch package (#5351) ... - [x] add architecture-specific removal support - [x] Fix upload competition - [x] Fix not checking input when downloading docs: https://codeberg.org/forgejo/docs/pulls/874 ### Release notes - [ ] I do not want this change to show in the release notes. Reviewed-on: https://codeberg.org/forgejo/forgejo/pulls/5351 Reviewed-by: Earl Warren <earl-warren@noreply.codeberg.org> Co-authored-by: Exploding Dragon <explodingfkl@gmail.com> Co-committed-by: Exploding Dragon <explodingfkl@gmail.com> (cherry picked from commit 89742c4913)	2024-09-27 08:29:09 +00:00
Jamie Schouten	74712e3400	Add bin to Composer Metadata (#32099) ... This PR addresses the missing `bin` field in Composer metadata, which currently causes vendor-provided binaries to not be symlinked to `vendor/bin` during installation. In the current implementation, running `composer install` does not publish the binaries, leading to issues where expected binaries are not available. By properly declaring the `bin` field, this PR ensures that binaries are correctly symlinked upon installation, as described in the [Composer documentation](https://getcomposer.org/doc/articles/vendor-binaries.md). (cherry picked from commit d351a42494e71b5e2da63302c2f9b46c78e6dbde) (cherry picked from commit 9d34731198)	2024-09-27 08:13:30 +00:00
KN4CK3R	2f1a737769	Fix incorrect /tokens api (#32085) ... Fixes #32078 - Add missing scopes output. - Disallow empty scope. --------- Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com> (cherry picked from commit 08adbc468f8875fd4763c3656b334203c11adc0a) (cherry picked from commit 526054332a)	2024-09-27 08:13:30 +00:00
Earl Warren	5b6d8a303d	Refactor CSRF protector (#32057) (fix forgejo tests) ... Fix the tests unique to Forgejo that are impacted by the refactor. (cherry picked from commit 6275d1bc50)	2024-09-27 08:13:29 +00:00
wxiaoguang	d26b7902ec	Refactor CSRF protector (#32057) ... Remove unused CSRF options, decouple "new csrf protector" and "prepare" logic, do not redirect to home page if CSRF validation falis (it shouldn't happen in daily usage, if it happens, redirecting to home doesn't help either but just makes the problem more complex for "fetch") (cherry picked from commit 1fede04b83288d8a91304a83b7601699bb5cba04) Conflicts: options/locale/locale_en-US.ini tests/integration/repo_branch_test.go trivial context conflicts (cherry picked from commit 1ae3b127fc)	2024-09-27 08:13:29 +00:00
Michael Kriese	1e5f7d2116	chore: fix lint error	2024-09-25 10:15:02 +02:00
Otto	8b62d3d5da	Merge pull request 'i18n: UX improvements: Team permissions and issue closing' (#5383) from fnetx/team-permissions-i18n into forgejo ... Reviewed-on: https://codeberg.org/forgejo/forgejo/pulls/5383 Reviewed-by: 0ko <0ko@noreply.codeberg.org>	2024-09-24 21:16:40 +00:00
Otto Richter	dc9a268d3c	i18n: UX improvements: Team permissions and issue closing ... Change word order for issue comment actions - An attempt to address https://codeberg.org/forgejo/forgejo/issues/2650 Org team permissions improvements - consistency: added missing dot - clarity: explain what external units mean - use dedicated keys to explain the permissions. - split in read/write permissions - use explicit labels for accessibility - ext_wiki.desc and ext_issues.desc are no longer in use.	2024-09-24 19:03:30 +02:00
Bram Hagens	4a74113dee	feat(ui): add more emoji and code block rendering in issues	2024-09-24 14:20:33 +02:00
Exploding Dragon	a6508f5b03	Fix: database not updated when using git push --tags --force (#5319) ... Closes #4274 link: https://github.com/go-gitea/gitea/pull/32040 ### Release notes - [ ] I do not want this change to show in the release notes. <!--start release-notes-assistant--> ## Draft release notes <!--URL:https://codeberg.org/forgejo/forgejo--> - Bug fixes - [PR](https://codeberg.org/forgejo/forgejo/pulls/5319): <!--number 5319 --><!--line 0 --><!--description Rml4OiBkYXRhYmFzZSBub3QgdXBkYXRlZCB3aGVuIHVzaW5nIGBnaXQgcHVzaCAtLXRhZ3MgLS1mb3JjZWA=-->Fix: database not updated when using `git push --tags --force`<!--description--> <!--end release-notes-assistant--> Reviewed-on: https://codeberg.org/forgejo/forgejo/pulls/5319 Reviewed-by: Otto <otto@codeberg.org> Co-authored-by: Exploding Dragon <explodingfkl@gmail.com> Co-committed-by: Exploding Dragon <explodingfkl@gmail.com>	2024-09-22 07:35:25 +00:00
Earl Warren	64d3fcd403	Merge pull request '[gitea] week 2024-38 cherry pick (gitea/main -> forgejo)' (#5325) from algernon/wcp/2024-38 into forgejo ... Reviewed-on: https://codeberg.org/forgejo/forgejo/pulls/5325 Reviewed-by: Gusted <gusted@noreply.codeberg.org> Reviewed-by: Earl Warren <earl-warren@noreply.codeberg.org>	2024-09-20 05:06:42 +00:00
Otto	a0c11f58dd	Merge pull request 'Fix milestone assignment in new issue' (#5180) from esainane/forgejo:five-hundred-more into forgejo ... Reviewed-on: https://codeberg.org/forgejo/forgejo/pulls/5180 Reviewed-by: Otto <otto@codeberg.org>	2024-09-17 16:50:42 +00:00
Sai Nane	7f02f4722c	Test: Milestone assignment in new issue ... This test currently fails, as expected, given this functionality is currently broken.	2024-09-17 17:45:02 +02:00
Otto Richter	61314f05fc	tests(e2e): Test overflow in commit graph	2024-09-17 17:33:00 +02:00
Otto Richter	804ca6590f	tests(e2e): long search result overflow ... Test fails before https://codeberg.org/forgejo/forgejo/pulls/5260	2024-09-14 22:28:24 +02:00
Kemal Zebari	eb765dabfd	Handle invalid target when creating releases using API (#31841) ... A 500 status code was thrown when passing a non-existent target to the create release API. This snapshot handles this error and instead throws a 404 status code. Discovered while working on #31840. (cherry picked from commit f05d9c98c4cb95e3a8a71bf3e2f8f4529e09f96f)	2024-09-14 18:45:18 +02:00
Otto Richter	ef473d34f5	docs(e2e): Add parametric viewport example test	2024-09-14 12:49:57 +02:00
Shiny Nematoda	14abf65269	feat: set created_by as the default filter for /issues and /pulls (#5286) ... Reviewed-on: https://codeberg.org/forgejo/forgejo/pulls/5286 Reviewed-by: Otto <otto@codeberg.org> Reviewed-by: 0ko <0ko@noreply.codeberg.org> Co-authored-by: Shiny Nematoda <snematoda.751k2@aleeas.com> Co-committed-by: Shiny Nematoda <snematoda.751k2@aleeas.com>	2024-09-13 12:55:39 +00:00
Michael Kriese	192a5ea68b	Merge pull request 'tests(e2e): Allow running in parallel' (#5288) from fnetx/e2e-parallel into forgejo ... Reviewed-on: https://codeberg.org/forgejo/forgejo/pulls/5288 Reviewed-by: Michael Kriese <michael.kriese@gmx.de>	2024-09-12 11:48:41 +00:00
Otto	c98996f0d2	Merge pull request 'Improve textarea paste (part of gitea#31948)' (#5269) from algernon/forgejo:gitea/port/31948-partial into forgejo ... Reviewed-on: https://codeberg.org/forgejo/forgejo/pulls/5269 Reviewed-by: Otto <otto@codeberg.org> Reviewed-by: Michael Kriese <michael.kriese@gmx.de>	2024-09-12 11:15:53 +00:00
Otto	742991abca	Merge pull request 'Fix bad spacing on new release page' (#5261) from maltejur/forgejo:push-nnnyrrvzlqqy into forgejo ... Reviewed-on: https://codeberg.org/forgejo/forgejo/pulls/5261 Reviewed-by: Otto <otto@codeberg.org>	2024-09-11 22:21:43 +00:00
Otto Richter	3ff15d03f3	tests(e2e): assert URL paste behaviour	2024-09-11 21:44:10 +02:00
Otto Richter	3695f5d096	Parallelize playwright tests ... - allow running with multiple workers (tested with up to four workers locally which didn't show signs of flakiness) - prevent race condition with webauthn tests (running them in parallel on the same user could prevent another test from logging in) - fix flakiness on CI action status (Chromium sometimes needs a long time to fill the href field, firefox is always faster) This reverts commit e8585eff5c.	2024-09-11 16:53:51 +02:00
Otto Richter	e4234fe6ab	tests(e2e): remove unnecessary example test ... The login behaviour is basically covered in login_user from utils_e2e.js, too.	2024-09-11 14:30:29 +02:00
Otto Richter	a62521f241	New release form semantics ... - correctly render labels without help text - accessibility: fix external release button focus - accessibility: test form aspects in browser test	2024-09-11 13:30:30 +02:00
Shiny Nematoda	6178a46fe2	feat: set fuzzy as default for issue search (#5270) ... Closes #5225 Reviewed-on: https://codeberg.org/forgejo/forgejo/pulls/5270 Reviewed-by: Otto <otto@codeberg.org> Reviewed-by: 0ko <0ko@noreply.codeberg.org> Co-authored-by: Shiny Nematoda <snematoda.751k2@aleeas.com> Co-committed-by: Shiny Nematoda <snematoda.751k2@aleeas.com>	2024-09-10 15:57:58 +00:00
Otto Richter	0f3ba99ff0	Add detailed instructions for e2e testing ... - rewrite parts of and improve README - simplify repo declaration - list coverage in workflow path filter	2024-09-09 14:06:10 +02:00
Otto Richter	d06da0d9c6	Update integration test README ... and remove outdated chinese version	2024-09-09 14:06:10 +02:00
Solomon Victorino	829e661c39	test: assert navigation URLs in release E2E test ... - last one waits for release deletion before the next browser run - disambiguates failures due to error responses	2024-09-01 10:33:29 -06:00
Otto	1004ecd56b	Merge pull request 'fix: WIP toggle by reducing max issue title' (#5143) from fnetx/wip-toggle-workaround into forgejo ... Reviewed-on: https://codeberg.org/forgejo/forgejo/pulls/5143 Reviewed-by: Gusted <gusted@noreply.codeberg.org>	2024-08-29 21:05:35 +00:00