1640 commits

Author	SHA1	Message	Date
Gusted	f298bf125a	Merge pull request 'fix: use ValidateEmail as binding across web forms' (#5158) from solomonv/consolidate-email-validation into forgejo ... Reviewed-on: https://codeberg.org/forgejo/forgejo/pulls/5158 Reviewed-by: Gusted <gusted@noreply.codeberg.org>	2024-10-21 14:31:32 +00:00
dragon	95c7599db5	fix arch pkg	2024-10-21 10:08:57 +08:00
Gusted	cd7c015dd3	Merge pull request 'mail issue: Display issue type in email header' (#5389) from xenrox/forgejo:mail-issue into forgejo ... Reviewed-on: https://codeberg.org/forgejo/forgejo/pulls/5389 Reviewed-by: Gusted <gusted@noreply.codeberg.org>	2024-10-19 21:54:56 +00:00
Thorben Günther	74403d1f0f	mail issue: Display issue type in email header ... Currently notification emails for Pull Requests or Issues are indistinguishable at first glance. This adds the type ("PR" or "Issue") before the index number.	2024-10-19 21:25:54 +02:00
Earl Warren	e2354703ed	Merge pull request '[gitea] week 2024-42 cherry pick (gitea/main -> forgejo)' (#5543) from earl-warren/wcp/2024-42 into forgejo ... Reviewed-on: https://codeberg.org/forgejo/forgejo/pulls/5543 Reviewed-by: Gusted <gusted@noreply.codeberg.org>	2024-10-19 13:54:24 +00:00
Earl Warren	69bedb8933	Merge pull request 'fix: correct documentation for non 200 responses in swagger' (#5491) from JakobDev/forgejo:fixswagger into forgejo ... Reviewed-on: https://codeberg.org/forgejo/forgejo/pulls/5491 Reviewed-by: Otto <otto@codeberg.org>	2024-10-15 11:34:35 +00:00
Otto	1d13249e17	Merge pull request '[BUG] Don't allow owner team with incorrect unit access' (#5529) from gusted/forgejo-owners-team-description into forgejo ... Reviewed-on: https://codeberg.org/forgejo/forgejo/pulls/5529 Reviewed-by: Otto <otto@codeberg.org>	2024-10-14 19:56:58 +00:00
Earl Warren	e299a7f4cd	Merge pull request 'fix: don't cancel schedule workflows on push to main branch' (#5470) from Kwonunn/forgejo:dont-cancel-schedule-workflow into forgejo ... Reviewed-on: https://codeberg.org/forgejo/forgejo/pulls/5470	2024-10-13 12:06:02 +00:00
Lunny Xiao	8f61fce938	Only rename a user when they should receive a different name (#32247) ... Fix #31996 (cherry picked from commit 9df5ddaf44aa5a3f319acba7b18645b7b1d4d8a2)	2024-10-13 14:17:08 +03:00
Earl Warren	7855e4bb56	Improve the maintainblity of the reserved username list (#32229) ... (cherry picked from commit 6029d78ab5006e8fb4f42adb5a8c491f19fa7b0a) Conflicts: models/user/user.go services/user/user_test.go trivial context conflict tests/integration/user_test.go discarded entirely because dot may be allowed in Forgejo under some conditions	2024-10-13 14:17:08 +03:00
Gusted	9de9034400	[BUG] Don't allow owner team with incorrect unit access ... - On editting a team, only update the units if the team isn't the 'Owners' team. Otherwise the 'Owners' team end up having all of their unit access modes set to 'None'; because the request form doesn't send over any units, as it's simply not shown in the UI. - Adds a database inconstency check and fix for the case where the 'Owners' team is affected by this bug. - Adds unit test. - Adds integration test. - Resolves #5528 - Regression of https://github.com/go-gitea/gitea/pull/24012	2024-10-11 14:48:47 +02:00
Lunny Xiao	a052d2b602	Fix bug when a token is given public only ... Port of https://github.com/go-gitea/gitea/pull/32204 (cherry picked from commit d6d3c96e6555fc91b3e2ef21f4d8d7475564bb3e) Conflicts: routers/api/v1/api.go services/context/api.go trivial context conflicts	2024-10-10 10:41:42 +03:00
Otto	fd3bff3181	Merge pull request 'fix: Small fixes and rename for #5482' (#5505) from timedin/forgejo:forgejo into forgejo ... Reviewed-on: https://codeberg.org/forgejo/forgejo/pulls/5505 Reviewed-by: Otto <otto@codeberg.org>	2024-10-09 20:13:51 +00:00
Otto	ca2c850122	Merge pull request 'fix: correct Discord webhook JSON for issue events' (#5492) from kidsan/forgejo:discord-api-conformance into forgejo ... Reviewed-on: https://codeberg.org/forgejo/forgejo/pulls/5492 Reviewed-by: Otto <otto@codeberg.org>	2024-10-09 16:02:49 +00:00
TimedIn	e988a25237	Small fixes and rename for #5482 ... - New Issue Fixed assign me being hidden after assignees were cleared https://codeberg.org/forgejo/forgejo/pulls/5482/files#issuecomment-2365431 - Test for verifying the above - Removed wait for network idle from e2e test - Renamed templ key assigneeId to assigneeIds	2024-10-09 14:17:41 +02:00
Earl Warren	31fc0f66b7	Merge pull request '[gitea] week 2024-41 cherry pick (gitea/main -> forgejo)' (#5477) from earl-warren/wcp/2024-41 into forgejo ... Reviewed-on: https://codeberg.org/forgejo/forgejo/pulls/5477 Reviewed-by: Otto <otto@codeberg.org>	2024-10-09 05:02:20 +00:00
Kidsan	6ea6f224b8	fix: improve discord webhook api conformance ... This commit corrects some cases in the discord webhook payload that do not align with the discord documentation	2024-10-08 22:43:28 +02:00
TimedIn	2feb3d03d7	feat: "assign to me" button on PRs and issues ... includes: Tests for assignees on issues Move assignees selector of new Issue to assignees.tmpl	2024-10-08 18:36:37 +02:00
Kidsan	cf3ebab4ba	fix: add length limit to discord webhook icon_url	2024-10-08 17:22:27 +02:00
JakobDev	fcc3dd228d	fix: correct documentation for non 200 responses in swagger	2024-10-07 18:36:07 +02:00
Zettat123	b67b7c1238	Fix the logic of finding the latest pull review commit ID (#32139) ... Fix #31423 (cherry picked from commit f4b8f6fc40ce2869135372a5c6ec6418d27ebfba) Conflicts: models/fixtures/comment.yml comment fixtures have to be shifted because there is one more in Forgejo	2024-10-06 07:44:28 +02:00
Kwonunn	b20c0b1469	fix: don't cancel schedule workflows on push to main branch	2024-10-05 12:14:44 +02:00
Otto	f7f7800460	Merge pull request 'feat: support regexp in git-grep search' (#4968) from yoctozepto/git-grep-regexp into forgejo ... Reviewed-on: https://codeberg.org/forgejo/forgejo/pulls/4968 Reviewed-by: Shiny Nematoda <snematoda@noreply.codeberg.org>	2024-10-04 17:10:14 +00:00
Otto	2c4a3d6641	Merge pull request 'Remove some Windows-specific files' (#5353) from 0ko/forgejo:no-windows into forgejo ... Reviewed-on: https://codeberg.org/forgejo/forgejo/pulls/5353 Reviewed-by: Otto <otto@codeberg.org>	2024-10-04 14:03:07 +00:00
Kwonunn	15a407a617	log concise repo names in lfs doctor ... the old log prints the entire repo object	2024-10-03 16:15:08 +02:00
Earl Warren	d25a3709d9	Merge pull request 'chore: remove spurious comment in tests' (#5434) from earl-warren/forgejo:wip-container-cleanup into forgejo ... Reviewed-on: https://codeberg.org/forgejo/forgejo/pulls/5434 Reviewed-by: Michael Kriese <michael.kriese@gmx.de>	2024-10-01 08:37:36 +00:00
Earl Warren	aec55ac1b6	Merge pull request '[gitea] week 2024-40 cherry pick (gitea/main -> forgejo)' (#5416) from earl-warren/wcp/2024-40 into forgejo ... Reviewed-on: https://codeberg.org/forgejo/forgejo/pulls/5416 Reviewed-by: Shiny Nematoda <snematoda@noreply.codeberg.org>	2024-10-01 07:52:05 +00:00
Earl Warren	2099c2af7c	chore: remove spurious comment in tests	2024-09-30 18:47:30 +02:00
Earl Warren	0a5fd7fdb8	fix: referenced sha256:* container images may be deleted ... The inventory of the sha256:* images and the manifest index that reference them is incomplete because it does not take into account any image older than the expiration limit. As a result some sha256:* will be considered orphaned although they are referenced from a manifest index that was created more recently than the expiration limit. There must not be any filtering based on the creation time when building the inventory. The expiration limit must only be taken into account when deleting orphaned images: those that are more recent than the expiration limit must not be deleted. This limit is specially important because it protects against a race between a cleanup task and an ongoing mirroring task. A mirroring task (such as skopeo sync) will first upload sha256:* images and then create the corresponding manifest index. If a cleanup races against it, the sha256:* images that are not yet referenced will be deleted without skopeo noticing and the published index manifest that happens at a later time will contain references to non-existent images.	2024-09-30 16:56:21 +02:00
Lunny Xiao	b496317b5a	Fix bug when deleting a migrated branch (#32075) ... After migrating a repository with pull request, the branch is missed and after the pull request merged, the branch cannot be deleted. (cherry picked from commit 5a8568459d22e57cac506465463660526ca6a08f) Conflicts: services/repository/branch.go conflict because of [GITEA] Fix typo in formatting error e71b5a038e	2024-09-29 10:37:39 +02:00
Kemal Zebari	30b8b45e5e	Truncate commit message during Discord webhook push events (#31970) ... Resolves #31668. (cherry picked from commit aadbe0488f454b9f7f5a56765f4530f9d1e2c6ec)	2024-09-29 10:25:52 +02:00
Exploding Dragon	89742c4913	feat: add architecture-specific removal support for arch package (#5351) ... - [x] add architecture-specific removal support - [x] Fix upload competition - [x] Fix not checking input when downloading docs: https://codeberg.org/forgejo/docs/pulls/874 ### Release notes - [ ] I do not want this change to show in the release notes. Reviewed-on: https://codeberg.org/forgejo/forgejo/pulls/5351 Reviewed-by: Earl Warren <earl-warren@noreply.codeberg.org> Co-authored-by: Exploding Dragon <explodingfkl@gmail.com> Co-committed-by: Exploding Dragon <explodingfkl@gmail.com>	2024-09-27 08:21:22 +00:00
Earl Warren	89d9307d56	Merge pull request '[gitea] week 2024-39 cherry pick (gitea/main -> forgejo)' (#5372) from earl-warren/wcp/2024-39 into forgejo ... Reviewed-on: https://codeberg.org/forgejo/forgejo/pulls/5372 Reviewed-by: Gusted <gusted@noreply.codeberg.org>	2024-09-27 08:12:43 +00:00
Earl Warren	6275d1bc50	Refactor CSRF protector (#32057) (fix forgejo tests) ... Fix the tests unique to Forgejo that are impacted by the refactor.	2024-09-27 08:42:48 +02:00
wxiaoguang	1ae3b127fc	Refactor CSRF protector (#32057) ... Remove unused CSRF options, decouple "new csrf protector" and "prepare" logic, do not redirect to home page if CSRF validation falis (it shouldn't happen in daily usage, if it happens, redirecting to home doesn't help either but just makes the problem more complex for "fetch") (cherry picked from commit 1fede04b83288d8a91304a83b7601699bb5cba04) Conflicts: options/locale/locale_en-US.ini tests/integration/repo_branch_test.go trivial context conflicts	2024-09-27 08:42:48 +02:00
Exploding Dragon	a6508f5b03	Fix: database not updated when using git push --tags --force (#5319) ... Closes #4274 link: https://github.com/go-gitea/gitea/pull/32040 ### Release notes - [ ] I do not want this change to show in the release notes. <!--start release-notes-assistant--> ## Draft release notes <!--URL:https://codeberg.org/forgejo/forgejo--> - Bug fixes - [PR](https://codeberg.org/forgejo/forgejo/pulls/5319): <!--number 5319 --><!--line 0 --><!--description Rml4OiBkYXRhYmFzZSBub3QgdXBkYXRlZCB3aGVuIHVzaW5nIGBnaXQgcHVzaCAtLXRhZ3MgLS1mb3JjZWA=-->Fix: database not updated when using `git push --tags --force`<!--description--> <!--end release-notes-assistant--> Reviewed-on: https://codeberg.org/forgejo/forgejo/pulls/5319 Reviewed-by: Otto <otto@codeberg.org> Co-authored-by: Exploding Dragon <explodingfkl@gmail.com> Co-committed-by: Exploding Dragon <explodingfkl@gmail.com>	2024-09-22 07:35:25 +00:00
KN4CK3R	0cafec4c7a	Do not escape relative path in RPM primary index (#32038) ... Fixes #32021 Do not escape the relative path. (cherry picked from commit f528df944bb9436afcb9272add2ee0cccefbdb55)	2024-09-22 09:07:45 +02:00
0ko	d7aa109dc6	chore: remove some Windows-specific files	2024-09-19 20:39:55 +05:00
Radosław Piliszek	6d6116857c	git-grep: support regexp	2024-09-16 16:20:40 +02:00
Kemal Zebari	eb765dabfd	Handle invalid target when creating releases using API (#31841) ... A 500 status code was thrown when passing a non-existent target to the create release API. This snapshot handles this error and instead throws a 404 status code. Discovered while working on #31840. (cherry picked from commit f05d9c98c4cb95e3a8a71bf3e2f8f4529e09f96f)	2024-09-14 18:45:18 +02:00
charles-plutohealth	5af168fb92	Fix /repos/{owner}/{repo}/pulls/{index}/files endpoint not populating previous_filename (#32017) ... --- `status == "rename"` should have read `status == "renamed"`. The typo means that file.PreviousFilename would never be populated, which e.g. breaks usage of the Github Action at https://github.com/dorny/paths-filter. (cherry picked from commit 7c6edf1ba06d4c3269eaa78f4039c9123b006c51)	2024-09-14 17:53:55 +02:00
Jason Song	2da0ebbd23	Support allowed hosts for migrations to work with proxy (#32025) ... (cherry picked from commit 125679f2e14cdc8a26a147f7e8fd0e5f174fb5cb)	2024-09-14 17:52:54 +02:00
Moritz Kobel	7724559a8e	migrate scoped gitlab labels as scoped forgejo labels ... * fix handling of scoped labels * change gitlab migration test repo from gitea to forgejo * rewrite test for new gitlab test_repo, add scoped labels	2024-09-08 09:13:02 +00:00
Radosław Piliszek	f0a6ea454f	chore: remove extra go-sqlite3 imports ... go-sqlite3 is already properly included conditionally within the `modules/setting` package.	2024-09-06 09:36:08 +00:00
Zettat123	1751825256	Handle "close" actionable references for manual merges (#31879) ... Fix #31743 (cherry picked from commit 725a3ed9ad110f8354303140f527326c64f42dc8)	2024-09-01 08:07:27 +02:00
Gusted	c87655b7ff	Merge pull request '[CHORE] Move cache & captcha library' (#5146) from gusted/forgejo-captcha into forgejo ... Reviewed-on: https://codeberg.org/forgejo/forgejo/pulls/5146 Reviewed-by: Earl Warren <earl-warren@noreply.codeberg.org>	2024-08-29 08:02:09 +00:00
Solomon Victorino	471567b3ba	fix: use ValidateEmail as binding across web forms	2024-08-28 22:25:17 -06:00
Gusted	5a871f6095	[SEC] Ensure propagation of API scopes for Conan and Container authentication ... - The Conan and Container packages use a different type of authentication. It first authenticates via the regular way (api tokens or user:password, handled via `auth.Basic`) and then generates a JWT token that is used by the package software (such as Docker) to do the action they wanted to do. This JWT token didn't properly propagate the API scopes that the token was generated for, and thus could lead to a 'scope escalation' within the Conan and Container packages, read access to write access. - Store the API scope in the JWT token, so it can be propagated on subsequent calls that uses that JWT token. - Integration test added. - Resolves #5128	2024-08-28 10:33:32 +02:00
Gusted	bf0d100b84	[CHORE] Move cache library ... - This is in the spirit of #5090. - Move to a fork of gitea.com/go-chi/cache, code.forgejo.org/go-chi/cache. It removes unused code (a lot of adapters, that can't be used by Forgejo) and unused dependencies (see go.sum). Also updates existing dependencies. 8c64f1a362..main	2024-08-27 21:28:56 +02:00
Gusted	0404662e99	[CHORE] Move captcha library ... - This is a fork of https://github.com/dchest/captcha, as https://gitea.com/go-chi/captcha is a fork of github.com/go-macaron/captcha which is a fork (although not properly credited) of a older version of https://github.com/dchest/captcha. Hence why I've just forked the original. - The fork includes some QoL improvements (uses standard library for determistic RNG instead of rolling your own crypto), and removal of audio support (500KiB unused data that bloated the binary otherwise). Flips the image over the x-asis. 47270f2b55..main - This move is needed for the next commit, because gitea.com/go-chi/captcha included the gitea.com/go-chi/cache dependency.	2024-08-27 21:28:16 +02:00