troldspejlet/forgejo
troldspejlet/forgejo
1
0
Fork 0
mirror of https://codeberg.org/forgejo/forgejo.git synced 2024-11-10 20:59:31 +01:00
Code Issues Projects Releases Packages Wiki Activity Actions 4
forgejo/services/repository
History
sillyguodong 51ab495198
escape filename when assemble URL (#22850) 
Fixes: #22843 

### Cause:

affdd40296/services/repository/files/content.go (L161)

Previously, we did not escape the **"%"** that might be in "treePath"
when call "url.parse()".


![image](https://user-images.githubusercontent.com/33891828/218066318-5a909e50-2a17-46e6-b32f-684b2aa4b91f.png)

This function will check whether "%" is the beginning of an escape
character. Obviously, the "%" in the example (hello%mother.txt) is not
that. So, the function will return a error.

### Solution:
We can escape "treePath" by call "url.PathEscape()" function firstly.

### Screenshot:

![image](https://user-images.githubusercontent.com/33891828/218069781-1a030f8b-18d0-4804-b0f8-73997849ef43.png)

---------

Signed-off-by: Andrew Thornton <art27@cantab.net>
Co-authored-by: Andrew Thornton <art27@cantab.net>
2023-02-12 09:31:14 +08:00
..
archiver refactor some functions to support ctx as first parameter (#21878) 2022-12-03 10:48:26 +08:00
files escape filename when assemble URL (#22850) 2023-02-12 09:31:14 +08:00
adopt.go Repositories: by default disable all units except code and pulls on forks (#22541) 2023-02-04 14:48:38 +08:00
adopt_test.go Implement FSFE REUSE for golang files (#21840) 2022-11-27 18:20:29 +00:00
avatar.go Unify hashing for avatar (#22289) 2023-01-02 22:46:39 +01:00
avatar_test.go Unify hashing for avatar (#22289) 2023-01-02 22:46:39 +01:00
branch.go Supports wildcard protected branch (#20825) 2023-01-16 16:00:22 +08:00
cache.go Implement FSFE REUSE for golang files (#21840) 2022-11-27 18:20:29 +00:00
check.go Refactor git command package to improve security and maintainability (#22678) 2023-02-04 10:30:43 +08:00
fork.go Repositories: by default disable all units except code and pulls on forks (#22541) 2023-02-04 14:48:38 +08:00
fork_test.go Add option to prohibit fork if user reached maximum limit of repositories (#21848) 2022-12-27 15:21:14 -06:00
hooks.go Implement FSFE REUSE for golang files (#21840) 2022-11-27 18:20:29 +00:00
lfs.go Add cron method to gc LFS MetaObjects (#22385) 2023-01-16 13:50:53 -06:00
main_test.go Implement FSFE REUSE for golang files (#21840) 2022-11-27 18:20:29 +00:00
push.go Implement actions (#21937) 2023-01-31 09:45:19 +08:00
repository.go Rename almost all Ctx functions (#22071) 2022-12-10 10:46:31 +08:00
repository_test.go refactor some functions to support ctx as first parameter (#21878) 2022-12-03 10:48:26 +08:00
review.go Implement FSFE REUSE for golang files (#21840) 2022-11-27 18:20:29 +00:00
review_test.go Implement FSFE REUSE for golang files (#21840) 2022-11-27 18:20:29 +00:00
template.go Implement FSFE REUSE for golang files (#21840) 2022-11-27 18:20:29 +00:00
transfer.go Rename almost all Ctx functions (#22071) 2022-12-10 10:46:31 +08:00
transfer_test.go Rename almost all Ctx functions (#22071) 2022-12-10 10:46:31 +08:00