mirror of
https://codeberg.org/forgejo/forgejo.git
synced 2024-11-11 13:19:36 +01:00
6433ba0ec3
Use [chi](https://github.com/go-chi/chi) instead of the forked [macaron](https://gitea.com/macaron/macaron). Since macaron and chi have conflicts with session share, this big PR becomes a have-to thing. According my previous idea, we can replace macaron step by step but I'm wrong. :( Below is a list of big changes on this PR. - [x] Define `context.ResponseWriter` interface with an implementation `context.Response`. - [x] Use chi instead of macaron, and also a customize `Route` to wrap chi so that the router usage is similar as before. - [x] Create different routers for `web`, `api`, `internal` and `install` so that the codes will be more clear and no magic . - [x] Use https://github.com/unrolled/render instead of macaron's internal render - [x] Use https://github.com/NYTimes/gziphandler instead of https://gitea.com/macaron/gzip - [x] Use https://gitea.com/go-chi/session which is a modified version of https://gitea.com/macaron/session and removed `nodb` support since it will not be maintained. **BREAK** - [x] Use https://gitea.com/go-chi/captcha which is a modified version of https://gitea.com/macaron/captcha - [x] Use https://gitea.com/go-chi/cache which is a modified version of https://gitea.com/macaron/cache - [x] Use https://gitea.com/go-chi/binding which is a modified version of https://gitea.com/macaron/binding - [x] Use https://github.com/go-chi/cors instead of https://gitea.com/macaron/cors - [x] Dropped https://gitea.com/macaron/i18n and make a new one in `code.gitea.io/gitea/modules/translation` - [x] Move validation form structs from `code.gitea.io/gitea/modules/auth` to `code.gitea.io/gitea/modules/forms` to avoid dependency cycle. - [x] Removed macaron log service because it's not need any more. **BREAK** - [x] All form structs have to be get by `web.GetForm(ctx)` in the route function but not as a function parameter on routes definition. - [x] Move Git HTTP protocol implementation to use routers directly. - [x] Fix the problem that chi routes don't support trailing slash but macaron did. - [x] `/api/v1/swagger` now will be redirect to `/api/swagger` but not render directly so that `APIContext` will not create a html render. Notices: - Chi router don't support request with trailing slash - Integration test `TestUserHeatmap` maybe mysql version related. It's failed on my macOS(mysql 5.7.29 installed via brew) but succeed on CI. Co-authored-by: 6543 <6543@obermui.de>
87 lines
1.9 KiB
Go
87 lines
1.9 KiB
Go
// Copyright 2021 The Gitea Authors. All rights reserved.
|
|
// Use of this source code is governed by a MIT-style
|
|
// license that can be found in the LICENSE file.
|
|
|
|
package context
|
|
|
|
import "net/http"
|
|
|
|
// ResponseWriter represents a response writer for HTTP
|
|
type ResponseWriter interface {
|
|
http.ResponseWriter
|
|
Flush()
|
|
Status() int
|
|
Before(func(ResponseWriter))
|
|
}
|
|
|
|
var (
|
|
_ ResponseWriter = &Response{}
|
|
)
|
|
|
|
// Response represents a response
|
|
type Response struct {
|
|
http.ResponseWriter
|
|
status int
|
|
befores []func(ResponseWriter)
|
|
beforeExecuted bool
|
|
}
|
|
|
|
// Write writes bytes to HTTP endpoint
|
|
func (r *Response) Write(bs []byte) (int, error) {
|
|
if !r.beforeExecuted {
|
|
for _, before := range r.befores {
|
|
before(r)
|
|
}
|
|
r.beforeExecuted = true
|
|
}
|
|
size, err := r.ResponseWriter.Write(bs)
|
|
if err != nil {
|
|
return 0, err
|
|
}
|
|
if r.status == 0 {
|
|
r.WriteHeader(200)
|
|
}
|
|
return size, nil
|
|
}
|
|
|
|
// WriteHeader write status code
|
|
func (r *Response) WriteHeader(statusCode int) {
|
|
if !r.beforeExecuted {
|
|
for _, before := range r.befores {
|
|
before(r)
|
|
}
|
|
r.beforeExecuted = true
|
|
}
|
|
r.status = statusCode
|
|
r.ResponseWriter.WriteHeader(statusCode)
|
|
}
|
|
|
|
// Flush flush cached data
|
|
func (r *Response) Flush() {
|
|
if f, ok := r.ResponseWriter.(http.Flusher); ok {
|
|
f.Flush()
|
|
}
|
|
}
|
|
|
|
// Status returned status code written
|
|
func (r *Response) Status() int {
|
|
return r.status
|
|
}
|
|
|
|
// Before allows for a function to be called before the ResponseWriter has been written to. This is
|
|
// useful for setting headers or any other operations that must happen before a response has been written.
|
|
func (r *Response) Before(f func(ResponseWriter)) {
|
|
r.befores = append(r.befores, f)
|
|
}
|
|
|
|
// NewResponse creates a response
|
|
func NewResponse(resp http.ResponseWriter) *Response {
|
|
if v, ok := resp.(*Response); ok {
|
|
return v
|
|
}
|
|
return &Response{
|
|
ResponseWriter: resp,
|
|
status: 0,
|
|
befores: make([]func(ResponseWriter), 0),
|
|
}
|
|
}
|