forgejo/integrations
zeripath 44371b96f5 Ensure valid git author names passed in signatures (#5774)
* Ensure valid git author names passed in signatures

Fix #5772 - Git author names are not allowed to include `\n` `<` or `>` and
must not be empty. Ensure that the name passed in a signature is valid.

* Account for pathologically named external users

LDAP and the like usernames are not checked in the same way that users who signup are.
Therefore just ensure that user names are also git safe and if totally pathological -
Set them to "user-$UID"

* Add Tests and adjust test users

Make our testcases a little more pathological so that we be sure that integration
tests have a chance to spot these cases.

Signed-off-by: Andrew Thornton <art27@cantab.net>
2019-01-24 16:12:17 +02:00
..
gitea-repositories-meta
api_admin_test.go
api_branch_test.go
api_comment_test.go
api_fork_test.go
api_gpg_keys_test.go
api_issue_label_test.go
api_issue_test.go
api_keys_test.go
api_org_test.go
api_pull_test.go
api_releases_test.go
api_repo_git_ref_test.go
api_repo_lfs_locks_test.go
api_repo_raw_test.go
api_repo_test.go
api_team_test.go
api_token_test.go
api_user_heatmap_test.go
api_user_orgs_test.go
auth_ldap_test.go
benchmarks_test.go
branches_test.go
change_default_branch_test.go
delete_user_test.go
download_test.go
editor_test.go
empty_repo_test.go
explore_repos_test.go
git_test.go
html_helper.go
integration_test.go
internal_test.go
issue_test.go
lfs_getobject_test.go
links_test.go
mssql.ini.tmpl
mysql.ini.tmpl
nonascii_branches_test.go
pgsql.ini.tmpl
pull_compare_test.go
pull_create_test.go
pull_merge_test.go
README.md
README_ZH.md
release_test.go
repo_activity_test.go
repo_branch_test.go
repo_commits_test.go
repo_fork_test.go
repo_migrate_test.go
repo_search_test.go
repo_test.go
setting_test.go
signin_test.go
signout_test.go
signup_test.go
sqlite.ini
timetracking_test.go
user_test.go
version_test.go
xss_test.go

Integrations tests

Integration tests can be run with make commands for the appropriate backends, namely:

make test-mysql
make test-pgsql
make test-sqlite

Make sure to perform a clean build before running tests:

make clean build

Run all tests via local drone

drone exec --local --build-event "pull_request"

Run sqlite integrations tests

Start tests

make test-sqlite

Run mysql integrations tests

Setup a mysql database inside docker

docker run -e "MYSQL_DATABASE=test" -e "MYSQL_ALLOW_EMPTY_PASSWORD=yes" --rm --name mysql mysql:5.7 #(just ctrl-c to stop db and clean the container) 

Start tests based on the database container

TEST_MYSQL_HOST="$(docker inspect -f '{{range .NetworkSettings.Networks}}{{.IPAddress}}{{end}}' mysql):3306" TEST_MYSQL_DBNAME=test TEST_MYSQL_USERNAME=root TEST_MYSQL_PASSWORD='' make test-mysql

Run pgsql integrations tests

Setup a pgsql database inside docker

docker run -e "POSTGRES_DB=test" --rm --name pgsql postgres:9.5 #(just ctrl-c to stop db and clean the container) 

Start tests based on the database container

TEST_PGSQL_HOST=$(docker inspect -f '{{range .NetworkSettings.Networks}}{{.IPAddress}}{{end}}' pgsql) TEST_PGSQL_DBNAME=test TEST_PGSQL_USERNAME=postgres TEST_PGSQL_PASSWORD=postgres make test-pgsql

Running individual tests

Example command to run GPG test with sqlite backend:

go test -c code.gitea.io/gitea/integrations \
  -o integrations.sqlite.test -tags 'sqlite' &&
  GITEA_ROOT="$GOPATH/src/code.gitea.io/gitea" \
  GITEA_CONF=integrations/sqlite.ini ./integrations.sqlite.test \
  -test.v -test.run GPG