Beyond coding. We forge. https://forgejo.org
Find a file
oliverpool 53f6f62ad4
Store webhook event in database (#29145)
Refactor the webhook logic, to have the type-dependent processing happen
only in one place.

---

1. An event happens
2. It is pre-processed (depending on the webhook type) and its body is
added to a task queue
3. When the task is processed, some more logic (depending on the webhook
type as well) is applied to make an HTTP request

This means that webhook-type dependant logic is needed in step 2 and 3.
This is cumbersome and brittle to maintain.

Updated webhook flow with this PR:
1. An event happens
2. It is stored as-is and added to a task queue
3. When the task is processed, the event is processed (depending on the
webhook type) to make an HTTP request

So the only webhook-type dependent logic happens in one place (step 3)
which should be much more robust.

- the raw event must be stored in the hooktask (until now, the
pre-processed body was stored)
- to ensure that previous hooktasks are correctly sent, a
`payload_version` is added (version 1: the body has already been
pre-process / version 2: the body is the raw event)

So future webhook additions will only have to deal with creating an
http.Request based on the raw event (no need to adjust the code in
multiple places, like currently).

Moreover since this processing happens when fetching from the task
queue, it ensures that the queuing of new events (upon a `git push` for
instance) does not get slowed down by a slow webhook.

As a concrete example, the PR #19307 for custom webhooks, should be
substantially smaller:
- no need to change `services/webhook/deliver.go`
- minimal change in `services/webhook/webhook.go` (add the new webhook
to the map)
- no need to change all the individual webhook files (since with this
refactor the `*webhook_model.Webhook` is provided as argument)

(cherry picked from commit 26653b196bd1d15c532af41f60351596dd4330bd)

Conflicts:
	services/webhook/deliver_test.go
	trivial context conflict
2024-03-11 23:36:59 +07:00
.devcontainer
.forgejo Revert "[CI] pin go v1.21.8 version" 2024-03-06 12:14:44 +08:00
.gitea
assets [DEPS] Bump mysql driver 2024-03-10 14:57:56 +01:00
build Refactor generate-svg.js (#29348) 2024-02-26 22:30:26 +01:00
cmd Start to migrate from util.OptionalBool to optional.Option[bool] (#29329) 2024-02-26 22:30:26 +01:00
contrib
custom/conf Allow options to disable user ssh keys configuration from the interface on app.ini (#29447) 2024-03-11 23:36:57 +07:00
docker
docs Replace more gt- with tw-, update frontend docs (#29595) 2024-03-11 23:36:58 +07:00
manual-testing@877d11b403
models Store webhook event in database (#29145) 2024-03-11 23:36:59 +07:00
modules Avoid unexpected panic in graceful manager (#29629) 2024-03-11 23:36:58 +07:00
options Detect broken git hooks (#29494) 2024-03-11 23:36:58 +07:00
public Update various logos and unify their filenames (#29637) 2024-03-11 23:36:58 +07:00
releases/images
routers Cache repository default branch commit status to reduce query on commit status table (#29444) 2024-03-11 23:36:58 +07:00
services Store webhook event in database (#29145) 2024-03-11 23:36:59 +07:00
snap
templates Store webhook event in database (#29145) 2024-03-11 23:36:59 +07:00
tests Skip email domain check when admins edit user emails (#29609) 2024-03-11 23:36:58 +07:00
web_src Remove jQuery AJAX from the repo editor (#29636) 2024-03-11 23:36:59 +07:00
.air.toml
.changelog.yml
.deadcode-out [DEADCODE] update 2024-03-06 12:10:47 +08:00
.dockerignore [RELEASE] cache node_modules 2024-02-19 14:18:26 +01:00
.editorconfig
.eslintrc.yaml Remove jQuery .map() and enable eslint rules for it (#29272) 2024-02-26 21:42:15 +01:00
.gitattributes
.gitignore Ignore __debug_bin* which is generated by vscode when debugging (#29524) 2024-03-06 12:10:45 +08:00
.gitmodules
.gitpod.yml
.golangci.yml
.ignore
.markdownlint.yaml
.npmrc
.spectral.yaml
.stylelintrc.yaml Update js and py dependencies, bump python (#29561) 2024-03-06 12:10:46 +08:00
.yamllint.yaml
BSDmakefile
build.go
CHANGELOG.md
CODEOWNERS
CONTRIBUTING.md
DCO
Dockerfile [RELEASE] cache node_modules 2024-02-19 14:18:26 +01:00
Dockerfile.rootless [RELEASE] cache node_modules 2024-02-19 14:18:26 +01:00
go.mod [DEPS] Bump mysql driver 2024-03-10 14:57:56 +01:00
go.sum [DEPS] Bump mysql driver 2024-03-10 14:57:56 +01:00
LICENSE
main.go
MAINTAINERS
Makefile Regenerate fomantic lockfile and build it with our browserslist (#29560) 2024-03-11 23:36:58 +07:00
package-lock.json Inline the css-variables-parser dependency (#29571) 2024-03-11 23:36:57 +07:00
package.json Inline the css-variables-parser dependency (#29571) 2024-03-11 23:36:57 +07:00
playwright.config.js Merge pull request 'Do not run e2e tests in parallel' (#2440) from maltejur/forgejo:e2e_parallel into forgejo 2024-02-22 18:57:05 +00:00
poetry.lock Update js and py dependencies, bump python (#29561) 2024-03-06 12:10:46 +08:00
poetry.toml
pyproject.toml Update js and py dependencies, bump python (#29561) 2024-03-06 12:10:46 +08:00
README.md
RELEASE-NOTES.md [RELEASE] v1.21.7-0 release notes (cosmetic changes) 2024-03-06 18:20:27 +08:00
tailwind.config.js Adjust tailwind content globs (#29596) 2024-03-11 23:36:58 +07:00
vitest.config.js
webpack.config.js Add tailwindcss (#29357) 2024-02-26 22:30:27 +01:00

Welcome to Forgejo

Hi there! Tired of big platforms playing monopoly? Providing Git hosting for your project, friends, company or community? Forgejo (/for'd͡ʒe.jo/ inspired by forĝejo the Esperanto word for forge) has you covered with its intuitive interface, light and easy hosting and a lot of builtin functionality.

Forgejo was created in 2022 because we think that the project should be owned by an independent community. If you second that, then Forgejo is for you! Our promise: Independent Free/Libre Software forever!

What does Forgejo offer?

If you like any of the following, Forgejo is literally meant for you:

  • Lightweight: Forgejo can easily be hosted on nearly every machine. Running on a Raspberry? Small cloud instance? No problem!
  • Project management: Besides Git hosting, Forgejo offers issues, pull requests, wikis, kanban boards and much more to coordinate with your team.
  • Publishing: Have something to share? Use releases to host your software for download, or use the package registry to publish it for docker, npm and many other package managers.
  • Customizable: Want to change your look? Change some settings? There are many config switches to make Forgejo work exactly like you want.
  • Powerful: Organizations & team permissions, CI integration, Code Search, LDAP, OAuth and much more. If you have advanced needs, Forgejo has you covered.
  • Privacy: From update checker to default settings: Forgejo is built to be privacy first for you and your crew.
  • Federation: (WIP) We are actively working to connect software forges with each other through ActivityPub, and create a collaborative network of personal instances.

Learn more

Dive into the documentation, subscribe to releases and blog post on our website, find us on the Fediverse or hop into our Matrix room if you have any questions or want to get involved.

Get involved

If you are interested in making Forgejo better, either by reporting a bug or by changing the governance, please take a look at the contribution guide.