forgejo/services/gitdiff
oliverpool 0fc61c8836 [BUG] split code conversations in diff tab (#2306)
Follow-up of #2282 and #2296 (which tried to address #2278)

One of the issue with the previous PR is that when a conversation on the Files tab was marked as "resolved", it would fetch all the comments for that line (even the outdated ones, which should not be shown on this page - except when explicitly activated).

To properly fix this, I have changed `FetchCodeCommentsByLine` to `FetchCodeConversation`. Its role is to fetch all comments related to a given (review, path, line) and reverted my changes in the template (which were based on a misunderstanding).

Reviewed-on: https://codeberg.org/forgejo/forgejo/pulls/2306
Reviewed-by: Earl Warren <earl-warren@noreply.codeberg.org>
Reviewed-by: Gusted <gusted@noreply.codeberg.org>
Co-authored-by: oliverpool <git@olivier.pfad.fr>
Co-committed-by: oliverpool <git@olivier.pfad.fr>
2024-02-16 12:16:11 +00:00
..
testdata/academic-module
csv.go Use Go 1.21 and update dependencies (#26878) 2023-09-03 10:34:57 +00:00
csv_test.go Even more db.DefaultContext refactor (#27352) 2023-10-03 10:30:41 +00:00
gitdiff.go [BUG] split code conversations in diff tab (#2306) 2024-02-16 12:16:11 +00:00
gitdiff_test.go [BUG] split code conversations in diff tab (#2306) 2024-02-16 12:16:11 +00:00
highlightdiff.go Add option to disable ambiguous unicode characters detection (#28454) 2023-12-17 14:38:54 +00:00
highlightdiff_test.go
main_test.go make writing main test easier (#27270) 2023-09-28 01:38:53 +00:00