troldspejlet/forgejo
troldspejlet/forgejo
1
0
Fork 0
mirror of https://codeberg.org/forgejo/forgejo.git synced 2024-11-14 06:39:40 +01:00
Code Issues Projects Releases Packages Wiki Activity Actions 7
forgejo/web_src/js
History
Hester Gong 476a043a5f
Refactor delete_modal_actions template and use it for project column related actions (#24097) 
Co-Author: @wxiaoguang 

This PR is to fix
https://github.com/go-gitea/gitea/issues/23318#issuecomment-1506275446 .
The way to fix this in this PR is to use `delete_modal_actions.tmpl`
here both to fix this issue and keep ui consistency (as suggested by
[TODO
here](4299c3b7db/templates/projects/view.tmpl (L161)))

And this PR also refactors `delete_modal_actions.tmpl` and its related
styles, and use the template for more modal actions:

1. Added template attributes:
* locale
* ModalButtonStyle: "yes" (default) or "confirm"
* ModalButtonCancelText
* ModalButtonOkText

2. Rename `delete_modal_actions.tmpl` template to
`modal_actions_confirm.tmpl` because it is not only used for action
modals deletion now.

3. Refactored css related to modals into `web_src/css/modules/modal.css`
and improved the styles.

4. Also use the template for PR deletion modal and remove issue
dependency modal.

5. Some modals should also use the template, but not sure how to open
them, so mark these modal actions by `{{/* TODO: Convert to
base/modal_actions_confirm */}}`

After (Also tested on arc green):

Hovering on the left buttons

<img width="711" alt="Screen Shot 2023-04-23 at 15 17 12"
src="https://user-images.githubusercontent.com/17645053/233825650-76307e65-9255-44bb-80e8-7062f58ead1b.png">

<img width="786" alt="Screen Shot 2023-04-23 at 15 17 21"
src="https://user-images.githubusercontent.com/17645053/233825652-4dc6f7d1-a180-49fb-a468-d60950eaee0d.png">

Test for functionalities:

https://user-images.githubusercontent.com/17645053/233826857-76376fda-022c-42d0-b0f3-339c17ca4e59.mov

---------

Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>
2023-04-23 17:24:19 +08:00
..
components Use same action status svg icons on actions list as on action page (#24178) 2023-04-19 13:42:53 +08:00
features Refactor delete_modal_actions template and use it for project column related actions (#24097) 2023-04-23 17:24:19 +08:00
markup Fix math and mermaid rendering bugs (#24049) 2023-04-17 12:10:22 +02:00
modules Use 1.18's aria role for dropdown menus (#24144) 2023-04-16 21:58:22 +08:00
standalone Add new JS linter rules (#17699) 2021-11-22 16:19:01 +08:00
test Improve emoji and mention matching (#24255) 2023-04-22 11:32:34 -04:00
utils Improve emoji and mention matching (#24255) 2023-04-22 11:32:34 -04:00
webcomponents Refactor locale number (#24134) 2023-04-17 11:37:23 +08:00
bootstrap.js Show friendly 500 error page to users and developers (#24110) 2023-04-14 13:19:11 +08:00
index.js Use auto-updating, natively hoverable, localized time elements (#23988) 2023-04-11 01:01:20 +02:00
jquery.js Upgrade jQuery to 3.5.0, remove jQuery-Migrate, fix deprecations (#11055) 2020-04-18 18:46:29 -04:00
serviceworker.js Fix serviceworker output file and misc improvements (#11562) 2020-05-24 08:36:40 +01:00
svg.js Improve <SvgIcon> to make it output svg node and optimize performance (#23570) 2023-03-23 11:24:16 +08:00
svg.test.js Improve <SvgIcon> to make it output svg node and optimize performance (#23570) 2023-03-23 11:24:16 +08:00
utils.js Introduce GiteaLocaleNumber custom element to handle number localization on pages. (#23861) 2023-04-03 12:58:09 -04:00
utils.test.js Introduce GiteaLocaleNumber custom element to handle number localization on pages. (#23861) 2023-04-03 12:58:09 -04:00