mirror of
https://codeberg.org/forgejo/forgejo.git
synced 2024-11-24 03:21:49 +01:00
5eea61dbc8
close: #23347
### Reference and Inference
According to Github REST API
[doc](https://docs.github.com/en/rest/commits/statuses?apiVersion=2022-11-28#list-commit-statuses-for-a-reference):
1. The `Drone CI` that can create some commit status by
[API](https://docs.github.com/en/rest/commits/statuses?apiVersion=2022-11-28#create-a-commit-status)
is enabled in `go-gitea/gitea`. So I tried to call the API to get a
commit status list of a PR which is commited to upstream
repo(`go-gitea/gitea`). As a result, the API returned a array of commit
status.
2. Then I tried to call the API to get commit status list of the
reference which of the `SHA` is the same as step 1 in the repo which is
forked from `go-gitea/gitea`. But I got a empty array.
So, I believe it that：
1. The commit status is not shared between upstream repo and forked
repo.
2. The coomit status is bound to a repo that performs actions. (Gitea's
logic is the same)
### Cause
During debugging, I found it that commit status are not stored in the DB
as expected.
So, I located the following code:
8cadd51bf2/services/actions/commit_status.go (L18-L26)
When I create a PR, the type of `event` is `pull request`, not `push`.
So the code return function directly.
### Screenshot
### Other
In this PR, I also fix the problem of missing icon which represents
running in PRs list.
18 lines
577 B
Handlebars
18 lines
577 B
Handlebars
{{if eq .State "pending"}}
|
|
{{svg "octicon-dot-fill" 18 "commit-status icon text yellow"}}
|
|
{{end}}
|
|
{{if eq .State "running"}}
|
|
{{svg "octicon-dot-fill" 18 "commit-status icon text yellow"}}
|
|
{{end}}
|
|
{{if eq .State "success"}}
|
|
{{svg "octicon-check" 18 "commit-status icon text green"}}
|
|
{{end}}
|
|
{{if eq .State "error"}}
|
|
{{svg "gitea-exclamation" 18 "commit-status icon text red"}}
|
|
{{end}}
|
|
{{if eq .State "failure"}}
|
|
{{svg "octicon-x" 18 "commit-status icon text red"}}
|
|
{{end}}
|
|
{{if eq .State "warning"}}
|
|
{{svg "gitea-exclamation" 18 "commit-status icon text yellow"}}
|
|
{{end}}
|