troldspejlet/forgejo
troldspejlet/forgejo
1
0
Fork 0
mirror of https://codeberg.org/forgejo/forgejo.git synced 2024-11-14 06:39:40 +01:00
Code Issues Projects Releases Packages Wiki Activity Actions 7
forgejo/modules/git
History
Twenty Panda 5561e80b04 fix(hook): ignore unknown push options instead of failing 
If a repository has

git config --add push.pushOption submit=".sourcehut/*.yml"

it failed when pushed because of the unknown submit push
option. It will be ignored instead.

Filtering out the push options is done in an earlier stage, when the
hook command runs, before it submits the options map to the private
endpoint.

* move all the push options logic to modules/git/pushoptions
* add 100% test coverage for modules/git/pushoptions

Test coverage for the code paths from which code was moved to the
modules/git/pushoptions package:

* cmd/hook.go:runHookPreReceive
* routers/private/hook_pre_receive.go:validatePushOptions
  tests/integration/git_push_test.go:TestOptionsGitPush runs through
  both. The test verifying the option is rejected was removed and, if
  added again, will fail because the option is now ignored instead of
  being rejected.

* cmd/hook.go:runHookProcReceive
* services/agit/agit.go:ProcReceive
  tests/integration/git_test.go: doCreateAgitFlowPull runs through
  both. It uses variations of AGit related push options.

* cmd/hook.go:runHookPostReceive
* routers/private/hook_post_receive.go:HookPostReceive
  tests/integration/git_test.go:doPushCreate called by TestGit/HTTP/sha1/PushCreate
  runs through both.
  Note that although it provides coverage for this code path it does not use push options.

Fixes: https://codeberg.org/forgejo/forgejo/issues/3651
2024-07-02 21:39:01 +02:00
..
foreachref
internal
pipeline
pushoptions fix(hook): ignore unknown push options instead of failing 2024-07-02 21:39:01 +02:00
tests/repos
url
batch_reader.go
blame.go
blame_sha256_test.go
blame_test.go
blob.go
blob_gogit.go
blob_nogogit.go
blob_test.go
command.go
command_race_test.go
command_test.go
commit.go
commit_convert_gogit.go
commit_info.go
commit_info_gogit.go
commit_info_nogogit.go
commit_info_test.go
commit_reader.go
commit_sha256_test.go
commit_test.go
diff.go
diff_test.go
error.go
git.go Enable unparam linter (#31277) 2024-06-16 13:42:58 +02:00
git_test.go
grep.go
grep_test.go
hook.go
last_commit_cache.go
last_commit_cache_gogit.go
last_commit_cache_nogogit.go
log_name_status.go
notes.go
notes_gogit.go
notes_nogogit.go
notes_test.go
object_format.go Enable unparam linter (#31277) 2024-06-16 13:42:58 +02:00
object_id.go
object_id_gogit.go
object_id_test.go
object_signature.go
parse_gogit.go
parse_gogit_test.go
parse_nogogit.go
parse_nogogit_test.go
README.md
ref.go
ref_test.go
remote.go
repo.go
repo_archive.go
repo_attribute.go
repo_attribute_test.go
repo_base.go
repo_base_gogit.go
repo_base_nogogit.go
repo_blame.go
repo_blob.go
repo_blob_gogit.go
repo_blob_nogogit.go
repo_blob_test.go
repo_branch.go
repo_branch_gogit.go
repo_branch_nogogit.go
repo_branch_test.go
repo_commit.go
repo_commit_gogit.go
repo_commit_nogogit.go
repo_commit_test.go
repo_commitgraph.go
repo_commitgraph_gogit.go
repo_compare.go
repo_compare_test.go
repo_gpg.go
repo_hook.go
repo_index.go
repo_language_stats.go
repo_language_stats_gogit.go
repo_language_stats_nogogit.go
repo_language_stats_test.go
repo_object.go
repo_ref.go Fixes git references wrongly transmitted to the action run 2024-06-30 06:17:40 +02:00
repo_ref_gogit.go
repo_ref_nogogit.go
repo_ref_test.go
repo_stats.go
repo_stats_test.go
repo_tag.go
repo_tag_gogit.go
repo_tag_nogogit.go
repo_tag_test.go
repo_test.go
repo_tree.go
repo_tree_gogit.go
repo_tree_nogogit.go
signature.go
signature_gogit.go
signature_nogogit.go
signature_test.go
submodule.go
submodule_test.go
tag.go
tag_test.go
tree.go
tree_blob.go
tree_blob_gogit.go
tree_blob_nogogit.go
tree_entry.go
tree_entry_gogit.go
tree_entry_mode.go
tree_entry_nogogit.go
tree_entry_test.go
tree_gogit.go
tree_nogogit.go
tree_test.go
utils.go Refactor sha1 and time-limited code (#31023) 2024-05-26 18:43:30 +02:00
utils_test.go Refactor sha1 and time-limited code (#31023) 2024-05-26 18:43:30 +02:00

README.md

Git Module

This module is merged from https://github.com/go-gitea/git which is a Go module to access Git through shell commands. Now it's a part of gitea's main repository for easier pull request.