mirror of
https://codeberg.org/forgejo/forgejo.git
synced 2024-12-18 03:17:56 +01:00
c86be819bb
After this, we can remove [`denylist_imports`](https://gitea.com/gitea/gitea-vet/src/branch/master/checks/denylisted-imports.go#L13) in gitea-vet ([gitea-vet/pulls/23](https://gitea.com/gitea/gitea-vet/pulls/23)). ```go deniedImports = []string{"io/ioutil", "encoding/json", "gitea.com/gitea/go-crypto"} ``` However, we needn't keep `gitea.com/gitea/go-crypto` any longer, it's gone and can't be imported again. Co-authored-by: John Olheiser <john.olheiser@gmail.com>
176 lines
4.5 KiB
YAML
176 lines
4.5 KiB
YAML
linters:
|
|
enable:
|
|
- bidichk
|
|
# - deadcode # deprecated - https://github.com/golangci/golangci-lint/issues/1841
|
|
- depguard
|
|
- dupl
|
|
- errcheck
|
|
- gocritic
|
|
# - gocyclo # The cyclomatic complexety of a lot of functions is too high, we should refactor those another time.
|
|
- gofmt
|
|
- gofumpt
|
|
- gosimple
|
|
- govet
|
|
- ineffassign
|
|
- nakedret
|
|
- nolintlint
|
|
- revive
|
|
- staticcheck
|
|
# - structcheck # deprecated - https://github.com/golangci/golangci-lint/issues/1841
|
|
- stylecheck
|
|
- typecheck
|
|
- unconvert
|
|
- unused
|
|
# - varcheck # deprecated - https://github.com/golangci/golangci-lint/issues/1841
|
|
# - wastedassign # disabled - https://github.com/golangci/golangci-lint/issues/2649
|
|
enable-all: false
|
|
disable-all: true
|
|
fast: false
|
|
|
|
run:
|
|
go: 1.19
|
|
timeout: 10m
|
|
skip-dirs:
|
|
- node_modules
|
|
- public
|
|
- web_src
|
|
|
|
linters-settings:
|
|
stylecheck:
|
|
checks: ["all", "-ST1005", "-ST1003"]
|
|
nakedret:
|
|
max-func-lines: 0
|
|
gocritic:
|
|
disabled-checks:
|
|
- ifElseChain
|
|
- singleCaseSwitch # Every time this occurred in the code, there was no other way.
|
|
revive:
|
|
ignore-generated-header: false
|
|
severity: warning
|
|
confidence: 0.8
|
|
errorCode: 1
|
|
warningCode: 1
|
|
rules:
|
|
- name: blank-imports
|
|
- name: context-as-argument
|
|
- name: context-keys-type
|
|
- name: dot-imports
|
|
- name: error-return
|
|
- name: error-strings
|
|
- name: error-naming
|
|
- name: exported
|
|
- name: if-return
|
|
- name: increment-decrement
|
|
- name: var-naming
|
|
- name: var-declaration
|
|
- name: package-comments
|
|
- name: range
|
|
- name: receiver-naming
|
|
- name: time-naming
|
|
- name: unexported-return
|
|
- name: indent-error-flow
|
|
- name: errorf
|
|
- name: duplicated-imports
|
|
- name: modifies-value-receiver
|
|
gofumpt:
|
|
extra-rules: true
|
|
lang-version: "1.19"
|
|
depguard:
|
|
list-type: denylist
|
|
# Check the list against standard lib.
|
|
include-go-root: true
|
|
packages-with-error-message:
|
|
- encoding/json: "use gitea's modules/json instead of encoding/json"
|
|
- github.com/unknwon/com: "use gitea's util and replacements"
|
|
- io/ioutil: "use os or io instead"
|
|
- golang.org/x/exp: "it's experimental and unreliable."
|
|
|
|
issues:
|
|
max-issues-per-linter: 0
|
|
max-same-issues: 0
|
|
exclude-rules:
|
|
# Exclude some linters from running on tests files.
|
|
- path: _test\.go
|
|
linters:
|
|
- gocyclo
|
|
- errcheck
|
|
- dupl
|
|
- gosec
|
|
- unparam
|
|
- staticcheck
|
|
- path: models/migrations/v
|
|
linters:
|
|
- gocyclo
|
|
- errcheck
|
|
- dupl
|
|
- gosec
|
|
- linters:
|
|
- dupl
|
|
text: "webhook"
|
|
- linters:
|
|
- gocritic
|
|
text: "`ID' should not be capitalized"
|
|
- path: modules/templates/helper.go
|
|
linters:
|
|
- gocritic
|
|
- linters:
|
|
- unused
|
|
- deadcode
|
|
text: "swagger"
|
|
- path: contrib/pr/checkout.go
|
|
linters:
|
|
- errcheck
|
|
- path: models/issue.go
|
|
linters:
|
|
- errcheck
|
|
- path: models/migrations/
|
|
linters:
|
|
- errcheck
|
|
- path: modules/log/
|
|
linters:
|
|
- errcheck
|
|
- path: routers/api/v1/repo/issue_subscription.go
|
|
linters:
|
|
- dupl
|
|
- path: routers/repo/view.go
|
|
linters:
|
|
- dupl
|
|
- path: models/migrations/
|
|
linters:
|
|
- unused
|
|
- linters:
|
|
- staticcheck
|
|
text: "argument x is overwritten before first use"
|
|
- path: modules/httplib/httplib.go
|
|
linters:
|
|
- staticcheck
|
|
# Enabling this would require refactoring the methods and how they are called.
|
|
- path: models/issue_comment_list.go
|
|
linters:
|
|
- dupl
|
|
- path: models/update.go
|
|
linters:
|
|
- unused
|
|
- path: cmd/dump.go
|
|
linters:
|
|
- dupl
|
|
- path: services/webhook/webhook.go
|
|
linters:
|
|
- structcheck
|
|
- text: "commentFormatting: put a space between `//` and comment text"
|
|
linters:
|
|
- gocritic
|
|
- text: "exitAfterDefer:"
|
|
linters:
|
|
- gocritic
|
|
- path: modules/graceful/manager_windows.go
|
|
linters:
|
|
- staticcheck
|
|
text: "svc.IsAnInteractiveSession is deprecated: Use IsWindowsService instead."
|
|
- path: models/user/openid.go
|
|
linters:
|
|
- golint
|
|
- path: models/user/badge.go
|
|
linters:
|
|
- revive
|
|
text: "exported: type name will be used as user.UserBadge by other packages, and that stutters; consider calling this Badge"
|