forgejo/public/img
delvh 81fe5d6185
Convert <div class="button"> to <button class="button"> (#23337)
This improves a lot of accessibility shortcomings.
Every possible instance of `<div class="button">` matching the command
`ag '<[^ab].*?class=.*?[" ]button[ "]' templates/ | grep -v 'dropdown'`
has been converted when possible.
divs with the `dropdown` class and their children were omitted as
1. more analysis must be conducted whether the dropdowns still work as
intended when they are a `button` instead of a `div`.
2. most dropdowns have `div`s as children. The HTML standard disallows
`div`s inside `button`s.
3. When a dropdown child that's part of the displayed text content is
converted to a `button`, the dropdown can be focused twice

Further changes include that all "gitea-managed" buttons with JS code
received an `e.preventDefault()` so that they don't accidentally submit
an underlying form, which would execute instead of cancel the action.
Lastly, some minor issues were fixed as well during the refactoring.

## Future improvements

As mentioned in
https://github.com/go-gitea/gitea/pull/23337#discussion_r1127277391,
`<a>`s without `href` attribute are not focusable.
They should later on be converted to `<button>`s.

---------

Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>
Co-authored-by: silverwind <me@silverwind.io>
Co-authored-by: techknowlogick <techknowlogick@gitea.io>
Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com>
2023-03-14 11:34:09 +08:00
..
auth Add microsoft oauth2 providers (#16544) 2021-08-05 21:11:08 -04:00
emoji Add forge emojies (#16296) 2021-07-02 16:04:57 +02:00
svg Convert <div class="button"> to <button class="button"> (#23337) 2023-03-14 11:34:09 +08:00
404.png
500.png
apple-touch-icon.png
avatar_default.png
checkmark.png
dingtalk.ico
discord.png
failed.png
favicon.png
favicon.svg Modernize JS build scripts (#19824) 2022-06-06 11:27:25 +08:00
feishu.png
gitea.svg
gogs.ico
loading.png
logo.png
logo.svg
msteams.png
openid-16x16.png
packagist.png Add packagist webhook (#18224) 2022-01-23 21:46:30 +08:00
repo_default.png
slack.png
telegram.png
wechatwork.png Add support for corporate WeChat webhooks (#15910) 2021-07-23 12:41:27 +08:00