mirror of
https://codeberg.org/forgejo/forgejo.git
synced 2024-11-24 11:31:54 +01:00
e24f651c86
So I found this [linter](https://github.com/Riverside-Healthcare/djlint) which features a mode for go templates, so I gave it a try and it did find a number of valid issue, like unbalanced tags etc. It also has a number of bugs, I had to disable/workaround many issues. Given that this linter is written in python, this does add a dependency on `python` >= 3.8 and `poetry` to the development environment to be able to run this linter locally. - `e.g.` prefixes on placeholders are removed because the linter had a false-positive on `placeholder="e.g. cn=Search"` for the `attr=value` syntax and it's not ideal anyways to write `e.g.` into a placeholder because a placeholder is meant to hold a sample value. - In `templates/repo/settings/options.tmpl` I simplified the logic to not conditionally create opening tags without closing tags because this stuff confuses the linter (and possibly the reader as well). |
||
---|---|---|
.. | ||
security | ||
account.tmpl | ||
actions.tmpl | ||
appearance.tmpl | ||
applications.tmpl | ||
applications_oauth2.tmpl | ||
applications_oauth2_edit.tmpl | ||
applications_oauth2_edit_form.tmpl | ||
applications_oauth2_list.tmpl | ||
grants_oauth2.tmpl | ||
hook_new.tmpl | ||
hooks.tmpl | ||
keys.tmpl | ||
keys_gpg.tmpl | ||
keys_principal.tmpl | ||
keys_ssh.tmpl | ||
layout_footer.tmpl | ||
layout_head.tmpl | ||
navbar.tmpl | ||
organization.tmpl | ||
packages.tmpl | ||
packages_cleanup_rules_edit.tmpl | ||
packages_cleanup_rules_preview.tmpl | ||
profile.tmpl | ||
repos.tmpl | ||
runner_edit.tmpl |